* [PATCH v1 1/1] gpio: Remove unused local OF node pointers
@ 2021-12-20 13:24 Andy Shevchenko
2021-12-20 14:53 ` Bartosz Golaszewski
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-12-20 13:24 UTC (permalink / raw)
To: Andy Shevchenko, Sergio Paracuellos, Marc Zyngier,
bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel,
linux-kernel, linux-mediatek, linux-unisoc
Cc: Gregory Fong, Linus Walleij, Bartosz Golaszewski,
Florian Fainelli, Matthias Brugger, Manivannan Sadhasivam,
Stephen Rothwell
After the commit 448cf90513d9 ("gpio: Get rid of duplicate of_node
assignment in the drivers") the OF node local pointers become unused.
Remove them for good and make compiler happy about.
Fixes: 448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-brcmstb.c | 2 +-
drivers/gpio/gpio-gw-pld.c | 1 -
drivers/gpio/gpio-mt7621.c | 5 ++---
drivers/gpio/gpio-rda.c | 1 -
4 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 176c264bb959..74ef89248867 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -704,7 +704,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
}
gc->owner = THIS_MODULE;
- gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
+ gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
if (!gc->label) {
err = -ENOMEM;
goto fail;
diff --git a/drivers/gpio/gpio-gw-pld.c b/drivers/gpio/gpio-gw-pld.c
index 77a3fbd46111..2109803ffb38 100644
--- a/drivers/gpio/gpio-gw-pld.c
+++ b/drivers/gpio/gpio-gw-pld.c
@@ -71,7 +71,6 @@ static int gw_pld_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct device *dev = &client->dev;
- struct device_node *np = dev->of_node;
struct gw_pld *gw;
int ret;
diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index 52b49e7a0a80..ccaad1cb3c2e 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -205,8 +205,7 @@ mediatek_gpio_xlate(struct gpio_chip *chip,
}
static int
-mediatek_gpio_bank_probe(struct device *dev,
- struct device_node *node, int bank)
+mediatek_gpio_bank_probe(struct device *dev, int bank)
{
struct mtk *mtk = dev_get_drvdata(dev);
struct mtk_gc *rg;
@@ -310,7 +309,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mtk);
for (i = 0; i < MTK_BANK_CNT; i++) {
- ret = mediatek_gpio_bank_probe(dev, np, i);
+ ret = mediatek_gpio_bank_probe(dev, i);
if (ret)
return ret;
}
diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c
index 0d03f525dcd3..62ba18b3a602 100644
--- a/drivers/gpio/gpio-rda.c
+++ b/drivers/gpio/gpio-rda.c
@@ -197,7 +197,6 @@ static void rda_gpio_irq_handler(struct irq_desc *desc)
static int rda_gpio_probe(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.of_node;
struct device *dev = &pdev->dev;
struct gpio_irq_chip *girq;
struct rda_gpio *rda_gpio;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers
2021-12-20 13:24 [PATCH v1 1/1] gpio: Remove unused local OF node pointers Andy Shevchenko
@ 2021-12-20 14:53 ` Bartosz Golaszewski
2021-12-20 15:09 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Bartosz Golaszewski @ 2021-12-20 14:53 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Sergio Paracuellos, Marc Zyngier, bcm-kernel-feedback-list,
open list:GPIO SUBSYSTEM, Linux ARM, Linux Kernel Mailing List,
moderated list:ARM/Mediatek SoC...,
linux-unisoc, Gregory Fong, Linus Walleij, Florian Fainelli,
Matthias Brugger, Manivannan Sadhasivam, Stephen Rothwell
On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> After the commit 448cf90513d9 ("gpio: Get rid of duplicate of_node
> assignment in the drivers") the OF node local pointers become unused.
> Remove them for good and make compiler happy about.
>
> Fixes: 448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-brcmstb.c | 2 +-
> drivers/gpio/gpio-gw-pld.c | 1 -
> drivers/gpio/gpio-mt7621.c | 5 ++---
> drivers/gpio/gpio-rda.c | 1 -
> 4 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index 176c264bb959..74ef89248867 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -704,7 +704,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
> }
>
> gc->owner = THIS_MODULE;
> - gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> + gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
This is unrelated though. Can you make it a separate patch?
Bart
> if (!gc->label) {
> err = -ENOMEM;
> goto fail;
> diff --git a/drivers/gpio/gpio-gw-pld.c b/drivers/gpio/gpio-gw-pld.c
> index 77a3fbd46111..2109803ffb38 100644
> --- a/drivers/gpio/gpio-gw-pld.c
> +++ b/drivers/gpio/gpio-gw-pld.c
> @@ -71,7 +71,6 @@ static int gw_pld_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct device *dev = &client->dev;
> - struct device_node *np = dev->of_node;
> struct gw_pld *gw;
> int ret;
>
> diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
> index 52b49e7a0a80..ccaad1cb3c2e 100644
> --- a/drivers/gpio/gpio-mt7621.c
> +++ b/drivers/gpio/gpio-mt7621.c
> @@ -205,8 +205,7 @@ mediatek_gpio_xlate(struct gpio_chip *chip,
> }
>
> static int
> -mediatek_gpio_bank_probe(struct device *dev,
> - struct device_node *node, int bank)
> +mediatek_gpio_bank_probe(struct device *dev, int bank)
> {
> struct mtk *mtk = dev_get_drvdata(dev);
> struct mtk_gc *rg;
> @@ -310,7 +309,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, mtk);
>
> for (i = 0; i < MTK_BANK_CNT; i++) {
> - ret = mediatek_gpio_bank_probe(dev, np, i);
> + ret = mediatek_gpio_bank_probe(dev, i);
> if (ret)
> return ret;
> }
> diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c
> index 0d03f525dcd3..62ba18b3a602 100644
> --- a/drivers/gpio/gpio-rda.c
> +++ b/drivers/gpio/gpio-rda.c
> @@ -197,7 +197,6 @@ static void rda_gpio_irq_handler(struct irq_desc *desc)
>
> static int rda_gpio_probe(struct platform_device *pdev)
> {
> - struct device_node *np = pdev->dev.of_node;
> struct device *dev = &pdev->dev;
> struct gpio_irq_chip *girq;
> struct rda_gpio *rda_gpio;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers
2021-12-20 14:53 ` Bartosz Golaszewski
@ 2021-12-20 15:09 ` Andy Shevchenko
2021-12-21 19:13 ` Bartosz Golaszewski
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-12-20 15:09 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Shevchenko, Sergio Paracuellos, Marc Zyngier,
bcm-kernel-feedback-list, open list:GPIO SUBSYSTEM, Linux ARM,
Linux Kernel Mailing List, moderated list:ARM/Mediatek SoC...,
linux-unisoc, Gregory Fong, Linus Walleij, Florian Fainelli,
Matthias Brugger, Manivannan Sadhasivam, Stephen Rothwell
On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > After the commit 448cf90513d9 ("gpio: Get rid of duplicate of_node
> > assignment in the drivers") the OF node local pointers become unused.
> > Remove them for good and make compiler happy about.
> >
> > Fixes: 448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> > - gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> > + gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
>
> This is unrelated though. Can you make it a separate patch?
It actually makes use of the local np IIRC.
It's related, no?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers
2021-12-20 15:09 ` Andy Shevchenko
@ 2021-12-21 19:13 ` Bartosz Golaszewski
2021-12-21 20:21 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Bartosz Golaszewski @ 2021-12-21 19:13 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Andy Shevchenko, Sergio Paracuellos, Marc Zyngier,
bcm-kernel-feedback-list, open list:GPIO SUBSYSTEM, Linux ARM,
Linux Kernel Mailing List, moderated list:ARM/Mediatek SoC...,
linux-unisoc, Gregory Fong, Linus Walleij, Florian Fainelli,
Matthias Brugger, Manivannan Sadhasivam, Stephen Rothwell
On Mon, Dec 20, 2021 at 4:11 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > After the commit 448cf90513d9 ("gpio: Get rid of duplicate of_node
> > > assignment in the drivers") the OF node local pointers become unused.
> > > Remove them for good and make compiler happy about.
> > >
> > > Fixes: 448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ...
>
> > > - gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> > > + gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
> >
> > This is unrelated though. Can you make it a separate patch?
>
> It actually makes use of the local np IIRC.
> It's related, no?
No, the np pointer is already used elsewhere. You just replace the
dev->of_node here with np. Rightfully so, but it's not part of this
commit logically.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers
2021-12-21 19:13 ` Bartosz Golaszewski
@ 2021-12-21 20:21 ` Andy Shevchenko
2021-12-22 9:06 ` Bartosz Golaszewski
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-12-21 20:21 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Shevchenko, Sergio Paracuellos, Marc Zyngier,
bcm-kernel-feedback-list, open list:GPIO SUBSYSTEM, Linux ARM,
Linux Kernel Mailing List, moderated list:ARM/Mediatek SoC...,
linux-unisoc, Gregory Fong, Linus Walleij, Florian Fainelli,
Matthias Brugger, Manivannan Sadhasivam, Stephen Rothwell
On Tue, Dec 21, 2021 at 9:13 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Mon, Dec 20, 2021 at 4:11 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > > - gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> > > > + gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
> > >
> > > This is unrelated though. Can you make it a separate patch?
> >
> > It actually makes use of the local np IIRC.
> > It's related, no?
>
> No, the np pointer is already used elsewhere. You just replace the
> dev->of_node here with np. Rightfully so, but it's not part of this
> commit logically.
I see. Probably I missed that somehow.
Nevertheless, do you want a new version or can you just revert that
particular change?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers
2021-12-21 20:21 ` Andy Shevchenko
@ 2021-12-22 9:06 ` Bartosz Golaszewski
2021-12-22 11:00 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Bartosz Golaszewski @ 2021-12-22 9:06 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Andy Shevchenko, Sergio Paracuellos, Marc Zyngier,
bcm-kernel-feedback-list, open list:GPIO SUBSYSTEM, Linux ARM,
Linux Kernel Mailing List, moderated list:ARM/Mediatek SoC...,
linux-unisoc, Gregory Fong, Linus Walleij, Florian Fainelli,
Matthias Brugger, Manivannan Sadhasivam, Stephen Rothwell
On Tue, Dec 21, 2021 at 9:21 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Dec 21, 2021 at 9:13 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > On Mon, Dec 20, 2021 at 4:11 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
>
> ...
>
> > > > > - gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> > > > > + gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
> > > >
> > > > This is unrelated though. Can you make it a separate patch?
> > >
> > > It actually makes use of the local np IIRC.
> > > It's related, no?
> >
> > No, the np pointer is already used elsewhere. You just replace the
> > dev->of_node here with np. Rightfully so, but it's not part of this
> > commit logically.
>
> I see. Probably I missed that somehow.
> Nevertheless, do you want a new version or can you just revert that
> particular change?
>
> --
> With Best Regards,
> Andy Shevchenko
I removed it and queued the rest.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers
2021-12-22 9:06 ` Bartosz Golaszewski
@ 2021-12-22 11:00 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2021-12-22 11:00 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Sergio Paracuellos, Marc Zyngier, bcm-kernel-feedback-list,
open list:GPIO SUBSYSTEM, Linux ARM, Linux Kernel Mailing List,
moderated list:ARM/Mediatek SoC...,
linux-unisoc, Gregory Fong, Linus Walleij, Florian Fainelli,
Matthias Brugger, Manivannan Sadhasivam, Stephen Rothwell
On Wed, Dec 22, 2021 at 10:06:53AM +0100, Bartosz Golaszewski wrote:
> On Tue, Dec 21, 2021 at 9:21 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Dec 21, 2021 at 9:13 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
...
> > I see. Probably I missed that somehow.
> > Nevertheless, do you want a new version or can you just revert that
> > particular change?
>
> I removed it and queued the rest.
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-12-22 11:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 13:24 [PATCH v1 1/1] gpio: Remove unused local OF node pointers Andy Shevchenko
2021-12-20 14:53 ` Bartosz Golaszewski
2021-12-20 15:09 ` Andy Shevchenko
2021-12-21 19:13 ` Bartosz Golaszewski
2021-12-21 20:21 ` Andy Shevchenko
2021-12-22 9:06 ` Bartosz Golaszewski
2021-12-22 11:00 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).