* [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API
@ 2022-01-02 10:29 Christophe JAILLET
2022-01-03 9:23 ` Christoph Hellwig
2022-01-10 1:50 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-01-02 10:29 UTC (permalink / raw)
To: mpe, benh, paulus
Cc: linuxppc-dev, linux-kernel, kernel-janitors, Christophe JAILLET
In [1], Christoph Hellwig has proposed to remove the wrappers in
include/linux/pci-dma-compat.h.
Some reasons why this API should be removed have been given by Julia
Lawall in [2].
A coccinelle script has been used to perform the needed transformation
Only relevant parts are given below.
@@ @@
- PCI_DMA_TODEVICE
+ DMA_TO_DEVICE
@@ @@
- PCI_DMA_FROMDEVICE
+ DMA_FROM_DEVICE
@@
expression e1, e2, e3, e4;
@@
- pci_map_single(e1, e2, e3, e4)
+ dma_map_single(&e1->dev, e2, e3, e4)
@@
expression e1, e2, e3, e4;
@@
- pci_unmap_single(e1, e2, e3, e4)
+ dma_unmap_single(&e1->dev, e2, e3, e4)
[1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
[2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
arch/powerpc/include/asm/floppy.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/include/asm/floppy.h b/arch/powerpc/include/asm/floppy.h
index 7af9a68fd949..f8ce178b43b7 100644
--- a/arch/powerpc/include/asm/floppy.h
+++ b/arch/powerpc/include/asm/floppy.h
@@ -134,17 +134,19 @@ static int hard_dma_setup(char *addr, unsigned long size, int mode, int io)
int dir;
doing_vdma = 0;
- dir = (mode == DMA_MODE_READ) ? PCI_DMA_FROMDEVICE : PCI_DMA_TODEVICE;
+ dir = (mode == DMA_MODE_READ) ? DMA_FROM_DEVICE : DMA_TO_DEVICE;
if (bus_addr
&& (addr != prev_addr || size != prev_size || dir != prev_dir)) {
/* different from last time -- unmap prev */
- pci_unmap_single(isa_bridge_pcidev, bus_addr, prev_size, prev_dir);
+ dma_unmap_single(&isa_bridge_pcidev->dev, bus_addr, prev_size,
+ prev_dir);
bus_addr = 0;
}
if (!bus_addr) /* need to map it */
- bus_addr = pci_map_single(isa_bridge_pcidev, addr, size, dir);
+ bus_addr = dma_map_single(&isa_bridge_pcidev->dev, addr, size,
+ dir);
/* remember this one as prev */
prev_addr = addr;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-02 10:29 [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
@ 2022-01-03 9:23 ` Christoph Hellwig
2022-01-10 1:50 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-01-03 9:23 UTC (permalink / raw)
To: Christophe JAILLET
Cc: mpe, benh, paulus, linuxppc-dev, linux-kernel, kernel-janitors
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-02 10:29 [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
2022-01-03 9:23 ` Christoph Hellwig
@ 2022-01-10 1:50 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2022-01-10 1:50 UTC (permalink / raw)
To: benh, paulus, mpe, Christophe JAILLET
Cc: linux-kernel, linuxppc-dev, kernel-janitors
On Sun, 2 Jan 2022 11:29:54 +0100, Christophe JAILLET wrote:
> In [1], Christoph Hellwig has proposed to remove the wrappers in
> include/linux/pci-dma-compat.h.
>
> Some reasons why this API should be removed have been given by Julia
> Lawall in [2].
>
> A coccinelle script has been used to perform the needed transformation
> Only relevant parts are given below.
>
> [...]
Applied to powerpc/next.
[1/1] floppy: Remove usage of the deprecated "pci-dma-compat.h" API
https://git.kernel.org/powerpc/c/e57c2fd6cdf8db581ac93b909b2664751e7cf30c
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-10 1:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-02 10:29 [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
2022-01-03 9:23 ` Christoph Hellwig
2022-01-10 1:50 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).