From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Frank Rowand <frowand.list@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ansuel Smith <ansuelsmth@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 2/8] dt-bindings: nvmem: add transformation bindings
Date: Tue, 4 Jan 2022 09:03:54 -0600 [thread overview]
Message-ID: <YdRh2lp5Ca08gHtR@robh.at.kernel.org> (raw)
In-Reply-To: <20211228142549.1275412-3-michael@walle.cc>
On Tue, Dec 28, 2021 at 03:25:43PM +0100, Michael Walle wrote:
> Just add a simple list of the supported devices which need a nvmem
> transformations.
>
> Also, since the compatible string is prepended to the actual nvmem
> compatible string, we need to match using "contains" instead of an exact
> match.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> .../devicetree/bindings/mtd/mtd.yaml | 7 +--
> .../bindings/nvmem/nvmem-transformations.yaml | 46 +++++++++++++++++++
> 2 files changed, 50 insertions(+), 3 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/nvmem/nvmem-transformations.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
> index 376b679cfc70..0291e439b6a6 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
> @@ -33,9 +33,10 @@ patternProperties:
>
> properties:
> compatible:
> - enum:
> - - user-otp
> - - factory-otp
> + contains:
> + enum:
> + - user-otp
> + - factory-otp
If the addition is only compatible strings, then I would just add them
here. Otherwise this needs to be structured a bit differently. More on
that below.
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem-transformations.yaml b/Documentation/devicetree/bindings/nvmem/nvmem-transformations.yaml
> new file mode 100644
> index 000000000000..8c8d85fd6d27
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem-transformations.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/nvmem-transformations.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVMEM transformations Device Tree Bindings
> +
> +maintainers:
> + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> +
> +description: |
> + This is a list NVMEM devices which need transformations.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - kontron,sl28-vpd
> + - const: user-otp
> + - const: user-otp
This will be applied to any node containing 'user-otp'. You need a
custom 'select' to avoid that.
> +
> +required:
> + - compatible
> +
> +additionalProperties: true
True is only allowed for common schema intended to be included (i.e. a
$ref) by other schemas. IOW, ones that are incomplete on their own. So
you need to reference mtd.yaml and make this 'unevaluatedProperties: false'.
> +
> +examples:
> + - |
> + otp-1 {
> + compatible = "kontron,sl28-vpd", "user-otp";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + serial@2 {
> + reg = <2 15>;
> + };
> +
> + base_mac_address: base-mac-address@17 {
> + #nvmem-cell-cells = <1>;
> + reg = <17 6>;
> + };
> + };
> +
> +...
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2022-01-04 15:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 14:25 [PATCH 0/8] nvmem: add ethernet address offset support Michael Walle
2021-12-28 14:25 ` [PATCH 1/8] of: base: add of_parse_phandle_with_optional_args() Michael Walle
2022-01-10 19:06 ` Rob Herring
2021-12-28 14:25 ` [PATCH 2/8] dt-bindings: nvmem: add transformation bindings Michael Walle
2021-12-29 17:34 ` Rob Herring
2022-01-04 15:03 ` Rob Herring [this message]
2022-01-05 8:25 ` Michael Walle
2022-01-05 14:20 ` Rob Herring
2021-12-28 14:25 ` [PATCH 3/8] nvmem: core: add an index parameter to the cell Michael Walle
2021-12-28 14:25 ` [PATCH 4/8] nvmem: core: add transformations support Michael Walle
2021-12-28 14:25 ` [PATCH 5/8] net: add helper eth_addr_add() Michael Walle
2022-01-25 10:24 ` Rafał Miłecki
2022-08-25 9:46 ` Michael Walle
2021-12-28 14:25 ` [PATCH 6/8] nvmem: transformations: ethernet address offset support Michael Walle
2022-01-25 12:08 ` Rafał Miłecki
2022-01-25 14:59 ` Michael Walle
2021-12-28 14:25 ` [PATCH 7/8] arm64: dts: ls1028a: sl28: get MAC addresses from VPD Michael Walle
2021-12-28 14:25 ` [PATCH 8/8] arm64: defconfig: enable NVMEM transformations Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdRh2lp5Ca08gHtR@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).