[PATCH] fs: ext4: remove duplicate includes

[PATCH] fs: ext4: remove duplicate includes

[Guo Zhengkui]

remove a duplicate "#include <linux/dax.h>".

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 fs/ext4/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index ccafcbc146d3..973ea307041a 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -27,35 +27,34 @@
 #include <linux/dax.h>
 #include <linux/quotaops.h>
 #include <linux/string.h>
 #include <linux/buffer_head.h>
 #include <linux/writeback.h>
 #include <linux/pagevec.h>
 #include <linux/mpage.h>
 #include <linux/namei.h>
 #include <linux/uio.h>
 #include <linux/bio.h>
 #include <linux/workqueue.h>
 #include <linux/kernel.h>
 #include <linux/printk.h>
 #include <linux/slab.h>
 #include <linux/bitops.h>
 #include <linux/iomap.h>
 #include <linux/iversion.h>
-#include <linux/dax.h>
 
 #include "ext4_jbd2.h"
 #include "xattr.h"
 #include "acl.h"
 #include "truncate.h"
 
 #include <trace/events/ext4.h>
 
 static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
 			      struct ext4_inode_info *ei)
 {
 	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
 	__u32 csum;
 	__u16 dummy_csum = 0;
 	int offset = offsetof(struct ext4_inode, i_checksum_lo);
 	unsigned int csum_size = sizeof(dummy_csum);
 
-- 
2.20.1

Re: [PATCH] fs: ext4: remove duplicate includes

[Theodore Ts'o]

On Tue, Dec 07, 2021 at 05:04:30PM +0800, Guo Zhengkui wrote:
> remove a duplicate "#include <linux/dax.h>".
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>

I'm confused.  I can't find any kernel version for which this applies.
Both at HEAD, and for all of 5.x, there is only a single #include of
the linux/dax.h header file:

% for i in $(seq 0 15) ; do git show v5.$i:fs/ext4/inode.c | grep linux/dax.h | wc -l ; done

show that for 5.0..5.15, "linux/dax.h" only appears once in
fs/ext4/inode.c.

						- Ted