* linux-next: Fixes tag needs some work in the tpmdd tree
@ 2022-01-03 21:32 Stephen Rothwell
2022-01-06 19:07 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2022-01-03 21:32 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Lino Sanfilippo, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
Hi all,
In commit
8ca8e009e216 ("tpm: fix potential NULL pointer access in tpm_del_char_device")
Fixes tag
Fixes: 39d0099f9439 ("powerpc/pseries: Add shutdown() to vio_driver and
has these problem(s):
- Subject has leading but no trailing quotes
Presumably you meant
Fixes: 39d0099f9439 ("powerpc/pseries: Add shutdown() to vio_driver and vio_bus")
Please do not truncate or split these tag lines.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: Fixes tag needs some work in the tpmdd tree
2022-01-03 21:32 linux-next: Fixes tag needs some work in the tpmdd tree Stephen Rothwell
@ 2022-01-06 19:07 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2022-01-06 19:07 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Lino Sanfilippo, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Jan 04, 2022 at 08:32:24AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 8ca8e009e216 ("tpm: fix potential NULL pointer access in tpm_del_char_device")
>
> Fixes tag
>
> Fixes: 39d0099f9439 ("powerpc/pseries: Add shutdown() to vio_driver and
>
> has these problem(s):
>
> - Subject has leading but no trailing quotes
>
> Presumably you meant
>
> Fixes: 39d0099f9439 ("powerpc/pseries: Add shutdown() to vio_driver and vio_bus")
>
> Please do not truncate or split these tag lines.
>
> --
> Cheers,
> Stephen Rothwell
Hi, I fixed this in my tree, and send updated to PR to Linus. Thank you.
BR,
Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the tpmdd tree
@ 2020-03-14 10:53 Stephen Rothwell
2020-03-15 18:14 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-03-14 10:53 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stefan Berger
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi all,
In commit
606c8d992ba5 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Fixes tag
Fixes: 132f76294744 ("Add new device driver to support IBM vTPM")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: Fixes tag needs some work in the tpmdd tree
2020-03-14 10:53 Stephen Rothwell
@ 2020-03-15 18:14 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-03-15 18:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stefan Berger
On Sat, Mar 14, 2020 at 09:53:07PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 606c8d992ba5 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
>
> Fixes tag
>
> Fixes: 132f76294744 ("Add new device driver to support IBM vTPM")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> --
> Cheers,
> Stephen Rothwell
Thanks, has been fixed now.
Stefan, please do modify the short summary next time when you add a
fixes tag. Thanks.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the tpmdd tree
@ 2019-07-11 21:37 Stephen Rothwell
2019-07-12 3:46 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-07-11 21:37 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Nayna Jain
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
Hi all,
In commit
0ce9bf1a55c9 ("tpm: tpm_ibm_vtpm: Fix unallocated banks")
Fixes tag
Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: Fixes tag needs some work in the tpmdd tree
2019-07-11 21:37 Stephen Rothwell
@ 2019-07-12 3:46 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2019-07-12 3:46 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Nayna Jain
On Fri, Jul 12, 2019 at 07:37:03AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 0ce9bf1a55c9 ("tpm: tpm_ibm_vtpm: Fix unallocated banks")
>
> Fixes tag
>
> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
Fixed.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-06 19:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03 21:32 linux-next: Fixes tag needs some work in the tpmdd tree Stephen Rothwell
2022-01-06 19:07 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2020-03-14 10:53 Stephen Rothwell
2020-03-15 18:14 ` Jarkko Sakkinen
2019-07-11 21:37 Stephen Rothwell
2019-07-12 3:46 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).