Re: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

Re: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

On Tue, Dec 07, 2021 at 10:05:56AM +0100, André Werner wrote:
>  From 6dda12150785665ddd1059d53aa22bf902bfe4aa Mon Sep 17 00:00:00 2001
> From: Andre Werner <andre.werner@systec-electronic.com>
> Date: Mon, 22 Nov 2021 15:40:17 +0100
> Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for 
> LDOs
> 
> Within the defines of the register masks for LDO3 and LDO4,
> the most significant bit was missing. The datasheet said
> the range is 4:0 bits. Thus, the output voltage cannot be
> set above 1.7V for each.

Please submit patches using subject lines and a format reflecting the
style for the subsystem, this makes it easier for people to identify
relevant patches.  Look at what existing commits in the area you're
changing are doing and make sure your subject lines visually resemble
what they're doing.  There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

On Fri, Dec 03, 2021 at 03:55:13PM +0100, Andre Werner wrote:

> Within the defines of the register masks for LDO3 and LDO4,
> the most significant bit was missing. The datasheet said
> the range is 4:0 bits. Thus, the output voltage cannot be
> set above 1.7V for each.

Actually this doesn't apply against current code:

Applying: regulator: pca9450.h: Correct register masks for LDOs
Using index info to reconstruct a base tree...
error: patch failed: include/linux/regulator/pca9450.h:196
error: include/linux/regulator/pca9450.h: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.

Please check and resend - I suspect it'd been mangled by your mail
software.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

[André Werner]

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]


 From 6dda12150785665ddd1059d53aa22bf902bfe4aa Mon Sep 17 00:00:00 2001
From: Andre Werner <andre.werner@systec-electronic.com>
Date: Mon, 22 Nov 2021 15:40:17 +0100
Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs

Within the defines of the register masks for LDO3 and LDO4,
the most significant bit was missing. The datasheet said
the range is 4:0 bits. Thus, the output voltage cannot be
set above 1.7V for each.

Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
---
  include/linux/regulator/pca9450.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/regulator/pca9450.h  
b/include/linux/regulator/pca9450.h
index 71902f41c919..0c3edff6bdff 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {

  /* PCA9450_REG_LDO3_VOLT bits */
  #define LDO3_EN_MASK                   0xC0
-#define LDO3OUT_MASK                   0x0F
+#define LDO3OUT_MASK                   0x1F

  /* PCA9450_REG_LDO4_VOLT bits */
  #define LDO4_EN_MASK                   0xC0
-#define LDO4OUT_MASK                   0x0F
+#define LDO4OUT_MASK                   0x1F

  /* PCA9450_REG_LDO5_VOLT bits */
  #define LDO5L_EN_MASK                  0xC0
-- 
2.31.1


[-- Attachment #2: PGP Public Key --]
[-- Type: application/pgp-keys, Size: 1263 bytes --]