From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: conleylee@foxmail.com
Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org,
wens@csie.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] sun4i-emac: replace magic number with marcos
Date: Mon, 10 Jan 2022 09:32:24 +0100 [thread overview]
Message-ID: <YdvvGAzD7KQlxBZo@Red> (raw)
In-Reply-To: <tencent_58B12979F0BFDB1520949A6DB536ED15940A@qq.com>
Le Mon, Jan 10, 2022 at 03:23:07PM +0800, conleylee@foxmail.com a écrit :
> From: conley <conleylee@foxmail.com>
>
> - sun4i-emac.h: add register related marcos
> - sun4i-emac.c: replace magic number with marco
>
> *** BLURB HERE ***
>
> conley (2):
> sun4i-emac.h: add register related marcos
> sun4i-emac.c: replace magic number with macro
>
> drivers/net/ethernet/allwinner/sun4i-emac.c | 26 ++++++++++-----------
> drivers/net/ethernet/allwinner/sun4i-emac.h | 18 ++++++++++++++
> 2 files changed, 31 insertions(+), 13 deletions(-)
>
Hello
The from should be your real name.
You miss commit message.
The subject should be "net: allwinner: xxxx" or "net: ethernet: sun4i-emac: xxxx"
You did a typo marcos/macros
If you add a changelog, either put it in cover letter or below "---" in patch along git stats (changelog should not be part of commit message).
I think both patch should be merged.
Regards
next prev parent reply other threads:[~2022-01-10 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 7:23 [PATCH 0/2] sun4i-emac: replace magic number with marcos conleylee
2022-01-10 8:32 ` Corentin Labbe [this message]
2022-01-10 11:35 ` [PATCH v2] net: ethernet: sun4i-emac: replace magic number with macro Conley Lee
2022-01-10 13:05 ` Leon Romanovsky
2022-01-10 14:42 ` Conley Lee
2022-01-10 13:31 ` Andrew Lunn
2022-01-10 14:40 ` Conley Lee
2022-01-10 13:56 ` Corentin Labbe
2022-01-10 17:28 ` Jakub Kicinski
2022-01-11 3:19 ` Conley Lee
2022-01-11 3:05 ` [PATCH v3] " Conley Lee
2022-01-11 16:32 ` Corentin Labbe
2022-01-12 6:16 ` Conley Lee
2022-01-12 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdvvGAzD7KQlxBZo@Red \
--to=clabbe.montjoie@gmail.com \
--cc=conleylee@foxmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).