linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: ratnesh-r1 <me.ratnesh682@gmail.com>
Cc: devel@driverdev.osuosl.org, "Todd Kjos" <tkjos@android.com>,
	linux-kernel@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	"Martijn Coenen" <maco@android.com>,
	"Christian Brauner" <christian@brauner.io>
Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword
Date: Mon, 24 Jan 2022 08:39:16 +0100	[thread overview]
Message-ID: <Ye5XpLe8FkyfEX/k@kroah.com> (raw)
In-Reply-To: <1643008187-75859-1-git-send-email-me.ratnesh682@gmail.com>

On Sun, Jan 23, 2022 at 11:09:47PM -0800, ratnesh-r1 wrote:
> warning found by checkpatch.pl script.
> 
> Signed-off-by: ratnesh-r1 <me.ratnesh682@gmail.com>
> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index c05a214..f9cfa15 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	static const struct file_operations vmfile_fops;
>  	struct ashmem_area *asma = file->private_data;
>  	int ret = 0;
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch breaks the build.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  reply	other threads:[~2022-01-24  7:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24  7:09 [PATCH] staging: android: ashmem: Declared file operation with const keyword ratnesh-r1
2022-01-24  7:39 ` Greg Kroah-Hartman [this message]
2022-01-24 11:20 ` kernel test robot
2022-01-24 12:27 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-05-19  8:19 [PATCH] staging: android: ashmem: Declared file operation with 'const' keyword Hriday Hegde
2021-05-19  8:31 ` Greg Kroah-Hartman
2021-05-19  9:30   ` Hriday Hegde
2021-05-19  9:50     ` Greg Kroah-Hartman
2021-05-19 14:36       ` Hriday Hegde
2021-05-19 14:51         ` Fabio Aiuto
2021-05-19 15:54           ` Hriday Hegde
2021-05-19 14:55         ` Greg Kroah-Hartman
2021-05-19 15:56           ` Hriday Hegde
2021-02-14  2:31 [PATCH] staging: android: ashmem: Declared file operation with const keyword Thais Camacho
2021-02-14  4:49 ` kernel test robot
2021-02-14  8:21 ` Greg Kroah-Hartman
2020-12-28  5:13 jovin555
2020-12-28  6:35 ` Greg Kroah-Hartman
2021-01-05 11:52 ` Dan Carpenter
2020-03-28 15:15 SandeshKenjanaAshok
2020-03-29  6:58 ` Greg Kroah-Hartman
2020-03-29 12:54 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye5XpLe8FkyfEX/k@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=christian@brauner.io \
    --cc=devel@driverdev.osuosl.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=me.ratnesh682@gmail.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).