From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
jassisinghbrar@gmail.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, geert@linux-m68k.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-riscv@lists.infradead.org,
krzysztof.kozlowski@canonical.com, bin.meng@windriver.com,
heiko@sntech.de, lewis.hanly@microchip.com,
daire.mcnamara@microchip.com, ivan.griffin@microchip.com,
atishp@rivosinc.com
Subject: Re: [PATCH v5 04/12] dt-bindings: rtc: add bindings for microchip mpfs rtc
Date: Fri, 4 Feb 2022 16:46:43 -0600 [thread overview]
Message-ID: <Yf2s0w4Yi6rcxukj@robh.at.kernel.org> (raw)
In-Reply-To: <20220131114726.973690-5-conor.dooley@microchip.com>
On Mon, Jan 31, 2022 at 11:47:19AM +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Add device tree bindings for the real time clock on
> the Microchip PolarFire SoC.
>
> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../bindings/rtc/microchip,mfps-rtc.yaml | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> new file mode 100644
> index 000000000000..f35cca4e8656
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/microchip,mfps-rtc.yaml#
> +
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip PolarFire Soc (MPFS) RTC Device Tree Bindings
> +
> +allOf:
> + - $ref: rtc.yaml#
> +
> +maintainers:
> + - Daire McNamara <daire.mcnamara@microchip.com>
> + - Lewis Hanly <lewis.hanly@microchip.com>
> +
> +properties:
> + compatible:
> + enum:
> + - microchip,mpfs-rtc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: |
> + The RTC on the PolarFire SoC has a pair of interrupts. The first is the
> + RTC_WAKEUP interrupt. The second, RTC_MATCH, is asserted when the
> + content of the Alarm register is equal to that of the RTC's count.
> + maxItems: 2
Rework something like this:
items:
- description: RTC_WAKEUP interrupt
- description: RTC_MATCH, is asserted when the content of the Alarm
register is equal to that of the RTC's count.
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: rtc
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/microchip,mpfs-clock.h>
> + rtc@20124000 {
> + compatible = "microchip,mpfs-rtc";
> + reg = <0x20124000 0x1000>;
> + clocks = <&clkcfg CLK_RTC>;
> + clock-names = "rtc";
> + interrupts = <80>, <81>;
> + };
> +...
> --
> 2.35.0
>
>
next prev parent reply other threads:[~2022-02-04 22:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 11:47 [PATCH v5 00/12] Update the Icicle Kit device tree conor.dooley
2022-01-31 11:47 ` [PATCH v5 01/12] dt-bindings: soc/microchip: update syscontroller compatibles conor.dooley
2022-02-04 22:39 ` Rob Herring
2022-01-31 11:47 ` [PATCH v5 02/12] dt-bindings: soc/microchip: add services as children of sys ctrlr conor.dooley
2022-02-04 22:42 ` Rob Herring
2022-01-31 11:47 ` [PATCH v5 03/12] dt-bindings: i2c: add bindings for microchip mpfs i2c conor.dooley
2022-01-31 13:37 ` Rob Herring
2022-01-31 15:39 ` Rob Herring
2022-01-31 15:55 ` Conor.Dooley
2022-02-04 22:45 ` Rob Herring
2022-02-05 11:53 ` Conor Dooley
2022-01-31 11:47 ` [PATCH v5 04/12] dt-bindings: rtc: add bindings for microchip mpfs rtc conor.dooley
2022-01-31 13:37 ` Rob Herring
2022-02-04 22:46 ` Rob Herring [this message]
2022-01-31 11:47 ` [PATCH v5 05/12] dt-bindings: gpio: add bindings for microchip mpfs gpio conor.dooley
2022-01-31 13:37 ` Rob Herring
2022-01-31 11:47 ` [PATCH v5 06/12] dt-bindings: pwm: add microchip corepwm binding conor.dooley
2022-01-31 13:37 ` Rob Herring
2022-02-01 7:58 ` Uwe Kleine-König
2022-02-02 12:35 ` conor.dooley
2022-02-02 13:28 ` Geert Uytterhoeven
2022-02-02 13:46 ` Conor.Dooley
2022-02-02 14:02 ` Geert Uytterhoeven
2022-02-02 14:37 ` Conor.Dooley
2022-02-05 12:48 ` Conor Dooley
2022-01-31 11:47 ` [PATCH v5 07/12] riscv: dts: microchip: use clk defines for icicle kit conor.dooley
2022-01-31 11:47 ` [PATCH v5 08/12] riscv: dts: microchip: add fpga fabric section to " conor.dooley
2022-01-31 11:47 ` [PATCH v5 09/12] riscv: dts: microchip: refactor icicle kit device tree conor.dooley
2022-01-31 11:47 ` [PATCH v5 10/12] riscv: dts: microchip: update peripherals in " conor.dooley
2022-01-31 11:47 ` [PATCH v5 11/12] riscv: dts: microchip: add new peripherals to " conor.dooley
2022-01-31 11:47 ` [PATCH v5 12/12] MAINTAINERS: update riscv/microchip entry conor.dooley
2022-02-04 18:09 ` [PATCH v5 00/12] Update the Icicle Kit device tree Palmer Dabbelt
2022-02-04 18:47 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf2s0w4Yi6rcxukj@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=bin.meng@windriver.com \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=heiko@sntech.de \
--cc=ivan.griffin@microchip.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lewis.hanly@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).