PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

[Christian Eggers]

SoC: i.MX6ULL

After upgrading from v5.10.65-rt53 to v5.10.73-rt54 I get two additional messages on boot:

...
[    3.786333] alg: skcipher: ecb-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
[    3.789020] alg: skcipher: cbc-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
[    3.793741] mxs-dcp 2280000.crypto: mxs_dcp: initialized
..

After reverting the commit

2e6d793e1bf0 ("crypto: mxs-dcp - Use sg_mapping_iter to copy data")

the error messages above disappear again.

regards
Christian

[3.] Keywords: mxc-dcp, crypto manager self tests
[4.] Kernel information
[4.1.] Kernel version (from /proc/version):
Linux version 5.10.73-rt54+ (eggers@localhost.localdomain) (arm-poky-linux-gnueabi-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.35.1) #19 PREEMPT_RT Thu Jan 27 17:56:20 CET 2022

[4.2.] Kernel .config file:
[5.] Most recent kernel version which did not have the bug: 5.10.65-rt53
[8.] Environment
[8.1.] Software (add the output of the ver_linux script here)
n/a (embedded system, kernel cross compiled)

[8.2.] Processor information (from /proc/cpuinfo):
processor       : 0
model name      : ARMv7 Processor rev 5 (v7l)
BogoMIPS        : 16.00
Features        : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae evtstrm 
CPU implementer : 0x41
CPU architecture: 7
CPU variant     : 0x0
CPU part        : 0xc07
CPU revision    : 5

Hardware        : Freescale i.MX6 Ultralite (Device Tree)
Revision        : 0000
Serial          : 0000000000000000

Re: PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

[Sean Anderson]

Hi Christian,

On 1/27/22 12:23 PM, Christian Eggers wrote:
> SoC: i.MX6ULL
> 
> After upgrading from v5.10.65-rt53 to v5.10.73-rt54 I get two additional messages on boot:
> 
> ...
> [ 3.786333] alg: skcipher: ecb-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> [ 3.789020] alg: skcipher: cbc-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> [ 3.793741] mxs-dcp 2280000.crypto: mxs_dcp: initialized
> ..
> 
> After reverting the commit
> 
> 2e6d793e1bf0 ("crypto: mxs-dcp - Use sg_mapping_iter to copy data")
> 
> the error messages above disappear again.

Can you try applying the patch in [1] on top of your revert?

--Sean

[1] https://lore.kernel.org/linux-arm-kernel/20210701185638.3437487-1-sean.anderson@seco.com/

Re: PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

[Christian Eggers]

Hi Sean,

On Thursday, 27 January 2022, 18:31:48 CET, Sean Anderson wrote:
> Hi Christian,
> 
> On 1/27/22 12:23 PM, Christian Eggers wrote:
> > SoC: i.MX6ULL
> > 
> > After upgrading from v5.10.65-rt53 to v5.10.73-rt54 I get two additional messages on boot:
> > 
> > ...
> > [ 3.786333] alg: skcipher: ecb-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> > [ 3.789020] alg: skcipher: cbc-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> > [ 3.793741] mxs-dcp 2280000.crypto: mxs_dcp: initialized
> > ..
> > 
> > After reverting the commit
> > 
> > 2e6d793e1bf0 ("crypto: mxs-dcp - Use sg_mapping_iter to copy data")
> > 
> > the error messages above disappear again.
> 
> Can you try applying the patch in [1] on top of your revert?
with the patch from [1] on top of the reverted 2e6d793e1bf0 there are
no error messages on boot.

regards
Christian

> 
> [1] https://lore.kernel.org/linux-arm-kernel/20210701185638.3437487-1-sean.anderson@seco.com/
> 

Re: PROBLEM: encryption test failures since "crypto: mxs-dcp - Use sg_mapping_iter to copy data"

[Herbert Xu]

On Thu, Jan 27, 2022 at 12:31:48PM -0500, Sean Anderson wrote:
> Hi Christian,
> 
> On 1/27/22 12:23 PM, Christian Eggers wrote:
> > SoC: i.MX6ULL
> > 
> > After upgrading from v5.10.65-rt53 to v5.10.73-rt54 I get two additional messages on boot:
> > 
> > ...
> > [ 3.786333] alg: skcipher: ecb-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> > [ 3.789020] alg: skcipher: cbc-aes-dcp encryption test failed (wrong result) on test vector 0, cfg="two even aligned splits"
> > [ 3.793741] mxs-dcp 2280000.crypto: mxs_dcp: initialized
> > ..
> > 
> > After reverting the commit
> > 
> > 2e6d793e1bf0 ("crypto: mxs-dcp - Use sg_mapping_iter to copy data")
> > 
> > the error messages above disappear again.
> 
> Can you try applying the patch in [1] on top of your revert?

Please resubmit your patch with a proper Subject, otherwise it'll
be automatically discarded by patchwork.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt