From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: kernel test robot <lkp@intel.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-clk@vger.kernel.org, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>
Subject: Re: [PATCH 1/5] clk: mux: Declare u32 *table parameter as const
Date: Mon, 31 Jan 2022 15:45:49 +0100 [thread overview]
Message-ID: <Yff2HZ0tbO4nkvig@latitude> (raw)
In-Reply-To: <202201311102.kgy44sMD-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Mon, Jan 31, 2022 at 11:44:25AM +0800, kernel test robot wrote:
> Hi "Jonathan,
>
> I love your patch! Perhaps something to improve:
>
[...]
> drivers/clk/nxp/clk-lpc18xx-cgu.c: In function 'lpc18xx_pll1_recalc_rate':
> drivers/clk/nxp/clk-lpc18xx-cgu.c:460:13: warning: variable 'stat' set but not used [-Wunused-but-set-variable]
> 460 | u32 stat, ctrl;
> | ^~~~
This is unrelated to my changes, I'll leave it up to the LPC18xx developers.
> drivers/clk/nxp/clk-lpc18xx-cgu.c: In function 'lpc18xx_cgu_register_div':
> >> drivers/clk/nxp/clk-lpc18xx-cgu.c:545:52: warning: passing argument 2 of 'lpc18xx_fill_parent_names' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 545 | lpc18xx_fill_parent_names(parents, clk->mux.table, clk->n_parents);
> | ~~~~~~~~^~~~~~
I'll fix this for v2.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-31 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 9:51 [PATCH 0/5] clk: Declare mux tables as const u32[] Jonathan Neuschäfer
2022-01-29 9:51 ` [PATCH 1/5] clk: mux: Declare u32 *table parameter as const Jonathan Neuschäfer
2022-01-31 3:44 ` kernel test robot
2022-01-31 14:45 ` Jonathan Neuschäfer [this message]
2022-01-31 4:15 ` kernel test robot
2022-01-29 9:51 ` [PATCH 2/5] clk: hisilicon: Remove unnecessary cast of mux table to u32 * Jonathan Neuschäfer
2022-01-29 9:51 ` [PATCH 3/5] clk: mmp: Declare mux tables as const u32[] Jonathan Neuschäfer
2022-01-29 9:51 ` [PATCH 4/5] clk: qcom: Declare mux table " Jonathan Neuschäfer
2022-01-29 9:51 ` [PATCH 5/5] clk: pistachio: " Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yff2HZ0tbO4nkvig@latitude \
--to=j.neuschaefer@gmx.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).