From: Borislav Petkov <bp@alien8.de>
To: William Roche <william.roche@oracle.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM
Date: Thu, 3 Feb 2022 15:09:32 +0100 [thread overview]
Message-ID: <YfviHFrzzdapbwDt@zn.tnic> (raw)
In-Reply-To: <a42a7696-0150-6d63-953e-adec19e25d02@oracle.com>
On Thu, Feb 03, 2022 at 02:19:19PM +0100, William Roche wrote:
> As we are moving the dram_type cached date from pvt to umc for family >=
> 0x17, should we also add a small comment for the dram_type field in the
> amd64_pvt structure to indicate that ?
Who would be that comment for? People who are looking at the code, so
that they know which is which?
> Something like that for example:
>
> @@ -385,7 +385,7 @@
> /* place to store error injection parameters prior to issue */
> struct error_injection injection;
>
> - /* cache the dram_type */
> + /* cache the dram_type for family<0x17 */
> enum mem_type dram_type;
>
> struct amd64_umc *umc; /* UMC registers */
>
>
> Just a suggestion.
> The code looks good to me.
>
> Reviewed-by: William Roche <william.roche@oracle.com>
>
> W.
Btw, I'd appreciate it if you do not top-post.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-02-03 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 14:43 [PATCH v4 0/2] AMD Family 19h Models 10h-1Fh Updates Yazen Ghannam
2022-02-02 14:43 ` [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM Yazen Ghannam
2022-02-03 13:19 ` William Roche
2022-02-03 14:09 ` Borislav Petkov [this message]
2022-02-03 15:46 ` William Roche
2022-02-04 15:51 ` Yazen Ghannam
2022-02-04 17:20 ` William Roche
2022-02-23 20:55 ` Borislav Petkov
2022-02-24 18:18 ` Yazen Ghannam
2022-02-02 14:43 ` [PATCH v4 2/2] EDAC/amd64: Add new register offset support and related changes Yazen Ghannam
2022-02-03 13:19 ` William Roche
2022-03-06 16:18 ` [PATCH v4 0/2] AMD Family 19h Models 10h-1Fh Updates Borislav Petkov
2022-03-09 21:05 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfviHFrzzdapbwDt@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=william.roche@oracle.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).