From: William Roche <william.roche@oracle.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM
Date: Fri, 4 Feb 2022 18:20:56 +0100 [thread overview]
Message-ID: <aa81c069-2471-34bd-b7e1-f06508ae6104@oracle.com> (raw)
In-Reply-To: <Yf1LchOlECslWK2b@yaz-ubuntu>
On 04/02/2022 16:51, Yazen Ghannam wrote:
>
> diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> index 6f8147abfa71..38e5ad95d010 100644
> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -397,7 +397,12 @@ struct amd64_pvt {
> /* place to store error injection parameters prior to issue */
> struct error_injection injection;
>
> - /* cache the dram_type */
> + /*
> + * cache the dram_type
> + *
> + * NOTE: Don't use this for Family 17h and later.
> + * Use dram_type in struct amd64_umc instead.
> + */
> enum mem_type dram_type;
>
> struct amd64_umc *umc; /* UMC registers */
It works for me Yazen.
Thanks!
next prev parent reply other threads:[~2022-02-04 17:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 14:43 [PATCH v4 0/2] AMD Family 19h Models 10h-1Fh Updates Yazen Ghannam
2022-02-02 14:43 ` [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM Yazen Ghannam
2022-02-03 13:19 ` William Roche
2022-02-03 14:09 ` Borislav Petkov
2022-02-03 15:46 ` William Roche
2022-02-04 15:51 ` Yazen Ghannam
2022-02-04 17:20 ` William Roche [this message]
2022-02-23 20:55 ` Borislav Petkov
2022-02-24 18:18 ` Yazen Ghannam
2022-02-02 14:43 ` [PATCH v4 2/2] EDAC/amd64: Add new register offset support and related changes Yazen Ghannam
2022-02-03 13:19 ` William Roche
2022-03-06 16:18 ` [PATCH v4 0/2] AMD Family 19h Models 10h-1Fh Updates Borislav Petkov
2022-03-09 21:05 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa81c069-2471-34bd-b7e1-f06508ae6104@oracle.com \
--to=william.roche@oracle.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).