* [PATCH] perf tools: Replace zero-length array with flexible-array member
@ 2022-02-18 3:13 cgel.zte
2022-02-18 12:58 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-02-18 3:13 UTC (permalink / raw)
To: mingo
Cc: acme, mark.rutland, alexander.shishkin, jolsa, namhyung,
adrian.hunter, atrajeev, ak, kan.liang, deng.changcheng,
german.gomez, linux-perf-users, linux-kernel, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use "flexible array members" for these cases. The older
style of one-element or zero-length arrays should no longer be used.
Reference:
https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
tools/perf/util/event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index cdd72e05fd28..320cbcd5b902 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -308,7 +308,7 @@ struct perf_synth_intel_evt {
};
u32 cfe;
};
- struct perf_synth_intel_evd evd[0];
+ struct perf_synth_intel_evd evd[];
};
struct perf_synth_intel_iflag_chg {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tools: Replace zero-length array with flexible-array member
2022-02-18 3:13 [PATCH] perf tools: Replace zero-length array with flexible-array member cgel.zte
@ 2022-02-18 12:58 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-02-18 12:58 UTC (permalink / raw)
To: cgel.zte
Cc: mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
adrian.hunter, atrajeev, ak, kan.liang, deng.changcheng,
german.gomez, linux-perf-users, linux-kernel, Zeal Robot
Em Fri, Feb 18, 2022 at 03:13:52AM +0000, cgel.zte@gmail.com escreveu:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use "flexible array members" for these cases. The older
> style of one-element or zero-length arrays should no longer be used.
> Reference:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
You can't do that as this will break the build as explained in that
patch e-mail thread.
Adrian provided an alternative patch that I have to process.
Thanks for the patch anyway,
- Arnaldo
> ---
> tools/perf/util/event.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
> index cdd72e05fd28..320cbcd5b902 100644
> --- a/tools/perf/util/event.h
> +++ b/tools/perf/util/event.h
> @@ -308,7 +308,7 @@ struct perf_synth_intel_evt {
> };
> u32 cfe;
> };
> - struct perf_synth_intel_evd evd[0];
> + struct perf_synth_intel_evd evd[];
> };
>
> struct perf_synth_intel_iflag_chg {
> --
> 2.25.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 3:13 [PATCH] perf tools: Replace zero-length array with flexible-array member cgel.zte
2022-02-18 12:58 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).