[hnaz-mm:master 237/343] arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align'

[hnaz-mm:master 237/343] arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align'

[kernel test robot]

tree:   https://github.com/hnaz/linux-mm master
head:   8857950589bc3b4920d69c3e0b2c06d33f445d21
commit: 236e08e72c118cbb20e780cc853378e2c341825c [237/343] mm: don't include <linux/memremap.h> in <linux/mm.h>
config: powerpc64-randconfig-m031-20220217 (https://download.01.org/0day-ci/archive/20220217/202202172347.lJ6oYVOE-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/hnaz/linux-mm/commit/236e08e72c118cbb20e780cc853378e2c341825c
        git remote add hnaz-mm https://github.com/hnaz/linux-mm
        git fetch --no-tags hnaz-mm master
        git checkout 236e08e72c118cbb20e780cc853378e2c341825c
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/book3s64/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align' [-Wmissing-prototypes]
     540 | unsigned long memremap_compat_align(void)
         |               ^~~~~~~~~~~~~~~~~~~~~


vim +/memremap_compat_align +540 arch/powerpc/mm/book3s64/pgtable.c

20626177c9de72 Nicholas Piggin 2021-12-02  531  
387e220a2e5e63 Nicholas Piggin 2021-12-02  532  #if defined(CONFIG_ZONE_DEVICE) && defined(CONFIG_ARCH_HAS_MEMREMAP_COMPAT_ALIGN)
20626177c9de72 Nicholas Piggin 2021-12-02  533  /*
20626177c9de72 Nicholas Piggin 2021-12-02  534   * Override the generic version in mm/memremap.c.
20626177c9de72 Nicholas Piggin 2021-12-02  535   *
20626177c9de72 Nicholas Piggin 2021-12-02  536   * With hash translation, the direct-map range is mapped with just one
20626177c9de72 Nicholas Piggin 2021-12-02  537   * page size selected by htab_init_page_sizes(). Consult
20626177c9de72 Nicholas Piggin 2021-12-02  538   * mmu_psize_defs[] to determine the minimum page size alignment.
20626177c9de72 Nicholas Piggin 2021-12-02  539  */
20626177c9de72 Nicholas Piggin 2021-12-02 @540  unsigned long memremap_compat_align(void)

:::::: The code at line 540 was first introduced by commit
:::::: 20626177c9de726c48802c15e8635cc154645588 powerpc: make memremap_compat_align 64s-only

:::::: TO: Nicholas Piggin <npiggin@gmail.com>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [hnaz-mm:master 237/343] arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align'

[Andrew Morton]

On Fri, 18 Feb 2022 03:46:17 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://github.com/hnaz/linux-mm master
> head:   8857950589bc3b4920d69c3e0b2c06d33f445d21
> commit: 236e08e72c118cbb20e780cc853378e2c341825c [237/343] mm: don't include <linux/memremap.h> in <linux/mm.h>
> config: powerpc64-randconfig-m031-20220217 (https://download.01.org/0day-ci/archive/20220217/202202172347.lJ6oYVOE-lkp@intel.com/config)
> compiler: powerpc64le-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/hnaz/linux-mm/commit/236e08e72c118cbb20e780cc853378e2c341825c
>         git remote add hnaz-mm https://github.com/hnaz/linux-mm
>         git fetch --no-tags hnaz-mm master
>         git checkout 236e08e72c118cbb20e780cc853378e2c341825c
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/book3s64/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align' [-Wmissing-prototypes]
>      540 | unsigned long memremap_compat_align(void)
>          |               ^~~~~~~~~~~~~~~~~~~~~

Thanks, I did this.

--- a/arch/powerpc/mm/book3s64/pgtable.c~mm-dont-include-linux-memremaph-in-linux-mmh-fix-2-fix
+++ a/arch/powerpc/mm/book3s64/pgtable.c
@@ -6,6 +6,7 @@
 #include <linux/sched.h>
 #include <linux/mm_types.h>
 #include <linux/memblock.h>
+#include <linux/memremap.h>
 #include <linux/debugfs.h>
 #include <misc/cxl-base.h>
 
_

Re: [hnaz-mm:master 237/343] arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align'

[Matthew Wilcox]

On Thu, Feb 17, 2022 at 12:55:53PM -0800, Andrew Morton wrote:
> On Fri, 18 Feb 2022 03:46:17 +0800 kernel test robot <lkp@intel.com> wrote:
> > >> arch/powerpc/mm/book3s64/pgtable.c:540:15: warning: no previous prototype for 'memremap_compat_align' [-Wmissing-prototypes]
> >      540 | unsigned long memremap_compat_align(void)
> >          |               ^~~~~~~~~~~~~~~~~~~~~
> 
> Thanks, I did this.

I guess this is now my responsibility?  Folded that fix in and pushed
out 8cbcadaf5aef to infradead/for-next

> --- a/arch/powerpc/mm/book3s64/pgtable.c~mm-dont-include-linux-memremaph-in-linux-mmh-fix-2-fix
> +++ a/arch/powerpc/mm/book3s64/pgtable.c
> @@ -6,6 +6,7 @@
>  #include <linux/sched.h>
>  #include <linux/mm_types.h>
>  #include <linux/memblock.h>
> +#include <linux/memremap.h>
>  #include <linux/debugfs.h>
>  #include <misc/cxl-base.h>
>  
> _
> 
> 
>