* [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT
@ 2022-02-14 8:36 Krzysztof Kozlowski
2022-02-14 11:19 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-14 8:36 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar, Shuah Khan, Krzysztof Kozlowski,
linux-kselftest, linux-kernel, linux-rt-users, joseph.salisbury
Cc: Sebastian Andrzej Siewior, Shuah Khan
The PREEMPT_RT patchset does not use do_softirq() function thus trying
to filter for do_softirq fails for such kernel:
echo do_softirq
ftracetest: 81: echo: echo: I/O error
Choose some other visible function for the test. The function does not
have to be actually executed during the test, because it is only testing
filter API interface.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
Changes since v2:
1. Rephrase commit msg, after comments from Sebastian.
2. Add review tag.
Changes since v1:
1. Use scheduler_tick.
2. Add review tag.
Notes:
I understand that the failure does not exist on mainline kernel (only
with PREEMPT_RT patchset) but the change does not harm it.
If it is not suitable alone, please consider it for RT patchset.
---
.../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
index e96e279e0533..25432b8cd5bd 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
@@ -19,7 +19,7 @@ fail() { # mesg
FILTER=set_ftrace_filter
FUNC1="schedule"
-FUNC2="do_softirq"
+FUNC2="scheduler_tick"
ALL_FUNCS="#### all functions enabled ####"
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT
2022-02-14 8:36 [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT Krzysztof Kozlowski
@ 2022-02-14 11:19 ` Sebastian Andrzej Siewior
2022-02-14 18:33 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2022-02-14 11:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Steven Rostedt, Ingo Molnar, Shuah Khan, linux-kselftest,
linux-kernel, linux-rt-users, joseph.salisbury, Shuah Khan
On 2022-02-14 09:36:57 [+0100], Krzysztof Kozlowski wrote:
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
>
> echo do_softirq
> ftracetest: 81: echo: echo: I/O error
>
> Choose some other visible function for the test. The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Notes:
> I understand that the failure does not exist on mainline kernel (only
> with PREEMPT_RT patchset) but the change does not harm it.
Yes, and now it does not sound (to me) like duct tape. Thank you.
> If it is not suitable alone, please consider it for RT patchset.
We trying to get it merged so…
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT
2022-02-14 11:19 ` Sebastian Andrzej Siewior
@ 2022-02-14 18:33 ` Shuah Khan
2022-02-14 18:39 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2022-02-14 18:33 UTC (permalink / raw)
To: Steven Rostedt
Cc: Ingo Molnar, Shuah Khan, linux-kselftest, linux-kernel,
linux-rt-users, joseph.salisbury, Sebastian Andrzej Siewior,
Krzysztof Kozlowski, Shuah Khan
On 2/14/22 4:19 AM, Sebastian Andrzej Siewior wrote:
> On 2022-02-14 09:36:57 [+0100], Krzysztof Kozlowski wrote:
>> The PREEMPT_RT patchset does not use do_softirq() function thus trying
>> to filter for do_softirq fails for such kernel:
>>
>> echo do_softirq
>> ftracetest: 81: echo: echo: I/O error
>>
>> Choose some other visible function for the test. The function does not
>> have to be actually executed during the test, because it is only testing
>> filter API interface.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
>> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
>> Notes:
>> I understand that the failure does not exist on mainline kernel (only
>> with PREEMPT_RT patchset) but the change does not harm it.
>
Steve,
Would you like me to take this through linux-kselftest next for 5.18-rc1
I am guessing there is no urgency on this - of not I can take this in for
rc5.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT
2022-02-14 18:33 ` Shuah Khan
@ 2022-02-14 18:39 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2022-02-14 18:39 UTC (permalink / raw)
To: Shuah Khan
Cc: Ingo Molnar, Shuah Khan, linux-kselftest, linux-kernel,
linux-rt-users, joseph.salisbury, Sebastian Andrzej Siewior,
Krzysztof Kozlowski
On Mon, 14 Feb 2022 11:33:18 -0700
Shuah Khan <skhan@linuxfoundation.org> wrote:
> Steve,
>
> Would you like me to take this through linux-kselftest next for 5.18-rc1
>
> I am guessing there is no urgency on this - of not I can take this in for
> rc5.
Hi Shuah,
Feel free to take it through your tree in any urgent level you like.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-14 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 8:36 [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT Krzysztof Kozlowski
2022-02-14 11:19 ` Sebastian Andrzej Siewior
2022-02-14 18:33 ` Shuah Khan
2022-02-14 18:39 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).