* [PATCH v2] mfd: stmfx: Improve error message triggered by regulator fault in .remove()
@ 2022-02-14 15:07 Uwe Kleine-König
2022-02-14 15:12 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2022-02-14 15:07 UTC (permalink / raw)
To: Lee Jones, Maxime Coquelin, Alexandre Torgue
Cc: kernel, linux-stm32, linux-arm-kernel, linux-kernel
Returning a non-zero value in an i2c remove callback results in the i2c
core emitting a very generic error message ("remove failed (-ESOMETHING),
will be ignored") and as the message indicates not further error handling
is done.
Instead emit a more specific error message and then return zero in
.remove().
The long-term goal is to make the i2c remove prototype return void, making
all implementations return 0 is preparatory work for this change.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Changes since (implicit) v1:
- put declaration of ret and assignment in two lines.
(requested by Lee Jones)
drivers/mfd/stmfx.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c
index e095a3930142..122f96094410 100644
--- a/drivers/mfd/stmfx.c
+++ b/drivers/mfd/stmfx.c
@@ -392,17 +392,22 @@ static int stmfx_chip_init(struct i2c_client *client)
return ret;
}
-static int stmfx_chip_exit(struct i2c_client *client)
+static void stmfx_chip_exit(struct i2c_client *client)
{
struct stmfx *stmfx = i2c_get_clientdata(client);
regmap_write(stmfx->map, STMFX_REG_IRQ_SRC_EN, 0);
regmap_write(stmfx->map, STMFX_REG_SYS_CTRL, 0);
- if (stmfx->vdd)
- return regulator_disable(stmfx->vdd);
+ if (stmfx->vdd) {
+ int ret;
+ ret = regulator_disable(stmfx->vdd);
+ if (ret)
+ dev_err(&client->dev,
+ "Failed to disable vdd regulator: %pe\n",
+ ERR_PTR(ret));
+ }
- return 0;
}
static int stmfx_probe(struct i2c_client *client,
@@ -466,7 +471,9 @@ static int stmfx_remove(struct i2c_client *client)
{
stmfx_irq_exit(client);
- return stmfx_chip_exit(client);
+ stmfx_chip_exit(client);
+
+ return 0;
}
#ifdef CONFIG_PM_SLEEP
base-commit: dcb85f85fa6f142aae1fe86f399d4503d49f2b60
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mfd: stmfx: Improve error message triggered by regulator fault in .remove()
2022-02-14 15:07 [PATCH v2] mfd: stmfx: Improve error message triggered by regulator fault in .remove() Uwe Kleine-König
@ 2022-02-14 15:12 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2022-02-14 15:12 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Maxime Coquelin, Alexandre Torgue, kernel, linux-stm32,
linux-arm-kernel, linux-kernel
On Mon, 14 Feb 2022, Uwe Kleine-König wrote:
> Returning a non-zero value in an i2c remove callback results in the i2c
> core emitting a very generic error message ("remove failed (-ESOMETHING),
> will be ignored") and as the message indicates not further error handling
> is done.
>
> Instead emit a more specific error message and then return zero in
> .remove().
>
> The long-term goal is to make the i2c remove prototype return void, making
> all implementations return 0 is preparatory work for this change.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since (implicit) v1:
>
> - put declaration of ret and assignment in two lines.
> (requested by Lee Jones)
>
> drivers/mfd/stmfx.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 15:07 [PATCH v2] mfd: stmfx: Improve error message triggered by regulator fault in .remove() Uwe Kleine-König
2022-02-14 15:12 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).