* kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'?
@ 2022-02-13 16:57 kernel test robot
2022-02-14 0:34 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2022-02-13 16:57 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: kbuild-all, linux-kernel, Luis Chamberlain
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
commit: b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7 module: add in-kernel support for decompressing
date: 5 weeks ago
config: sparc-randconfig-r005-20220213 (https://download.01.org/0day-ci/archive/20220214/202202140027.K0xZn3T2-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/module_decompress.c: In function 'module_decompress_sysfs_init':
>> kernel/module_decompress.c:264:36: error: 'module_kset' undeclared (first use in this function); did you mean 'module_use'?
264 | error = sysfs_create_file(&module_kset->kobj,
| ^~~~~~~~~~~
| module_use
kernel/module_decompress.c:264:36: note: each undeclared identifier is reported only once for each function it appears in
vim +264 kernel/module_decompress.c
259
260 static int __init module_decompress_sysfs_init(void)
261 {
262 int error;
263
> 264 error = sysfs_create_file(&module_kset->kobj,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'?
2022-02-13 16:57 kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'? kernel test robot
@ 2022-02-14 0:34 ` Randy Dunlap
2022-02-14 2:55 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2022-02-14 0:34 UTC (permalink / raw)
To: kernel test robot, Dmitry Torokhov
Cc: kbuild-all, linux-kernel, Luis Chamberlain
On 2/13/22 08:57, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
> commit: b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7 module: add in-kernel support for decompressing
> date: 5 weeks ago
> config: sparc-randconfig-r005-20220213 (https://download.01.org/0day-ci/archive/20220214/202202140027.K0xZn3T2-lkp@intel.com/config)
> compiler: sparc-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash
FTR/FYI:
# CONFIG_SYSFS is not set
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> kernel/module_decompress.c: In function 'module_decompress_sysfs_init':
>>> kernel/module_decompress.c:264:36: error: 'module_kset' undeclared (first use in this function); did you mean 'module_use'?
> 264 | error = sysfs_create_file(&module_kset->kobj,
> | ^~~~~~~~~~~
> | module_use
> kernel/module_decompress.c:264:36: note: each undeclared identifier is reported only once for each function it appears in
>
>
> vim +264 kernel/module_decompress.c
>
> 259
> 260 static int __init module_decompress_sysfs_init(void)
> 261 {
> 262 int error;
> 263
> > 264 error = sysfs_create_file(&module_kset->kobj,
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'?
2022-02-14 0:34 ` Randy Dunlap
@ 2022-02-14 2:55 ` Dmitry Torokhov
2022-02-15 7:36 ` Luis Chamberlain
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2022-02-14 2:55 UTC (permalink / raw)
To: Randy Dunlap
Cc: kernel test robot, kbuild-all, linux-kernel, Luis Chamberlain
On Sun, Feb 13, 2022 at 04:34:49PM -0800, Randy Dunlap wrote:
>
>
> On 2/13/22 08:57, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
> > commit: b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7 module: add in-kernel support for decompressing
> > date: 5 weeks ago
> > config: sparc-randconfig-r005-20220213 (https://download.01.org/0day-ci/archive/20220214/202202140027.K0xZn3T2-lkp@intel.com/config)
> > compiler: sparc-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash
>
> FTR/FYI:
> # CONFIG_SYSFS is not set
Ugh, why is this even a thing?
>
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > kernel/module_decompress.c: In function 'module_decompress_sysfs_init':
> >>> kernel/module_decompress.c:264:36: error: 'module_kset' undeclared (first use in this function); did you mean 'module_use'?
> > 264 | error = sysfs_create_file(&module_kset->kobj,
> > | ^~~~~~~~~~~
> > | module_use
> > kernel/module_decompress.c:264:36: note: each undeclared identifier is reported only once for each function it appears in
> >
> >
> > vim +264 kernel/module_decompress.c
> >
> > 259
> > 260 static int __init module_decompress_sysfs_init(void)
> > 261 {
> > 262 int error;
> > 263
> > > 264 error = sysfs_create_file(&module_kset->kobj,
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> --
> ~Randy
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'?
2022-02-14 2:55 ` Dmitry Torokhov
@ 2022-02-15 7:36 ` Luis Chamberlain
2022-02-15 21:06 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Luis Chamberlain @ 2022-02-15 7:36 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Randy Dunlap, kernel test robot, kbuild-all, linux-kernel
On Sun, Feb 13, 2022 at 06:55:45PM -0800, Dmitry Torokhov wrote:
> On Sun, Feb 13, 2022 at 04:34:49PM -0800, Randy Dunlap wrote:
> >
> >
> > On 2/13/22 08:57, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
> > > commit: b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7 module: add in-kernel support for decompressing
> > > date: 5 weeks ago
> > > config: sparc-randconfig-r005-20220213 (https://download.01.org/0day-ci/archive/20220214/202202140027.K0xZn3T2-lkp@intel.com/config)
> > > compiler: sparc-linux-gcc (GCC) 11.2.0
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > git fetch --no-tags linus master
> > > git checkout b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> > > # save the config file to linux build tree
> > > mkdir build_dir
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash
> >
> > FTR/FYI:
> > # CONFIG_SYSFS is not set
>
> Ugh, why is this even a thing?
If the kconfig supports it we need to support it. If you think
we need to remove the option to be built-in we can take that
up separately. In the meantime it would be wonderful if you
can address this issue for Linus' tree.
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'?
2022-02-15 7:36 ` Luis Chamberlain
@ 2022-02-15 21:06 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2022-02-15 21:06 UTC (permalink / raw)
To: Luis Chamberlain
Cc: Randy Dunlap, kernel test robot, kbuild-all, linux-kernel
On Mon, Feb 14, 2022 at 11:36:20PM -0800, Luis Chamberlain wrote:
> On Sun, Feb 13, 2022 at 06:55:45PM -0800, Dmitry Torokhov wrote:
> > On Sun, Feb 13, 2022 at 04:34:49PM -0800, Randy Dunlap wrote:
> > >
> > >
> > > On 2/13/22 08:57, kernel test robot wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > > head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
> > > > commit: b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7 module: add in-kernel support for decompressing
> > > > date: 5 weeks ago
> > > > config: sparc-randconfig-r005-20220213 (https://download.01.org/0day-ci/archive/20220214/202202140027.K0xZn3T2-lkp@intel.com/config)
> > > > compiler: sparc-linux-gcc (GCC) 11.2.0
> > > > reproduce (this is a W=1 build):
> > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > chmod +x ~/bin/make.cross
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> > > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > > git fetch --no-tags linus master
> > > > git checkout b1ae6dc41eaaa98bb75671e0f3665bfda248c3e7
> > > > # save the config file to linux build tree
> > > > mkdir build_dir
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash
> > >
> > > FTR/FYI:
> > > # CONFIG_SYSFS is not set
> >
> > Ugh, why is this even a thing?
>
> If the kconfig supports it we need to support it. If you think
> we need to remove the option to be built-in we can take that
> up separately. In the meantime it would be wonderful if you
> can address this issue for Linus' tree.
Yes, of course, I was just wondering why we still have option to disable
sysfs. I guess some very purpose-built embedded systems might still
function without it...
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-15 21:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 16:57 kernel/module_decompress.c:264:36: error: 'module_kset' undeclared; did you mean 'module_use'? kernel test robot
2022-02-14 0:34 ` Randy Dunlap
2022-02-14 2:55 ` Dmitry Torokhov
2022-02-15 7:36 ` Luis Chamberlain
2022-02-15 21:06 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).