* [PATCH net-next] net: marvell: prestera: Fix includes
@ 2022-02-14 1:12 Yevhen Orlov
2022-02-15 5:17 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Yevhen Orlov @ 2022-02-14 1:12 UTC (permalink / raw)
To: netdev
Cc: Volodymyr Mytnyk, Taras Chornyi, Mickey Rachamim, Serhiy Pshyk,
Yevhen Orlov, Taras Chornyi, David S. Miller, Jakub Kicinski,
Vadym Kochan, Andrii Savka, Serhiy Boiko, linux-kernel
Include prestera.h in prestera_hw.h, because it may contain common
definitions.
Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
drivers/net/ethernet/marvell/prestera/prestera_hw.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_hw.h b/drivers/net/ethernet/marvell/prestera/prestera_hw.h
index 3ff12bae5909..24f2cf1c875f 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_hw.h
+++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.h
@@ -5,6 +5,7 @@
#define _PRESTERA_HW_H_
#include <linux/types.h>
+#include "prestera.h"
#include "prestera_acl.h"
enum prestera_accept_frm_type {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: marvell: prestera: Fix includes
2022-02-14 1:12 [PATCH net-next] net: marvell: prestera: Fix includes Yevhen Orlov
@ 2022-02-15 5:17 ` Jakub Kicinski
2022-02-15 21:25 ` Yevhen Orlov
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2022-02-15 5:17 UTC (permalink / raw)
To: Yevhen Orlov
Cc: netdev, Volodymyr Mytnyk, Taras Chornyi, Mickey Rachamim,
Serhiy Pshyk, Taras Chornyi, David S. Miller, Vadym Kochan,
Andrii Savka, Serhiy Boiko, linux-kernel
On Mon, 14 Feb 2022 03:12:28 +0200 Yevhen Orlov wrote:
> Include prestera.h in prestera_hw.h, because it may contain common
> definitions.
*May*? Is prestera_hw.h using definitions from prestera.h today?
Dependencies between header files are best avoided completely.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: marvell: prestera: Fix includes
2022-02-15 5:17 ` Jakub Kicinski
@ 2022-02-15 21:25 ` Yevhen Orlov
0 siblings, 0 replies; 3+ messages in thread
From: Yevhen Orlov @ 2022-02-15 21:25 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev, Volodymyr Mytnyk, Taras Chornyi, Mickey Rachamim,
Serhiy Pshyk, Taras Chornyi, David S. Miller, Vadym Kochan,
Andrii Savka, Serhiy Boiko, linux-kernel
On Mon, Feb 14, 2022 at 09:17:43PM -0800, Jakub Kicinski wrote:
> *May*? Is prestera_hw.h using definitions from prestera.h today?
> Dependencies between header files are best avoided completely.
Make sense. Thank you for review.
I will try to avoid such dependencies in the future.
This patch could be abandoned.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-15 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 1:12 [PATCH net-next] net: marvell: prestera: Fix includes Yevhen Orlov
2022-02-15 5:17 ` Jakub Kicinski
2022-02-15 21:25 ` Yevhen Orlov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).