linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC
@ 2022-03-01 12:50 Lad Prabhakar
  2022-03-01 16:32 ` Wolfram Sang
  2022-03-02 18:24 ` Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Lad Prabhakar @ 2022-03-01 12:50 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-renesas-soc, devicetree, Chris Brandt,
	Rob Herring, Krzysztof Kozlowski, Wolfram Sang
  Cc: Lad Prabhakar, linux-kernel, Prabhakar, Biju Das, linux-i2c

Document RZ/V2L I2C bindings. RZ/V2L I2C is identical to one found on the
RZ/G2L and RZ/A SoC's. No driver changes are required as the generic
compatible string "renesas,riic-rz" will be used as a fallback.

While at it, drop the comment "# RZ/A or RZ/G2L" for "renesas,riic-rz"
compatible string as this will avoid changing the line for every new
SoC addition.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v1->v2
* Included Ack and RB tags
* Dropped the comment from generic string as suggested by Geert.

v1:
https://patchwork.kernel.org/project/linux-renesas-soc/patch/
20220227214747.24819-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index 402fd125e010..26d523f3f420 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -20,7 +20,8 @@ properties:
           - renesas,riic-r7s72100   # RZ/A1H
           - renesas,riic-r7s9210    # RZ/A2M
           - renesas,riic-r9a07g044  # RZ/G2{L,LC}
-      - const: renesas,riic-rz      # RZ/A or RZ/G2L
+          - renesas,riic-r9a07g054  # RZ/V2L
+      - const: renesas,riic-rz
 
   reg:
     maxItems: 1
@@ -75,6 +76,7 @@ if:
       contains:
         enum:
           - renesas,riic-r9a07g044
+          - renesas,riic-r9a07g054
 then:
   required:
     - resets
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC
  2022-03-01 12:50 [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC Lad Prabhakar
@ 2022-03-01 16:32 ` Wolfram Sang
  2022-03-02 18:24 ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-03-01 16:32 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Geert Uytterhoeven, linux-renesas-soc, devicetree, Chris Brandt,
	Rob Herring, Krzysztof Kozlowski, linux-kernel, Prabhakar,
	Biju Das, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

On Tue, Mar 01, 2022 at 12:50:46PM +0000, Lad Prabhakar wrote:
> Document RZ/V2L I2C bindings. RZ/V2L I2C is identical to one found on the
> RZ/G2L and RZ/A SoC's. No driver changes are required as the generic
> compatible string "renesas,riic-rz" will be used as a fallback.
> 
> While at it, drop the comment "# RZ/A or RZ/G2L" for "renesas,riic-rz"
> compatible string as this will avoid changing the line for every new
> SoC addition.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

If Rob wants to pick it up:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC
  2022-03-01 12:50 [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC Lad Prabhakar
  2022-03-01 16:32 ` Wolfram Sang
@ 2022-03-02 18:24 ` Rob Herring
  2022-03-02 21:08   ` Wolfram Sang
  1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2022-03-02 18:24 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Geert Uytterhoeven, linux-renesas-soc, devicetree, Chris Brandt,
	Krzysztof Kozlowski, Wolfram Sang, linux-kernel, Prabhakar,
	Biju Das, linux-i2c

On Tue, Mar 01, 2022 at 12:50:46PM +0000, Lad Prabhakar wrote:
> Document RZ/V2L I2C bindings. RZ/V2L I2C is identical to one found on the
> RZ/G2L and RZ/A SoC's. No driver changes are required as the generic
> compatible string "renesas,riic-rz" will be used as a fallback.
> 
> While at it, drop the comment "# RZ/A or RZ/G2L" for "renesas,riic-rz"
> compatible string as this will avoid changing the line for every new
> SoC addition.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1->v2
> * Included Ack and RB tags
> * Dropped the comment from generic string as suggested by Geert.
> 
> v1:
> https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> 20220227214747.24819-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I already applied v1. I may have missed this because PW stopped getting 
mail the last 2 days.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC
  2022-03-02 18:24 ` Rob Herring
@ 2022-03-02 21:08   ` Wolfram Sang
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-03-02 21:08 UTC (permalink / raw)
  To: Rob Herring
  Cc: Lad Prabhakar, Geert Uytterhoeven, linux-renesas-soc, devicetree,
	Chris Brandt, Krzysztof Kozlowski, linux-kernel, Prabhakar,
	Biju Das, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]


> I already applied v1. I may have missed this because PW stopped getting 
> mail the last 2 days.

Can you revert v1 and apply v2? Or I apply v2? Works both for me.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-02 21:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 12:50 [PATCH v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC Lad Prabhakar
2022-03-01 16:32 ` Wolfram Sang
2022-03-02 18:24 ` Rob Herring
2022-03-02 21:08   ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).