* [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue
@ 2022-03-14 11:02 Anders Roxell
2022-03-14 23:51 ` Andrew Lunn
2022-03-15 11:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Anders Roxell @ 2022-03-14 11:02 UTC (permalink / raw)
To: andrew, hkallweit1, davem, kuba
Cc: netdev, linux-kernel, Anders Roxell, kernel test robot
When building driver CONFIG_MICREL_PHY the follow error shows up:
aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_ts_info':
micrel.c:(.text+0x1764): undefined reference to `ptp_clock_index'
micrel.c:(.text+0x1764): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_probe':
micrel.c:(.text+0x4720): undefined reference to `ptp_clock_register'
micrel.c:(.text+0x4720): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
Rework Kconfig for MICREL_PHY to depend on 'PTP_1588_CLOCK_OPTIONAL'.
Arnd describes in a good way why its needed to add this depends in patch
e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies").
Reported-by: kernel test robot <lkp@intel.com>
Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/net/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 902495afcb38..ea7571a2b39b 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -220,6 +220,7 @@ config MEDIATEK_GE_PHY
config MICREL_PHY
tristate "Micrel PHYs"
+ depends on PTP_1588_CLOCK_OPTIONAL
help
Supports the KSZ9021, VSC8201, KS8001 PHYs.
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue
2022-03-14 11:02 [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue Anders Roxell
@ 2022-03-14 23:51 ` Andrew Lunn
2022-03-15 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-03-14 23:51 UTC (permalink / raw)
To: Anders Roxell
Cc: hkallweit1, davem, kuba, netdev, linux-kernel, kernel test robot
On Mon, Mar 14, 2022 at 12:02:54PM +0100, Anders Roxell wrote:
> When building driver CONFIG_MICREL_PHY the follow error shows up:
>
> aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_ts_info':
> micrel.c:(.text+0x1764): undefined reference to `ptp_clock_index'
> micrel.c:(.text+0x1764): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_probe':
> micrel.c:(.text+0x4720): undefined reference to `ptp_clock_register'
> micrel.c:(.text+0x4720): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
>
> Rework Kconfig for MICREL_PHY to depend on 'PTP_1588_CLOCK_OPTIONAL'.
> Arnd describes in a good way why its needed to add this depends in patch
> e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies").
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue
2022-03-14 11:02 [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue Anders Roxell
2022-03-14 23:51 ` Andrew Lunn
@ 2022-03-15 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-15 11:50 UTC (permalink / raw)
To: Anders Roxell; +Cc: andrew, hkallweit1, davem, kuba, netdev, linux-kernel, lkp
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 14 Mar 2022 12:02:54 +0100 you wrote:
> When building driver CONFIG_MICREL_PHY the follow error shows up:
>
> aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_ts_info':
> micrel.c:(.text+0x1764): undefined reference to `ptp_clock_index'
> micrel.c:(.text+0x1764): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_probe':
> micrel.c:(.text+0x4720): undefined reference to `ptp_clock_register'
> micrel.c:(.text+0x4720): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
>
> [...]
Here is the summary with links:
- [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue
https://git.kernel.org/netdev/net-next/c/231fdac3e58f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 11:02 [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue Anders Roxell
2022-03-14 23:51 ` Andrew Lunn
2022-03-15 11:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).