linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sunxi:dts: remove r40 can node
@ 2022-03-03 11:32 fuyao
  2022-03-08 23:44 ` Evgeny Boger
  0 siblings, 1 reply; 4+ messages in thread
From: fuyao @ 2022-03-03 11:32 UTC (permalink / raw)
  To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec,
	devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: 麦健樟

it does not have can in r40/a40i/t3.so delete it.

Signed-off-by: fuyao <fuyao1697@cyg.com>
---
 arch/arm/boot/dts/sun8i-r40.dtsi | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index 03d3e5f45a09..dde803b6ada0 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -936,15 +936,6 @@ i2c3: i2c@1c2b800 {
 			#size-cells = <0>;
 		};
 
-		can0: can@1c2bc00 {
-			compatible = "allwinner,sun8i-r40-can";
-			reg = <0x01c2bc00 0x400>;
-			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&ccu CLK_BUS_CAN>;
-			resets = <&ccu RST_BUS_CAN>;
-			status = "disabled";
-		};
-
 		i2c4: i2c@1c2c000 {
 			compatible = "allwinner,sun6i-a31-i2c";
 			reg = <0x01c2c000 0x400>;
-- 
2.32.0


-- 
Technology is exciting


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] sunxi:dts: remove r40 can node
  2022-03-03 11:32 [PATCH] sunxi:dts: remove r40 can node fuyao
@ 2022-03-08 23:44 ` Evgeny Boger
  2022-03-14  1:58   ` fuyao
  0 siblings, 1 reply; 4+ messages in thread
From: Evgeny Boger @ 2022-03-08 23:44 UTC (permalink / raw)
  To: fuyao1697
  Cc: devicetree, jernej.skrabec, linux-arm-kernel, linux-kernel,
	linux-sunxi, maijianzhang, mripard, robh+dt, wens

Hi,

as I explained in the original commit message, CAN is definitely there 
and is working perfectly at least on A40i.
I know it was removed from the user manual, but I personally verified 
that it is working.

Maybe you can tell why CAN should be removed besides not being described 
in the manual? Are there some hardware or maybe license issues?

Thanks!

--
  Best wishes,
  Evgeny Boger
  CTO @ wirenboard.com






^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] sunxi:dts: remove r40 can node
  2022-03-08 23:44 ` Evgeny Boger
@ 2022-03-14  1:58   ` fuyao
  0 siblings, 0 replies; 4+ messages in thread
From: fuyao @ 2022-03-14  1:58 UTC (permalink / raw)
  To: Evgeny Boger
  Cc: devicetree, jernej.skrabec, linux-arm-kernel, linux-kernel,
	linux-sunxi, maijianzhang, mripard, robh+dt, wens

On Wed, Mar 09, 2022 at 02:44:56AM +0300, Evgeny Boger wrote:
> Hi,
> 
> as I explained in the original commit message, CAN is definitely there and
> is working perfectly at least on A40i.
> I know it was removed from the user manual, but I personally verified that
> it is working.
sorry, I forgot read the commit msg;
> 
> Maybe you can tell why CAN should be removed besides not being described in
> the manual? Are there some hardware or maybe license issues?

i will test it again. 

thanks!

> 
> Thanks!
> 
> --
>  Best wishes,
>  Evgeny Boger
>  CTO @ wirenboard.com
> 
> 
> 
> 

-- 
Technology is exciting


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] sunxi:dts: remove r40 can node
@ 2022-03-03 11:21 fuyao
  0 siblings, 0 replies; 4+ messages in thread
From: fuyao @ 2022-03-03 11:21 UTC (permalink / raw)
  To: Rob, Herring, robh+dt, Maxime, Ripard, mripard, Chen-Yu, Tsai,
	wens, Jernej, Skrabec, jernej.skrabec, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel
  Cc: 麦健樟

it does not have can in r40/a40i/t3.so delete it.

Signed-off-by: fuyao <fuyao1697@cyg.com>
---
 arch/arm/boot/dts/sun8i-r40.dtsi | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index 03d3e5f45a09..dde803b6ada0 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -936,15 +936,6 @@ i2c3: i2c@1c2b800 {
 			#size-cells = <0>;
 		};
 
-		can0: can@1c2bc00 {
-			compatible = "allwinner,sun8i-r40-can";
-			reg = <0x01c2bc00 0x400>;
-			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&ccu CLK_BUS_CAN>;
-			resets = <&ccu RST_BUS_CAN>;
-			status = "disabled";
-		};
-
 		i2c4: i2c@1c2c000 {
 			compatible = "allwinner,sun6i-a31-i2c";
 			reg = <0x01c2c000 0x400>;
-- 
2.32.0


-- 
Technology is exciting


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-14  2:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 11:32 [PATCH] sunxi:dts: remove r40 can node fuyao
2022-03-08 23:44 ` Evgeny Boger
2022-03-14  1:58   ` fuyao
  -- strict thread matches above, loose matches on Subject: below --
2022-03-03 11:21 fuyao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).