From: Wolfram Sang <wsa@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Michael Walle <michael@walle.cc>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
stable@vger.kernel.org
Subject: Re: [PATCH] i2c: at91: use dma safe buffers
Date: Fri, 4 Mar 2022 09:04:50 +0100 [thread overview]
Message-ID: <YiHIIjSs03gDJmHV@shikoro> (raw)
In-Reply-To: <fff424e7-247c-38d8-4151-8b0503a16a7d@amd.com>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hi Christian,
> Maybe call your variable differently. DMA-buf is an inter driver buffer
> sharing frame we use for GPU acceleration and V4L.
>
> It doesn't cause any technical issues, but the maintainer regex now triggers
> on that. So you are CCing people not related to this code in any way.
Frankly, I think the 'dma_buf' regex is a bit too generic. 'dma_buf'
seems like a reasonable name to me if some subsystem has to deal with
different buffers which can be DMA or non-DMA, like I2C. If you git-grep
the tree, you will find it in quite some places.
We could now think of renaming the variable to 'dmabuf' but this is
a strange and kind of arbitrary rule to remember IMO.
I wonder if you'd miss a lot of patches if we remove 'dma_buf' from the
regex and keep 'dma_fence' and 'dma_resv'? Or extend it to 'dma_buf_' or
'struct dma_buf'?
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-04 8:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:17 [PATCH] i2c: at91: use dma safe buffers Michael Walle
2022-03-04 7:35 ` Christian König
2022-03-04 8:04 ` Wolfram Sang [this message]
2022-03-04 8:10 ` Christian König
2022-03-04 8:43 ` Wolfram Sang
2022-03-04 8:54 ` Christian König
2022-03-28 7:35 ` Michael Walle
2022-04-05 9:23 ` Codrin.Ciubotariu
2022-04-05 9:38 ` Michael Walle
2022-04-05 10:02 ` Codrin.Ciubotariu
2022-04-05 11:09 ` Michael Walle
2022-04-05 13:58 ` Codrin.Ciubotariu
2022-04-05 14:08 ` Michael Walle
2022-04-07 11:50 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiHIIjSs03gDJmHV@shikoro \
--to=wsa@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=christian.koenig@amd.com \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=michael@walle.cc \
--cc=nicolas.ferre@microchip.com \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).