From: <Codrin.Ciubotariu@microchip.com>
To: <michael@walle.cc>
Cc: <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Claudiu.Beznea@microchip.com>, <sumit.semwal@linaro.org>,
<christian.koenig@amd.com>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] i2c: at91: use dma safe buffers
Date: Thu, 7 Apr 2022 11:50:31 +0000 [thread overview]
Message-ID: <b80f9ff0-9fc5-7cc5-fb67-1192f3375e7b@microchip.com> (raw)
In-Reply-To: <9e715ed06a28165446e29483cca7e3d0@walle.cc>
On 05.04.2022 17:08, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
>
> Am 2022-04-05 15:58, schrieb Codrin.Ciubotariu@microchip.com:
>> On 05.04.2022 14:09, Michael Walle wrote:
>>> Am 2022-04-05 12:02, schrieb Codrin.Ciubotariu@microchip.com:
>>>> On 05.04.2022 12:38, Michael Walle wrote:
>>>>> Am 2022-04-05 11:23, schrieb Codrin.Ciubotariu@microchip.com:
>>>>>>> + if (dev->use_dma) {
>>>>>>> + dma_buf = i2c_get_dma_safe_msg_buf(m_start, 1);
>>>>>>
>>>>>> If you want, you could just dev->buf = i2c_get_dma_safe...
>>>>>
>>>>> But where is the error handling in that case? dev->buf will
>>>>> be NULL, which is eventually passed to dma_map_single().
>>>>>
>>>>> Also, I need the dma_buf for the i2c_put_dma_safe_msg_buf()
>>>>> call anyway, because dev->buf will be modified during
>>>>> processing.
>>>>
>>>> You still:
>>>> if (!dev->buf) {
>>>> ret = -ENOMEM;
>>>> goto out;
>>>> }
>>>>
>>>> So, at91_do_twi_transfer()/dma_map_single() will not be called.
>>>
>>> Ahh, I misunderstood you. Yes, but as I said, I need the dma_buf
>>> temporary variable anyway, because dev->buf is modified, eg. see
>>> at91_twi_read_data_dma_callback().
>> at91_twi_read_data_dma_callback() is called as callback if
>> dma_async_issue_pending(dma->chan_rx) is called.
>> dma_async_issue_pending(dma->chan_rx) is called on
>> at91_twi_read_data_dma(), which is called in at91_do_twi_transfer(),
>> which we decided above to skip in case of error.
>
> It is not about errors, you need the exact same pointer you
> got from i2c_get_dma_safe_msg_buf() to be passed to
> i2c_put_dma_safe_msg_buf(). And because (in some cases, it
> isn't really obvious) the dev->buf will be advanced a few
> bytes, I cannot pass dev->buf to i2c_put_dma_safe_msg_buf().
You are right, when dev->use_dma && (dev->buf_len <= AT91_I2C_DMA_THRESHOLD)
got it. Thanks!
Best regards,
Codrin
prev parent reply other threads:[~2022-04-07 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:17 [PATCH] i2c: at91: use dma safe buffers Michael Walle
2022-03-04 7:35 ` Christian König
2022-03-04 8:04 ` Wolfram Sang
2022-03-04 8:10 ` Christian König
2022-03-04 8:43 ` Wolfram Sang
2022-03-04 8:54 ` Christian König
2022-03-28 7:35 ` Michael Walle
2022-04-05 9:23 ` Codrin.Ciubotariu
2022-04-05 9:38 ` Michael Walle
2022-04-05 10:02 ` Codrin.Ciubotariu
2022-04-05 11:09 ` Michael Walle
2022-04-05 13:58 ` Codrin.Ciubotariu
2022-04-05 14:08 ` Michael Walle
2022-04-07 11:50 ` Codrin.Ciubotariu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b80f9ff0-9fc5-7cc5-fb67-1192f3375e7b@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=michael@walle.cc \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).