* [PATCH] virtio_ring: Initialize vring_size_in_bytes
@ 2022-03-07 17:49 trix
2022-03-07 17:54 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2022-03-07 17:49 UTC (permalink / raw)
To: mst, jasowang, nathan, ndesaulniers
Cc: virtualization, linux-kernel, llvm, Tom Rix
From: Tom Rix <trix@redhat.com>
On the clang build, there is this error
virtio_ring.c:1772:26: error: variable 'ring_size_in_bytes'
is uninitialized when used here
vring_free_queue(vdev, ring_size_in_bytes,
^~~~~~~~~~~~~~~~~~
ring_dma_addr was intialized twice, once with the ring_size_in_bytes.
value. So fix typo.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/virtio/virtio_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 905c882600618..b2b567ebb9120 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -1756,7 +1756,7 @@ static void vring_free_vring_packed(struct vring_packed *vring,
ring = vring->ring;
driver = vring->driver;
device = vring->device;
- ring_dma_addr = vring->ring_size_in_bytes;
+ ring_size_in_bytes = vring->ring_size_in_bytes;
event_size_in_bytes = vring->event_size_in_bytes;
ring_dma_addr = vring->ring_dma_addr;
driver_event_dma_addr = vring->driver_event_dma_addr;
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_ring: Initialize vring_size_in_bytes
2022-03-07 17:49 [PATCH] virtio_ring: Initialize vring_size_in_bytes trix
@ 2022-03-07 17:54 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2022-03-07 17:54 UTC (permalink / raw)
To: trix; +Cc: mst, jasowang, ndesaulniers, virtualization, linux-kernel, llvm
On Mon, Mar 07, 2022 at 09:49:16AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> On the clang build, there is this error
> virtio_ring.c:1772:26: error: variable 'ring_size_in_bytes'
> is uninitialized when used here
> vring_free_queue(vdev, ring_size_in_bytes,
> ^~~~~~~~~~~~~~~~~~
>
> ring_dma_addr was intialized twice, once with the ring_size_in_bytes.
> value. So fix typo.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
I was getting ready to send the same patch.
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 905c882600618..b2b567ebb9120 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1756,7 +1756,7 @@ static void vring_free_vring_packed(struct vring_packed *vring,
> ring = vring->ring;
> driver = vring->driver;
> device = vring->device;
> - ring_dma_addr = vring->ring_size_in_bytes;
> + ring_size_in_bytes = vring->ring_size_in_bytes;
> event_size_in_bytes = vring->event_size_in_bytes;
> ring_dma_addr = vring->ring_dma_addr;
> driver_event_dma_addr = vring->driver_event_dma_addr;
> --
> 2.26.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-07 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 17:49 [PATCH] virtio_ring: Initialize vring_size_in_bytes trix
2022-03-07 17:54 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).