* [PATCH 0/4] Add Support for MediaTek PMIC MT6366
@ 2022-01-06 6:54 Johnson Wang
2022-01-06 6:54 ` [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC Johnson Wang
` (4 more replies)
0 siblings, 5 replies; 19+ messages in thread
From: Johnson Wang @ 2022-01-06 6:54 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, Johnson Wang
This patchset adds support for MediaTek PMIC MT6366.
MT6366 is the primary PMIC for MT8186 and probably other SOCs.
Johnson Wang (4):
mfd: Add support for the MediaTek MT6366 PMIC
regulator: mt6366: Add support for MT6366 regulator
dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC
dt-bindings: regulator: Add MT6358 regulators
.../devicetree/bindings/mfd/mt6397.txt | 2 +-
.../bindings/regulator/mt6358-regulator.txt | 22 +-
drivers/mfd/mt6358-irq.c | 1 +
drivers/regulator/mt6358-regulator.c | 213 +++++++++++++++++-
include/linux/mfd/mt6358/registers.h | 7 +
include/linux/mfd/mt6397/core.h | 1 +
include/linux/regulator/mt6358-regulator.h | 45 ++++
7 files changed, 280 insertions(+), 11 deletions(-)
--
2.18.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC 2022-01-06 6:54 [PATCH 0/4] Add Support for MediaTek PMIC MT6366 Johnson Wang @ 2022-01-06 6:54 ` Johnson Wang 2022-02-07 7:04 ` Johnson Wang 2022-02-14 13:39 ` Lee Jones 2022-01-06 6:54 ` [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator Johnson Wang ` (3 subsequent siblings) 4 siblings, 2 replies; 19+ messages in thread From: Johnson Wang @ 2022-01-06 6:54 UTC (permalink / raw) To: lee.jones, robh+dt, broonie Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group, Johnson Wang This adds support for the MediaTek MT6366 PMIC. This is a multifunction device with the following sub modules: - Regulator - RTC - Codec - Interrupt It is interfaced to the host controller using SPI interface by a proprietary hardware called PMIC wrapper or pwrap. MT6366 MFD is a child device of the pwrap. Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> --- drivers/mfd/mt6358-irq.c | 1 + include/linux/mfd/mt6358/registers.h | 7 +++++++ include/linux/mfd/mt6397/core.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c index 83f3ffbdbb4c..ea5e452510eb 100644 --- a/drivers/mfd/mt6358-irq.c +++ b/drivers/mfd/mt6358-irq.c @@ -212,6 +212,7 @@ int mt6358_irq_init(struct mt6397_chip *chip) switch (chip->chip_id) { case MT6358_CHIP_ID: + case MT6366_CHIP_ID: chip->irq_data = &mt6358_irqd; break; diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h index 201139b12140..3d33517f178c 100644 --- a/include/linux/mfd/mt6358/registers.h +++ b/include/linux/mfd/mt6358/registers.h @@ -94,6 +94,10 @@ #define MT6358_BUCK_VCORE_CON0 0x1488 #define MT6358_BUCK_VCORE_DBG0 0x149e #define MT6358_BUCK_VCORE_DBG1 0x14a0 +#define MT6358_BUCK_VCORE_SSHUB_CON0 0x14a4 +#define MT6358_BUCK_VCORE_SSHUB_CON1 0x14a6 +#define MT6358_BUCK_VCORE_SSHUB_ELR0 MT6358_BUCK_VCORE_SSHUB_CON1 +#define MT6358_BUCK_VCORE_SSHUB_DBG1 MT6358_BUCK_VCORE_DBG1 #define MT6358_BUCK_VCORE_ELR0 0x14aa #define MT6358_BUCK_VGPU_CON0 0x1508 #define MT6358_BUCK_VGPU_DBG0 0x151e @@ -169,6 +173,9 @@ #define MT6358_LDO_VSRAM_OTHERS_CON0 0x1ba6 #define MT6358_LDO_VSRAM_OTHERS_DBG0 0x1bc0 #define MT6358_LDO_VSRAM_OTHERS_DBG1 0x1bc2 +#define MT6358_LDO_VSRAM_OTHERS_SSHUB_CON0 0x1bc4 +#define MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1 0x1bc6 +#define MT6358_LDO_VSRAM_OTHERS_SSHUB_DBG1 MT6358_LDO_VSRAM_OTHERS_DBG1 #define MT6358_LDO_VSRAM_GPU_CON0 0x1bc8 #define MT6358_LDO_VSRAM_GPU_DBG0 0x1be2 #define MT6358_LDO_VSRAM_GPU_DBG1 0x1be4 diff --git a/include/linux/mfd/mt6397/core.h b/include/linux/mfd/mt6397/core.h index 56f210eebc54..1cf78726503b 100644 --- a/include/linux/mfd/mt6397/core.h +++ b/include/linux/mfd/mt6397/core.h @@ -14,6 +14,7 @@ enum chip_id { MT6323_CHIP_ID = 0x23, MT6358_CHIP_ID = 0x58, MT6359_CHIP_ID = 0x59, + MT6366_CHIP_ID = 0x66, MT6391_CHIP_ID = 0x91, MT6397_CHIP_ID = 0x97, }; -- 2.18.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC 2022-01-06 6:54 ` [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC Johnson Wang @ 2022-02-07 7:04 ` Johnson Wang 2022-02-14 13:39 ` Lee Jones 1 sibling, 0 replies; 19+ messages in thread From: Johnson Wang @ 2022-02-07 7:04 UTC (permalink / raw) To: lee.jones, robh+dt, broonie Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group Hi Lee, This patch intends to add MT6366 PMIC support and there are some modifications in mfd subsystem. Could you give us some suggestion for this patch? Thanks for your support! BRs, Johnson Wang On Thu, 2022-01-06 at 14:54 +0800, Johnson Wang wrote: > This adds support for the MediaTek MT6366 PMIC. This is a > multifunction device with the following sub modules: > > - Regulator > - RTC > - Codec > - Interrupt > > It is interfaced to the host controller using SPI interface > by a proprietary hardware called PMIC wrapper or pwrap. > MT6366 MFD is a child device of the pwrap. > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > --- > drivers/mfd/mt6358-irq.c | 1 + > include/linux/mfd/mt6358/registers.h | 7 +++++++ > include/linux/mfd/mt6397/core.h | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c > index 83f3ffbdbb4c..ea5e452510eb 100644 > --- a/drivers/mfd/mt6358-irq.c > +++ b/drivers/mfd/mt6358-irq.c > @@ -212,6 +212,7 @@ int mt6358_irq_init(struct mt6397_chip *chip) > > switch (chip->chip_id) { > case MT6358_CHIP_ID: > + case MT6366_CHIP_ID: > chip->irq_data = &mt6358_irqd; > break; > > diff --git a/include/linux/mfd/mt6358/registers.h > b/include/linux/mfd/mt6358/registers.h > index 201139b12140..3d33517f178c 100644 > --- a/include/linux/mfd/mt6358/registers.h > +++ b/include/linux/mfd/mt6358/registers.h > @@ -94,6 +94,10 @@ > #define MT6358_BUCK_VCORE_CON0 0x1488 > #define MT6358_BUCK_VCORE_DBG0 0x149e > #define MT6358_BUCK_VCORE_DBG1 0x14a0 > +#define MT6358_BUCK_VCORE_SSHUB_CON0 0x14a4 > +#define MT6358_BUCK_VCORE_SSHUB_CON1 0x14a6 > +#define > MT6358_BUCK_VCORE_SSHUB_ELR0 MT6358_BUCK_VCORE_SSHUB_CON1 > +#define MT6358_BUCK_VCORE_SSHUB_DBG1 MT6358_BUCK_VCORE_DBG1 > #define MT6358_BUCK_VCORE_ELR0 0x14aa > #define MT6358_BUCK_VGPU_CON0 0x1508 > #define MT6358_BUCK_VGPU_DBG0 0x151e > @@ -169,6 +173,9 @@ > #define MT6358_LDO_VSRAM_OTHERS_CON0 0x1ba6 > #define MT6358_LDO_VSRAM_OTHERS_DBG0 0x1bc0 > #define MT6358_LDO_VSRAM_OTHERS_DBG1 0x1bc2 > +#define MT6358_LDO_VSRAM_OTHERS_SSHUB_CON0 0x1bc4 > +#define MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1 0x1bc6 > +#define > MT6358_LDO_VSRAM_OTHERS_SSHUB_DBG1 MT6358_LDO_VSRAM_OTHERS_DBG1 > #define MT6358_LDO_VSRAM_GPU_CON0 0x1bc8 > #define MT6358_LDO_VSRAM_GPU_DBG0 0x1be2 > #define MT6358_LDO_VSRAM_GPU_DBG1 0x1be4 > diff --git a/include/linux/mfd/mt6397/core.h > b/include/linux/mfd/mt6397/core.h > index 56f210eebc54..1cf78726503b 100644 > --- a/include/linux/mfd/mt6397/core.h > +++ b/include/linux/mfd/mt6397/core.h > @@ -14,6 +14,7 @@ enum chip_id { > MT6323_CHIP_ID = 0x23, > MT6358_CHIP_ID = 0x58, > MT6359_CHIP_ID = 0x59, > + MT6366_CHIP_ID = 0x66, > MT6391_CHIP_ID = 0x91, > MT6397_CHIP_ID = 0x97, > }; ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC 2022-01-06 6:54 ` [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC Johnson Wang 2022-02-07 7:04 ` Johnson Wang @ 2022-02-14 13:39 ` Lee Jones 2022-02-23 8:28 ` Johnson Wang 1 sibling, 1 reply; 19+ messages in thread From: Lee Jones @ 2022-02-14 13:39 UTC (permalink / raw) To: Johnson Wang Cc: robh+dt, broonie, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group On Thu, 06 Jan 2022, Johnson Wang wrote: > This adds support for the MediaTek MT6366 PMIC. This is a > multifunction device with the following sub modules: > > - Regulator > - RTC > - Codec > - Interrupt > > It is interfaced to the host controller using SPI interface > by a proprietary hardware called PMIC wrapper or pwrap. > MT6366 MFD is a child device of the pwrap. > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > --- > drivers/mfd/mt6358-irq.c | 1 + > include/linux/mfd/mt6358/registers.h | 7 +++++++ > include/linux/mfd/mt6397/core.h | 1 + > 3 files changed, 9 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC 2022-02-14 13:39 ` Lee Jones @ 2022-02-23 8:28 ` Johnson Wang 2022-02-23 9:02 ` Lee Jones 0 siblings, 1 reply; 19+ messages in thread From: Johnson Wang @ 2022-02-23 8:28 UTC (permalink / raw) To: Lee Jones Cc: robh+dt, broonie, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group On Mon, 2022-02-14 at 13:39 +0000, Lee Jones wrote: > On Thu, 06 Jan 2022, Johnson Wang wrote: > > > This adds support for the MediaTek MT6366 PMIC. This is a > > multifunction device with the following sub modules: > > > > - Regulator > > - RTC > > - Codec > > - Interrupt > > > > It is interfaced to the host controller using SPI interface > > by a proprietary hardware called PMIC wrapper or pwrap. > > MT6366 MFD is a child device of the pwrap. > > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > > --- > > drivers/mfd/mt6358-irq.c | 1 + > > include/linux/mfd/mt6358/registers.h | 7 +++++++ > > include/linux/mfd/mt6397/core.h | 1 + > > 3 files changed, 9 insertions(+) > > Applied, thanks. > Hi Lee, Thank you for your review and response. However, it seems that my patches are not applied yet. Is it possible to merge my patches into mainline? If you have any concern, please let me know. Thanks. BRs, Johnson Wang ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC 2022-02-23 8:28 ` Johnson Wang @ 2022-02-23 9:02 ` Lee Jones 0 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2022-02-23 9:02 UTC (permalink / raw) To: Johnson Wang Cc: robh+dt, broonie, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group On Wed, 23 Feb 2022, Johnson Wang wrote: > On Mon, 2022-02-14 at 13:39 +0000, Lee Jones wrote: > > On Thu, 06 Jan 2022, Johnson Wang wrote: > > > > > This adds support for the MediaTek MT6366 PMIC. This is a > > > multifunction device with the following sub modules: > > > > > > - Regulator > > > - RTC > > > - Codec > > > - Interrupt > > > > > > It is interfaced to the host controller using SPI interface > > > by a proprietary hardware called PMIC wrapper or pwrap. > > > MT6366 MFD is a child device of the pwrap. > > > > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > > > --- > > > drivers/mfd/mt6358-irq.c | 1 + > > > include/linux/mfd/mt6358/registers.h | 7 +++++++ > > > include/linux/mfd/mt6397/core.h | 1 + > > > 3 files changed, 9 insertions(+) > > > > Applied, thanks. > > > > Hi Lee, > > Thank you for your review and response. > > However, it seems that my patches are not applied yet. > Is it possible to merge my patches into mainline? Thanks for the nudge. I just found them on the wrong topic branch. They are now applied to the correct branch and pushed. The patches will arrive in -next tomorrow. Apologies for the fuss. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator 2022-01-06 6:54 [PATCH 0/4] Add Support for MediaTek PMIC MT6366 Johnson Wang 2022-01-06 6:54 ` [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC Johnson Wang @ 2022-01-06 6:54 ` Johnson Wang 2022-01-06 12:59 ` Mark Brown 2022-01-06 6:54 ` [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC Johnson Wang ` (2 subsequent siblings) 4 siblings, 1 reply; 19+ messages in thread From: Johnson Wang @ 2022-01-06 6:54 UTC (permalink / raw) To: lee.jones, robh+dt, broonie Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group, Johnson Wang The MT6366 is a regulator found on boards based on MediaTek MT8186 and probably other SoCs. It is a so called pmic and connects as a slave to SoC using SPI, wrapped inside the pmic-wrapper. Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> --- drivers/regulator/mt6358-regulator.c | 213 ++++++++++++++++++++- include/linux/regulator/mt6358-regulator.h | 45 +++++ 2 files changed, 253 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c index eb8027813b99..8a5ce990f1bf 100644 --- a/drivers/regulator/mt6358-regulator.c +++ b/drivers/regulator/mt6358-regulator.c @@ -130,6 +130,102 @@ struct mt6358_regulator_info { .qi = BIT(15), \ } +#define MT6366_BUCK(match, vreg, min, max, step, \ + volt_ranges, vosel_mask, _da_vsel_reg, _da_vsel_mask, \ + _modeset_reg, _modeset_shift) \ +[MT6366_ID_##vreg] = { \ + .desc = { \ + .name = #vreg, \ + .of_match = of_match_ptr(match), \ + .ops = &mt6358_volt_range_ops, \ + .type = REGULATOR_VOLTAGE, \ + .id = MT6366_ID_##vreg, \ + .owner = THIS_MODULE, \ + .n_voltages = ((max) - (min)) / (step) + 1, \ + .linear_ranges = volt_ranges, \ + .n_linear_ranges = ARRAY_SIZE(volt_ranges), \ + .vsel_reg = MT6358_BUCK_##vreg##_ELR0, \ + .vsel_mask = vosel_mask, \ + .enable_reg = MT6358_BUCK_##vreg##_CON0, \ + .enable_mask = BIT(0), \ + .of_map_mode = mt6358_map_mode, \ + }, \ + .status_reg = MT6358_BUCK_##vreg##_DBG1, \ + .qi = BIT(0), \ + .da_vsel_reg = _da_vsel_reg, \ + .da_vsel_mask = _da_vsel_mask, \ + .modeset_reg = _modeset_reg, \ + .modeset_mask = BIT(_modeset_shift), \ +} + +#define MT6366_LDO(match, vreg, ldo_volt_table, \ + ldo_index_table, enreg, enbit, vosel, \ + vosel_mask) \ +[MT6366_ID_##vreg] = { \ + .desc = { \ + .name = #vreg, \ + .of_match = of_match_ptr(match), \ + .ops = &mt6358_volt_table_ops, \ + .type = REGULATOR_VOLTAGE, \ + .id = MT6366_ID_##vreg, \ + .owner = THIS_MODULE, \ + .n_voltages = ARRAY_SIZE(ldo_volt_table), \ + .volt_table = ldo_volt_table, \ + .vsel_reg = vosel, \ + .vsel_mask = vosel_mask, \ + .enable_reg = enreg, \ + .enable_mask = BIT(enbit), \ + }, \ + .status_reg = MT6358_LDO_##vreg##_CON1, \ + .qi = BIT(15), \ + .index_table = ldo_index_table, \ + .n_table = ARRAY_SIZE(ldo_index_table), \ +} + +#define MT6366_LDO1(match, vreg, min, max, step, \ + volt_ranges, _da_vsel_reg, _da_vsel_mask, \ + vosel, vosel_mask) \ +[MT6366_ID_##vreg] = { \ + .desc = { \ + .name = #vreg, \ + .of_match = of_match_ptr(match), \ + .ops = &mt6358_volt_range_ops, \ + .type = REGULATOR_VOLTAGE, \ + .id = MT6366_ID_##vreg, \ + .owner = THIS_MODULE, \ + .n_voltages = ((max) - (min)) / (step) + 1, \ + .linear_ranges = volt_ranges, \ + .n_linear_ranges = ARRAY_SIZE(volt_ranges), \ + .vsel_reg = vosel, \ + .vsel_mask = vosel_mask, \ + .enable_reg = MT6358_LDO_##vreg##_CON0, \ + .enable_mask = BIT(0), \ + }, \ + .da_vsel_reg = _da_vsel_reg, \ + .da_vsel_mask = _da_vsel_mask, \ + .status_reg = MT6358_LDO_##vreg##_DBG1, \ + .qi = BIT(0), \ +} + +#define MT6366_REG_FIXED(match, vreg, \ + enreg, enbit, volt) \ +[MT6366_ID_##vreg] = { \ + .desc = { \ + .name = #vreg, \ + .of_match = of_match_ptr(match), \ + .ops = &mt6358_volt_fixed_ops, \ + .type = REGULATOR_VOLTAGE, \ + .id = MT6366_ID_##vreg, \ + .owner = THIS_MODULE, \ + .n_voltages = 1, \ + .enable_reg = enreg, \ + .enable_mask = BIT(enbit), \ + .min_uV = volt, \ + }, \ + .status_reg = MT6358_LDO_##vreg##_CON1, \ + .qi = BIT(15), \ +} + static const struct linear_range buck_volt_range1[] = { REGULATOR_LINEAR_RANGE(500000, 0, 0x7f, 6250), }; @@ -409,6 +505,9 @@ static struct mt6358_regulator_info mt6358_regulators[] = { MT6358_BUCK("buck_vcore", VCORE, 500000, 1293750, 6250, buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_DBG0, 0x7f, MT6358_VCORE_VGPU_ANA_CON0, 1), + MT6358_BUCK("buck_vcore_sshub", VCORE_SSHUB, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_SSHUB_ELR0, 0x7f, + MT6358_VCORE_VGPU_ANA_CON0, 1), MT6358_BUCK("buck_vpa", VPA, 500000, 3650000, 50000, buck_volt_range3, 0x3f, MT6358_BUCK_VPA_DBG0, 0x3f, MT6358_VPA_ANA_CON0, 3), @@ -488,6 +587,10 @@ static struct mt6358_regulator_info mt6358_regulators[] = { MT6358_LDO1("ldo_vsram_others", VSRAM_OTHERS, 500000, 1293750, 6250, buck_volt_range1, MT6358_LDO_VSRAM_OTHERS_DBG0, 0x7f00, MT6358_LDO_VSRAM_CON2, 0x7f), + MT6358_LDO1("ldo_vsram_others_sshub", VSRAM_OTHERS_SSHUB, 500000, + 1293750, 6250, buck_volt_range1, + MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f, + MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f), MT6358_LDO1("ldo_vsram_gpu", VSRAM_GPU, 500000, 1293750, 6250, buck_volt_range1, MT6358_LDO_VSRAM_GPU_DBG0, 0x7f00, MT6358_LDO_VSRAM_CON3, 0x7f), @@ -496,24 +599,124 @@ static struct mt6358_regulator_info mt6358_regulators[] = { MT6358_LDO_VSRAM_CON1, 0x7f), }; +/* The array is indexed by id(MT6366_ID_XXX) */ +static struct mt6358_regulator_info mt6366_regulators[] = { + MT6366_BUCK("buck_vdram1", VDRAM1, 500000, 2087500, 12500, + buck_volt_range2, 0x7f, MT6358_BUCK_VDRAM1_DBG0, 0x7f, + MT6358_VDRAM1_ANA_CON0, 8), + MT6366_BUCK("buck_vcore", VCORE, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_DBG0, 0x7f, + MT6358_VCORE_VGPU_ANA_CON0, 1), + MT6366_BUCK("buck_vcore_sshub", VCORE_SSHUB, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VCORE_SSHUB_ELR0, 0x7f, + MT6358_VCORE_VGPU_ANA_CON0, 1), + MT6366_BUCK("buck_vpa", VPA, 500000, 3650000, 50000, + buck_volt_range3, 0x3f, MT6358_BUCK_VPA_DBG0, 0x3f, + MT6358_VPA_ANA_CON0, 3), + MT6366_BUCK("buck_vproc11", VPROC11, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VPROC11_DBG0, 0x7f, + MT6358_VPROC_ANA_CON0, 1), + MT6366_BUCK("buck_vproc12", VPROC12, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VPROC12_DBG0, 0x7f, + MT6358_VPROC_ANA_CON0, 2), + MT6366_BUCK("buck_vgpu", VGPU, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VGPU_ELR0, 0x7f, + MT6358_VCORE_VGPU_ANA_CON0, 2), + MT6366_BUCK("buck_vs2", VS2, 500000, 2087500, 12500, + buck_volt_range2, 0x7f, MT6358_BUCK_VS2_DBG0, 0x7f, + MT6358_VS2_ANA_CON0, 8), + MT6366_BUCK("buck_vmodem", VMODEM, 500000, 1293750, 6250, + buck_volt_range1, 0x7f, MT6358_BUCK_VMODEM_DBG0, 0x7f, + MT6358_VMODEM_ANA_CON0, 8), + MT6366_BUCK("buck_vs1", VS1, 1000000, 2587500, 12500, + buck_volt_range4, 0x7f, MT6358_BUCK_VS1_DBG0, 0x7f, + MT6358_VS1_ANA_CON0, 8), + MT6366_REG_FIXED("ldo_vrf12", VRF12, + MT6358_LDO_VRF12_CON0, 0, 1200000), + MT6366_REG_FIXED("ldo_vio18", VIO18, + MT6358_LDO_VIO18_CON0, 0, 1800000), + MT6366_REG_FIXED("ldo_vcn18", VCN18, MT6358_LDO_VCN18_CON0, 0, 1800000), + MT6366_REG_FIXED("ldo_vfe28", VFE28, MT6358_LDO_VFE28_CON0, 0, 2800000), + MT6366_REG_FIXED("ldo_vcn28", VCN28, MT6358_LDO_VCN28_CON0, 0, 2800000), + MT6366_REG_FIXED("ldo_vxo22", VXO22, MT6358_LDO_VXO22_CON0, 0, 2200000), + MT6366_REG_FIXED("ldo_vaux18", VAUX18, + MT6358_LDO_VAUX18_CON0, 0, 1800000), + MT6366_REG_FIXED("ldo_vbif28", VBIF28, + MT6358_LDO_VBIF28_CON0, 0, 2800000), + MT6366_REG_FIXED("ldo_vio28", VIO28, MT6358_LDO_VIO28_CON0, 0, 2800000), + MT6366_REG_FIXED("ldo_va12", VA12, MT6358_LDO_VA12_CON0, 0, 1200000), + MT6366_REG_FIXED("ldo_vrf18", VRF18, MT6358_LDO_VRF18_CON0, 0, 1800000), + MT6366_REG_FIXED("ldo_vaud28", VAUD28, + MT6358_LDO_VAUD28_CON0, 0, 2800000), + MT6366_LDO("ldo_vdram2", VDRAM2, vdram2_voltages, vdram2_idx, + MT6358_LDO_VDRAM2_CON0, 0, MT6358_LDO_VDRAM2_ELR0, 0x10), + MT6366_LDO("ldo_vsim1", VSIM1, vsim_voltages, vsim_idx, + MT6358_LDO_VSIM1_CON0, 0, MT6358_VSIM1_ANA_CON0, 0xf00), + MT6366_LDO("ldo_vibr", VIBR, vibr_voltages, vibr_idx, + MT6358_LDO_VIBR_CON0, 0, MT6358_VIBR_ANA_CON0, 0xf00), + MT6366_LDO("ldo_vusb", VUSB, vusb_voltages, vusb_idx, + MT6358_LDO_VUSB_CON0_0, 0, MT6358_VUSB_ANA_CON0, 0x700), + MT6366_LDO("ldo_vefuse", VEFUSE, vefuse_voltages, vefuse_idx, + MT6358_LDO_VEFUSE_CON0, 0, MT6358_VEFUSE_ANA_CON0, 0xf00), + MT6366_LDO("ldo_vmch", VMCH, vmch_vemc_voltages, vmch_vemc_idx, + MT6358_LDO_VMCH_CON0, 0, MT6358_VMCH_ANA_CON0, 0x700), + MT6366_LDO("ldo_vemc", VEMC, vmch_vemc_voltages, vmch_vemc_idx, + MT6358_LDO_VEMC_CON0, 0, MT6358_VEMC_ANA_CON0, 0x700), + MT6366_LDO("ldo_vcn33_bt", VCN33_BT, vcn33_bt_wifi_voltages, + vcn33_bt_wifi_idx, MT6358_LDO_VCN33_CON0_0, + 0, MT6358_VCN33_ANA_CON0, 0x300), + MT6366_LDO("ldo_vcn33_wifi", VCN33_WIFI, vcn33_bt_wifi_voltages, + vcn33_bt_wifi_idx, MT6358_LDO_VCN33_CON0_1, + 0, MT6358_VCN33_ANA_CON0, 0x300), + MT6366_LDO("ldo_vmc", VMC, vmc_voltages, vmc_idx, + MT6358_LDO_VMC_CON0, 0, MT6358_VMC_ANA_CON0, 0xf00), + MT6366_LDO("ldo_vsim2", VSIM2, vsim_voltages, vsim_idx, + MT6358_LDO_VSIM2_CON0, 0, MT6358_VSIM2_ANA_CON0, 0xf00), + MT6366_LDO1("ldo_vsram_proc11", VSRAM_PROC11, 500000, 1293750, 6250, + buck_volt_range1, MT6358_LDO_VSRAM_PROC11_DBG0, 0x7f00, + MT6358_LDO_VSRAM_CON0, 0x7f), + MT6366_LDO1("ldo_vsram_others", VSRAM_OTHERS, 500000, 1293750, 6250, + buck_volt_range1, MT6358_LDO_VSRAM_OTHERS_DBG0, 0x7f00, + MT6358_LDO_VSRAM_CON2, 0x7f), + MT6366_LDO1("ldo_vsram_others_sshub", VSRAM_OTHERS_SSHUB, 500000, + 1293750, 6250, buck_volt_range1, + MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f, + MT6358_LDO_VSRAM_OTHERS_SSHUB_CON1, 0x7f), + MT6366_LDO1("ldo_vsram_gpu", VSRAM_GPU, 500000, 1293750, 6250, + buck_volt_range1, MT6358_LDO_VSRAM_GPU_DBG0, 0x7f00, + MT6358_LDO_VSRAM_CON3, 0x7f), + MT6366_LDO1("ldo_vsram_proc12", VSRAM_PROC12, 500000, 1293750, 6250, + buck_volt_range1, MT6358_LDO_VSRAM_PROC12_DBG0, 0x7f00, + MT6358_LDO_VSRAM_CON1, 0x7f), +}; + static int mt6358_regulator_probe(struct platform_device *pdev) { struct mt6397_chip *mt6397 = dev_get_drvdata(pdev->dev.parent); struct regulator_config config = {}; struct regulator_dev *rdev; - int i; + struct mt6358_regulator_info *mt6358_info; + int i, max_regulator; + + if (mt6397->chip_id == MT6366_CHIP_ID) { + max_regulator = MT6366_MAX_REGULATOR; + mt6358_info = mt6366_regulators; + } else { + max_regulator = MT6358_MAX_REGULATOR; + mt6358_info = mt6358_regulators; + } - for (i = 0; i < MT6358_MAX_REGULATOR; i++) { + for (i = 0; i < max_regulator; i++) { config.dev = &pdev->dev; - config.driver_data = &mt6358_regulators[i]; + config.driver_data = &mt6358_info[i]; config.regmap = mt6397->regmap; rdev = devm_regulator_register(&pdev->dev, - &mt6358_regulators[i].desc, + &mt6358_info[i].desc, &config); if (IS_ERR(rdev)) { dev_err(&pdev->dev, "failed to register %s\n", - mt6358_regulators[i].desc.name); + mt6358_info[i].desc.name); return PTR_ERR(rdev); } } diff --git a/include/linux/regulator/mt6358-regulator.h b/include/linux/regulator/mt6358-regulator.h index 1cc304946d09..bdcf83cd719e 100644 --- a/include/linux/regulator/mt6358-regulator.h +++ b/include/linux/regulator/mt6358-regulator.h @@ -48,9 +48,54 @@ enum { MT6358_ID_VLDO28, MT6358_ID_VAUD28, MT6358_ID_VSIM2, + MT6358_ID_VCORE_SSHUB, + MT6358_ID_VSRAM_OTHERS_SSHUB, MT6358_ID_RG_MAX, }; +enum { + MT6366_ID_VDRAM1 = 0, + MT6366_ID_VCORE, + MT6366_ID_VPA, + MT6366_ID_VPROC11, + MT6366_ID_VPROC12, + MT6366_ID_VGPU, + MT6366_ID_VS2, + MT6366_ID_VMODEM, + MT6366_ID_VS1, + MT6366_ID_VDRAM2, + MT6366_ID_VSIM1, + MT6366_ID_VIBR, + MT6366_ID_VRF12, + MT6366_ID_VIO18, + MT6366_ID_VUSB, + MT6366_ID_VCN18, + MT6366_ID_VFE28, + MT6366_ID_VSRAM_PROC11, + MT6366_ID_VCN28, + MT6366_ID_VSRAM_OTHERS, + MT6366_ID_VSRAM_GPU, + MT6366_ID_VXO22, + MT6366_ID_VEFUSE, + MT6366_ID_VAUX18, + MT6366_ID_VMCH, + MT6366_ID_VBIF28, + MT6366_ID_VSRAM_PROC12, + MT6366_ID_VEMC, + MT6366_ID_VIO28, + MT6366_ID_VA12, + MT6366_ID_VRF18, + MT6366_ID_VCN33_BT, + MT6366_ID_VCN33_WIFI, + MT6366_ID_VMC, + MT6366_ID_VAUD28, + MT6366_ID_VSIM2, + MT6366_ID_VCORE_SSHUB, + MT6366_ID_VSRAM_OTHERS_SSHUB, + MT6366_ID_RG_MAX, +}; + #define MT6358_MAX_REGULATOR MT6358_ID_RG_MAX +#define MT6366_MAX_REGULATOR MT6366_ID_RG_MAX #endif /* __LINUX_REGULATOR_MT6358_H */ -- 2.18.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator 2022-01-06 6:54 ` [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator Johnson Wang @ 2022-01-06 12:59 ` Mark Brown 2022-02-23 9:58 ` Johnson Wang 0 siblings, 1 reply; 19+ messages in thread From: Mark Brown @ 2022-01-06 12:59 UTC (permalink / raw) To: Johnson Wang Cc: lee.jones, robh+dt, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group [-- Attachment #1: Type: text/plain, Size: 303 bytes --] On Thu, Jan 06, 2022 at 02:54:05PM +0800, Johnson Wang wrote: > The MT6366 is a regulator found on boards based on MediaTek MT8186 and > probably other SoCs. It is a so called pmic and connects as a slave to > SoC using SPI, wrapped inside the pmic-wrapper. Reviwed-by: Mark Brown <broonie@kernel.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator 2022-01-06 12:59 ` Mark Brown @ 2022-02-23 9:58 ` Johnson Wang 0 siblings, 0 replies; 19+ messages in thread From: Johnson Wang @ 2022-02-23 9:58 UTC (permalink / raw) To: Mark Brown Cc: lee.jones, robh+dt, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group On Thu, 2022-01-06 at 12:59 +0000, Mark Brown wrote: > On Thu, Jan 06, 2022 at 02:54:05PM +0800, Johnson Wang wrote: > > The MT6366 is a regulator found on boards based on MediaTek MT8186 > > and > > probably other SoCs. It is a so called pmic and connects as a slave > > to > > SoC using SPI, wrapped inside the pmic-wrapper. > > Reviwed-by: Mark Brown <broonie@kernel.org> Hi Mark, Thank you for review. Do these regulator patches need some improvement? If yes, please give me your advices. Otherwise, is it possible to apply these patches in the future? Thanks. BRs, Johnson Wang ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC 2022-01-06 6:54 [PATCH 0/4] Add Support for MediaTek PMIC MT6366 Johnson Wang 2022-01-06 6:54 ` [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC Johnson Wang 2022-01-06 6:54 ` [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator Johnson Wang @ 2022-01-06 6:54 ` Johnson Wang 2022-01-12 1:44 ` Rob Herring 2022-02-14 13:39 ` Lee Jones 2022-01-06 6:54 ` [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators Johnson Wang 2022-03-08 8:28 ` [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window Lee Jones 4 siblings, 2 replies; 19+ messages in thread From: Johnson Wang @ 2022-01-06 6:54 UTC (permalink / raw) To: lee.jones, robh+dt, broonie Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group, Johnson Wang This adds compatible for the MediaTek MT6366 PMIC. Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> --- Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 99a84b69a29f..293db2a71ef2 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt @@ -20,7 +20,7 @@ This document describes the binding for MFD device and its sub module. Required properties: compatible: "mediatek,mt6323" for PMIC MT6323 - "mediatek,mt6358" for PMIC MT6358 + "mediatek,mt6358" for PMIC MT6358 and MT6366 "mediatek,mt6359" for PMIC MT6359 "mediatek,mt6397" for PMIC MT6397 -- 2.18.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC 2022-01-06 6:54 ` [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC Johnson Wang @ 2022-01-12 1:44 ` Rob Herring 2022-02-14 13:39 ` Lee Jones 1 sibling, 0 replies; 19+ messages in thread From: Rob Herring @ 2022-01-12 1:44 UTC (permalink / raw) To: Johnson Wang Cc: linux-mediatek, lee.jones, broonie, robh+dt, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel On Thu, 06 Jan 2022 14:54:06 +0800, Johnson Wang wrote: > This adds compatible for the MediaTek MT6366 PMIC. > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC 2022-01-06 6:54 ` [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC Johnson Wang 2022-01-12 1:44 ` Rob Herring @ 2022-02-14 13:39 ` Lee Jones 1 sibling, 0 replies; 19+ messages in thread From: Lee Jones @ 2022-02-14 13:39 UTC (permalink / raw) To: Johnson Wang Cc: robh+dt, broonie, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group On Thu, 06 Jan 2022, Johnson Wang wrote: > This adds compatible for the MediaTek MT6366 PMIC. > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators 2022-01-06 6:54 [PATCH 0/4] Add Support for MediaTek PMIC MT6366 Johnson Wang ` (2 preceding siblings ...) 2022-01-06 6:54 ` [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC Johnson Wang @ 2022-01-06 6:54 ` Johnson Wang 2022-01-06 13:09 ` Mark Brown 2022-01-12 1:45 ` Rob Herring 2022-03-08 8:28 ` [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window Lee Jones 4 siblings, 2 replies; 19+ messages in thread From: Johnson Wang @ 2022-01-06 6:54 UTC (permalink / raw) To: lee.jones, robh+dt, broonie Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group, Johnson Wang Add buck_vcore_sshub and ldo_vsram_others_sshub regulators to binding document for MT6358 and MT6366. Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> --- .../bindings/regulator/mt6358-regulator.txt | 22 ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt index 9a90a92f2d7e..7034cdca54e0 100644 --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt @@ -8,14 +8,14 @@ Documentation/devicetree/bindings/regulator/regulator.txt. The valid names for regulators are:: BUCK: - buck_vdram1, buck_vcore, buck_vpa, buck_vproc11, buck_vproc12, buck_vgpu, - buck_vs2, buck_vmodem, buck_vs1 + buck_vdram1, buck_vcore, buck_vcore_sshub, buck_vpa, buck_vproc11, + buck_vproc12, buck_vgpu, buck_vs2, buck_vmodem, buck_vs1 LDO: ldo_vdram2, ldo_vsim1, ldo_vibr, ldo_vrf12, ldo_vio18, ldo_vusb, ldo_vcamio, ldo_vcamd, ldo_vcn18, ldo_vfe28, ldo_vsram_proc11, ldo_vcn28, ldo_vsram_others, - ldo_vsram_gpu, ldo_vxo22, ldo_vefuse, ldo_vaux18, ldo_vmch, ldo_vbif28, - ldo_vsram_proc12, ldo_vcama1, ldo_vemc, ldo_vio28, ldo_va12, ldo_vrf18, - ldo_vcn33_bt, ldo_vcn33_wifi, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28, + ldo_vsram_others_sshub, ldo_vsram_gpu, ldo_vxo22, ldo_vefuse, ldo_vaux18, + ldo_vmch, ldo_vbif28, ldo_vsram_proc12, ldo_vcama1, ldo_vemc, ldo_vio28, ldo_va12, + ldo_vrf18, ldo_vcn33_bt, ldo_vcn33_wifi, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28, ldo_vsim2 Example: @@ -354,5 +354,17 @@ Example: regulator-max-microvolt = <3100000>; regulator-enable-ramp-delay = <540>; }; + + mt6358_vcore_sshub_reg: buck_vcore_sshub { + regulator-name = "vcore_sshub"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1293750>; + }; + + mt6358_vsram_others_sshub_reg: ldo_vsram_others_sshub { + regulator-name = "vsram_others_sshub"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1293750>; + }; }; }; -- 2.18.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators 2022-01-06 6:54 ` [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators Johnson Wang @ 2022-01-06 13:09 ` Mark Brown 2022-01-12 1:45 ` Rob Herring 1 sibling, 0 replies; 19+ messages in thread From: Mark Brown @ 2022-01-06 13:09 UTC (permalink / raw) To: Johnson Wang Cc: lee.jones, robh+dt, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group [-- Attachment #1: Type: text/plain, Size: 544 bytes --] On Thu, Jan 06, 2022 at 02:54:07PM +0800, Johnson Wang wrote: > Add buck_vcore_sshub and ldo_vsram_others_sshub > regulators to binding document for MT6358 and MT6366. Reviwed-by: Mark Brown <broonie@kernel.org> Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators 2022-01-06 6:54 ` [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators Johnson Wang 2022-01-06 13:09 ` Mark Brown @ 2022-01-12 1:45 ` Rob Herring 2022-03-03 8:18 ` Fei Shao 1 sibling, 1 reply; 19+ messages in thread From: Rob Herring @ 2022-01-12 1:45 UTC (permalink / raw) To: Johnson Wang Cc: Project_Global_Chrome_Upstream_Group, devicetree, linux-mediatek, linux-arm-kernel, broonie, linux-kernel, robh+dt, lee.jones On Thu, 06 Jan 2022 14:54:07 +0800, Johnson Wang wrote: > Add buck_vcore_sshub and ldo_vsram_others_sshub > regulators to binding document for MT6358 and MT6366. > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > --- > .../bindings/regulator/mt6358-regulator.txt | 22 ++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators 2022-01-12 1:45 ` Rob Herring @ 2022-03-03 8:18 ` Fei Shao 0 siblings, 0 replies; 19+ messages in thread From: Fei Shao @ 2022-03-03 8:18 UTC (permalink / raw) To: Rob Herring Cc: Johnson Wang, Project_Global_Chrome_Upstream_Group, devicetree, moderated list:ARM/Mediatek SoC support, Linux ARM, broonie, linux-kernel, Rob Herring, Lee Jones On Tue, 11 Jan 2022 19:45:47 -0600, Rob Herring <robh@kernel.org> wrote: > > On Thu, 06 Jan 2022 14:54:07 +0800, Johnson Wang wrote: > > Add buck_vcore_sshub and ldo_vsram_others_sshub > > regulators to binding document for MT6358 and MT6366. > > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > > --- > > .../bindings/regulator/mt6358-regulator.txt | 22 ++++++++++++++----- > > 1 file changed, 17 insertions(+), 5 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Just a gentle ping on this - I assume there's no actionable item on Johnson's end? (or better to rebase & resend?) ^ permalink raw reply [flat|nested] 19+ messages in thread
* [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window 2022-01-06 6:54 [PATCH 0/4] Add Support for MediaTek PMIC MT6366 Johnson Wang ` (3 preceding siblings ...) 2022-01-06 6:54 ` [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators Johnson Wang @ 2022-03-08 8:28 ` Lee Jones 2022-03-08 12:49 ` Mark Brown 4 siblings, 1 reply; 19+ messages in thread From: Lee Jones @ 2022-03-08 8:28 UTC (permalink / raw) To: Johnson Wang, broonie Cc: robh+dt, broonie, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group Mark, This one is just for you, so you can merge the other patches. The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07: Linux 5.17-rc1 (2022-01-23 10:12:53 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-mediatek-mt6366-v5.18 for you to fetch changes up to c47383f849097c2b3547e28365578cd9e5811378: mfd: Add support for the MediaTek MT6366 PMIC (2022-03-07 14:59:44 +0000) ---------------------------------------------------------------- Immutable branch for MediaTek MT6366 due for the v5.18 merge window ---------------------------------------------------------------- Johnson Wang (1): mfd: Add support for the MediaTek MT6366 PMIC drivers/mfd/mt6358-irq.c | 1 + include/linux/mfd/mt6358/registers.h | 7 +++++++ include/linux/mfd/mt6397/core.h | 1 + 3 files changed, 9 insertions(+) -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window 2022-03-08 8:28 ` [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window Lee Jones @ 2022-03-08 12:49 ` Mark Brown 2022-03-08 13:09 ` Lee Jones 0 siblings, 1 reply; 19+ messages in thread From: Mark Brown @ 2022-03-08 12:49 UTC (permalink / raw) To: Lee Jones Cc: Johnson Wang, robh+dt, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group [-- Attachment #1: Type: text/plain, Size: 481 bytes --] On Tue, Mar 08, 2022 at 08:28:43AM +0000, Lee Jones wrote: > Mark, > > This one is just for you, so you can merge the other patches. I don't know what the other patches you're referring to here are, someone's going to need to resend them. I'm also not sure things like like "FAO MARK BROWN" in the subject line of the e-mail, I can already see if a message has been sent to me from the To and it means less of the actual subject is wrapped out of sight in my inbox. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window 2022-03-08 12:49 ` Mark Brown @ 2022-03-08 13:09 ` Lee Jones 0 siblings, 0 replies; 19+ messages in thread From: Lee Jones @ 2022-03-08 13:09 UTC (permalink / raw) To: Mark Brown Cc: Johnson Wang, robh+dt, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, Project_Global_Chrome_Upstream_Group On Tue, 08 Mar 2022, Mark Brown wrote: > On Tue, Mar 08, 2022 at 08:28:43AM +0000, Lee Jones wrote: > > Mark, > > > > This one is just for you, so you can merge the other patches. > > I don't know what the other patches you're referring to here are, > someone's going to need to resend them. > > I'm also not sure things like like "FAO MARK BROWN" in the subject line > of the e-mail, I can already see if a message has been sent to me from > the To and it means less of the actual subject is wrapped out of sight > in my inbox. Might be time to upgrade your VT100! -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-03-08 13:09 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-01-06 6:54 [PATCH 0/4] Add Support for MediaTek PMIC MT6366 Johnson Wang 2022-01-06 6:54 ` [PATCH 1/4] mfd: Add support for the MediaTek MT6366 PMIC Johnson Wang 2022-02-07 7:04 ` Johnson Wang 2022-02-14 13:39 ` Lee Jones 2022-02-23 8:28 ` Johnson Wang 2022-02-23 9:02 ` Lee Jones 2022-01-06 6:54 ` [PATCH 2/4] regulator: mt6366: Add support for MT6366 regulator Johnson Wang 2022-01-06 12:59 ` Mark Brown 2022-02-23 9:58 ` Johnson Wang 2022-01-06 6:54 ` [PATCH 3/4] dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC Johnson Wang 2022-01-12 1:44 ` Rob Herring 2022-02-14 13:39 ` Lee Jones 2022-01-06 6:54 ` [PATCH 4/4] dt-bindings: regulator: Add MT6358 regulators Johnson Wang 2022-01-06 13:09 ` Mark Brown 2022-01-12 1:45 ` Rob Herring 2022-03-03 8:18 ` Fei Shao 2022-03-08 8:28 ` [GIT PULL - FAO MARK BROWN]: Immutable branch for MediaTek MT6366 due for the v5.18 merge window Lee Jones 2022-03-08 12:49 ` Mark Brown 2022-03-08 13:09 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).