From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_ppratap@quicinc.com
Subject: Re: [PATCH v3 3/3] usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
Date: Thu, 24 Mar 2022 14:27:50 +0200 [thread overview]
Message-ID: <YjxjxplpOpDC2JLs@kuha.fi.intel.com> (raw)
In-Reply-To: <1648103831-12347-4-git-send-email-quic_c_sanm@quicinc.com>
On Thu, Mar 24, 2022 at 12:07:11PM +0530, Sandeep Maheswaram wrote:
> Currently the phy init is done from dwc3 and also xhci which makes the
> runtime_usage value 2 for the phy which causes issue during runtime
> suspend. When we run the below command the runtime_status still shows
> active.
> echo auto > /sys/bus/platform/devices/88e3000.phy/power/control
>
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core by setting this quirk.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
> drivers/usb/dwc3/host.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index eda8719..d4fcf06 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -13,6 +13,12 @@
> #include <linux/platform_device.h>
>
> #include "core.h"
> +#include <linux/usb/xhci-plat.h>
> +#include <linux/usb/xhci-quirks.h>
> +
> +static const struct xhci_plat_priv xhci_plat_dwc3_xhci = {
> + .quirks = XHCI_SKIP_PHY_INIT,
> +};
>
> static void dwc3_host_fill_xhci_irq_res(struct dwc3 *dwc,
> int irq, char *name)
> @@ -122,6 +128,13 @@ int dwc3_host_init(struct dwc3 *dwc)
> }
> }
>
> + ret = platform_device_add_data(xhci, &xhci_plat_dwc3_xhci,
> + sizeof(xhci_plat_dwc3_xhci));
> + if (ret) {
> + dev_err(dwc->dev, "failed to add data to xHCI\n");
> + goto err;
> + }
> +
> ret = platform_device_add(xhci);
> if (ret) {
> dev_err(dwc->dev, "failed to register xHCI device\n");
I think you should just use device property:
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index eda871973d6cc..dbff7b8ed6d5e 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -67,7 +67,7 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
int dwc3_host_init(struct dwc3 *dwc)
{
- struct property_entry props[4];
+ struct property_entry props[5];
struct platform_device *xhci;
int ret, irq;
int prop_idx = 0;
@@ -114,12 +114,12 @@ int dwc3_host_init(struct dwc3 *dwc)
if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
- if (prop_idx) {
- ret = device_create_managed_software_node(&xhci->dev, props, NULL);
- if (ret) {
- dev_err(dwc->dev, "failed to add properties to xHCI\n");
- goto err;
- }
+ props[prop_idx++] = PROPERTY_ENTRY_BOOL("skip-phy-init");
+
+ ret = device_create_managed_software_node(&xhci->dev, props, NULL);
+ if (ret) {
+ dev_err(dwc->dev, "failed to add properties to xHCI\n");
+ goto err;
}
ret = platform_device_add(xhci);
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 649ffd861b44e..31ed39d06e29b 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -307,6 +307,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
device_property_read_u32(tmpdev, "imod-interval-ns",
&xhci->imod_interval);
+
+ if (device_property_read_bool(tmpdev, "skip-phy-init"))
+ hcd->skip_phy_initialization = 1;
}
hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev, "usb-phy", 0);
--
heikki
next prev parent reply other threads:[~2022-03-24 12:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 6:37 [PATCH v3 0/3] Refactor xhci quirks and plat private data Sandeep Maheswaram
2022-03-24 6:37 ` [PATCH v3 1/3] usb: xhci: refactor " Sandeep Maheswaram
2022-03-24 6:37 ` [PATCH v3 2/3] usb: xhci: Remove unwanted header inclusion Sandeep Maheswaram
2022-03-24 6:37 ` [PATCH v3 3/3] usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT Sandeep Maheswaram
2022-03-24 12:27 ` Heikki Krogerus [this message]
2022-03-24 22:36 ` Mathias Nyman
2022-03-25 11:27 ` Heikki Krogerus
2022-03-25 14:33 ` Mathias Nyman
2022-03-25 15:38 ` Heikki Krogerus
2022-03-29 9:18 ` Sandeep Maheswaram (Temp)
2022-03-29 9:28 ` Pavan Kondeti
2022-03-30 17:47 ` Mathias Nyman
2022-03-31 11:16 ` Heikki Krogerus
2022-04-04 8:25 ` Pavan Kondeti
2022-04-06 6:25 ` Pavan Kondeti
2022-04-06 10:27 ` Heikki Krogerus
2022-04-06 10:52 ` Mathias Nyman
2022-04-06 11:01 ` Pavan Kondeti
2022-04-06 12:18 ` Mathias Nyman
2022-04-06 15:34 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjxjxplpOpDC2JLs@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=a-govindraju@ti.com \
--cc=balbi@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=rogerq@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).