From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hangyu Hua <hbh25y@gmail.com>,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mc: delete redundant code in __media_device_unregister_entity
Date: Wed, 30 Mar 2022 14:05:45 +0300 [thread overview]
Message-ID: <YkQ5ic2b/gaF8cF+@paasikivi.fi.intel.com> (raw)
In-Reply-To: <Yjx2Xm7JmS+E8d7M@pendragon.ideasonboard.com>
On Thu, Mar 24, 2022 at 03:47:10PM +0200, Laurent Pinchart wrote:
> Hi Hangyu,
>
> Thank you for the patch.
>
> On Thu, Mar 24, 2022 at 06:27:52PM +0800, Hangyu Hua wrote:
> > media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to
> > set it again.
> >
> > Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > drivers/media/mc/mc-device.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> > index cf5e459b1d96..7727c619043e 100644
> > --- a/drivers/media/mc/mc-device.c
> > +++ b/drivers/media/mc/mc-device.c
> > @@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
> >
> > /* invoke entity_notify callbacks to handle entity removal?? */
> >
> > - entity->graph_obj.mdev = NULL;
Removed the extra newline above, too. Applied.
Please run scripts/checkpatch.pl on the patches, too.
> > }
> >
> > /**
>
> --
> Regards,
>
> Laurent Pinchart
--
Sakari Ailus
next prev parent reply other threads:[~2022-03-30 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 10:27 [PATCH] media: mc: delete redundant code in __media_device_unregister_entity Hangyu Hua
2022-03-24 13:47 ` Laurent Pinchart
2022-03-30 11:05 ` Sakari Ailus [this message]
2022-03-31 1:52 ` Hangyu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkQ5ic2b/gaF8cF+@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hbh25y@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).