linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm: kdump: add invalid input check for 'crashkernel=0'
@ 2022-03-31 11:24 Austin Kim
  2022-03-31 13:05 ` Russell King (Oracle)
  0 siblings, 1 reply; 3+ messages in thread
From: Austin Kim @ 2022-03-31 11:24 UTC (permalink / raw)
  To: linux, arnd; +Cc: linux-arm-kernel, linux-kernel, austin.kim, p4ranlee

From: Austin Kim <austin.kim@lge.com>

Add invalid input check expression when 'crashkernel=0' is specified 
running kdump.

Signed-off-by: Austin Kim <austin.kim@lge.com>
---
 arch/arm/kernel/setup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 039feb7cd590..1e8a50a97edf 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -1004,7 +1004,8 @@ static void __init reserve_crashkernel(void)
 	total_mem = get_total_mem();
 	ret = parse_crashkernel(boot_command_line, total_mem,
 				&crash_size, &crash_base);
-	if (ret)
+	/* invalid value specified or crashkernel=0 */
+	if (ret || !crash_size)
 		return;
 
 	if (crash_base <= 0) {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm: kdump: add invalid input check for 'crashkernel=0'
  2022-03-31 11:24 [PATCH v2] arm: kdump: add invalid input check for 'crashkernel=0' Austin Kim
@ 2022-03-31 13:05 ` Russell King (Oracle)
  2022-03-31 20:16   ` Austin Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King (Oracle) @ 2022-03-31 13:05 UTC (permalink / raw)
  To: Austin Kim; +Cc: arnd, linux-arm-kernel, linux-kernel, austin.kim, p4ranlee

On Thu, Mar 31, 2022 at 12:24:16PM +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
> 
> Add invalid input check expression when 'crashkernel=0' is specified 
> running kdump.
> 
> Signed-off-by: Austin Kim <austin.kim@lge.com>

Thanks, this looks fine. Please send it to the patch system, link
in my signature below. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm: kdump: add invalid input check for 'crashkernel=0'
  2022-03-31 13:05 ` Russell King (Oracle)
@ 2022-03-31 20:16   ` Austin Kim
  0 siblings, 0 replies; 3+ messages in thread
From: Austin Kim @ 2022-03-31 20:16 UTC (permalink / raw)
  To: Russell King (Oracle)
  Cc: Arnd Bergmann, linux-arm-kernel, Linux Kernel Mailing List,
	김동현,
	Paran Lee

2022년 3월 31일 (목) 오후 10:05, Russell King (Oracle) <linux@armlinux.org.uk>님이 작성:
>
> On Thu, Mar 31, 2022 at 12:24:16PM +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@lge.com>
> >
> > Add invalid input check expression when 'crashkernel=0' is specified
> > running kdump.
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
>
> Thanks, this looks fine. Please send it to the patch system, link
> in my signature below. Thanks.

Will send it to the patch
system(https://www.armlinux.org.uk/developer/patches/),
thanks!

BR,
Austin Kim

>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-31 20:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 11:24 [PATCH v2] arm: kdump: add invalid input check for 'crashkernel=0' Austin Kim
2022-03-31 13:05 ` Russell King (Oracle)
2022-03-31 20:16   ` Austin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).