* Re: 5.17.0 boot issue on Miata
[not found] ` <YlAyZdZ6afL58Ege@gherkin.frus.com>
@ 2022-04-19 4:53 ` Bob Tracy
2022-04-25 9:26 ` John Garry
0 siblings, 1 reply; 3+ messages in thread
From: Bob Tracy @ 2022-04-19 4:53 UTC (permalink / raw)
To: debian-alpha; +Cc: Michael Cree, linux-alpha, linux-scsi, linux-kernel
(Adding linux-scsi and linux-kernel, now that bisection is complete.)
On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote:
> v5.17-rc2 ok. v5.17-rc3 I get the disk sector errors and hang that I
> reported in the first message in this thread.
This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller.
Here's the implicated commit:
edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit
commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3
Author: Ming Lei <ming.lei@redhat.com>
Date: Thu Jan 27 23:37:33 2022 +0800
scsi: core: Reallocate device's budget map on queue depth change
We currently use ->cmd_per_lun as initial queue depth for setting up the
budget_map. Martin Wilck reported that it is common for the queue_depth to
be subsequently updated in slave_configure() based on detected hardware
characteristics.
As a result, for some drivers, the static host template settings for
cmd_per_lun and can_queue won't actually get used in practice. And if the
default values are used to allocate the budget_map, memory may be consumed
unnecessarily.
Fix the issue by reallocating the budget_map after ->slave_configure()
returns. At that time the device queue_depth should accurately reflect what
the hardware needs.
Link: https://lore.kernel.org/r/20220127153733.409132-1-ming.lei@redhat.com
Cc: Bart Van Assche <bvanassche@acm.org>
Reported-by: Martin Wilck <martin.wilck@suse.com>
Suggested-by: Martin Wilck <martin.wilck@suse.com>
Tested-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_scan.c | 55 +++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 50 insertions(+), 5 deletions(-)
Respectfully,
--Bob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 5.17.0 boot issue on Miata
2022-04-19 4:53 ` 5.17.0 boot issue on Miata Bob Tracy
@ 2022-04-25 9:26 ` John Garry
2022-05-03 15:50 ` Bob Tracy
0 siblings, 1 reply; 3+ messages in thread
From: John Garry @ 2022-04-25 9:26 UTC (permalink / raw)
To: Bob Tracy, debian-alpha
Cc: Michael Cree, linux-alpha, linux-scsi, linux-kernel
On 19/04/2022 05:53, Bob Tracy wrote:
> (Adding linux-scsi and linux-kernel, now that bisection is complete.)
>
> On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote:
>> v5.17-rc2 ok. v5.17-rc3 I get the disk sector errors and hang that I
>> reported in the first message in this thread.
> This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller.
>
> Here's the implicated commit:
>
> edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit
> commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3
> Author: Ming Lei<ming.lei@redhat.com>
> Date: Thu Jan 27 23:37:33 2022 +0800
>
> scsi: core: Reallocate device's budget map on queue depth change
>
Please try v5.18-rc2 as it should have a fix in commit eaba83b5b850
Thanks,
John
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 5.17.0 boot issue on Miata
2022-04-25 9:26 ` John Garry
@ 2022-05-03 15:50 ` Bob Tracy
0 siblings, 0 replies; 3+ messages in thread
From: Bob Tracy @ 2022-05-03 15:50 UTC (permalink / raw)
To: John Garry
Cc: debian-alpha, Michael Cree, linux-alpha, linux-scsi, linux-kernel
On Mon, Apr 25, 2022 at 10:26:46AM +0100, John Garry wrote:
> Please try v5.18-rc2 as it should have a fix in commit eaba83b5b850
Up and running on v5.18-rc5 as I type this. Fix confirmed. Thanks!
--Bob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-03 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <Yj0u150JJpsb9nj4@gherkin.frus.com>
[not found] ` <20220326222157.GA13650@tower>
[not found] ` <YkuejknyPDJoQEDC@gherkin.frus.com>
[not found] ` <20220405050125.GA25969@tower>
[not found] ` <YkxKRElYUhMgOOCN@gherkin.frus.com>
[not found] ` <10d61d8f-edfc-fc39-0936-233692464dbd@gmx.de>
[not found] ` <Yk4XsdHvjrLqN1LR@gherkin.frus.com>
[not found] ` <YlAyZdZ6afL58Ege@gherkin.frus.com>
2022-04-19 4:53 ` 5.17.0 boot issue on Miata Bob Tracy
2022-04-25 9:26 ` John Garry
2022-05-03 15:50 ` Bob Tracy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).