* [RESEND v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms
@ 2022-03-22 8:31 Sai Teja Aluvala
2022-04-11 21:04 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Sai Teja Aluvala @ 2022-03-22 8:31 UTC (permalink / raw)
To: agross, robh+dt, bjorn.andersson, linux-arm-msm, devicetree,
linux-kernel, marcel, johan.hedberg
Cc: mka, linux-bluetooth, quic_hemantg, quic_bgodavar, quic_rjliao,
mcchou, Sai Teja Aluvala
Add IO regulator handler in SC7280 CRD based platforms.
As IO regulator varies in different SC7280 platforms
updating this handler in individual platform bluetooth node.
Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
---
v3: Updated commit text to reflect the change
v2: updated reviewer comments.
v1: intial patch
---
---
arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
index cd2755c..53ea3b4 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
@@ -23,6 +23,10 @@
};
};
+&bluetooth {
+ vddio-supply = <&vreg_l18b_1p8>;
+};
+
ap_tp_i2c: &i2c0 {
status = "okay";
clock-frequency = <400000>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms
2022-03-22 8:31 [RESEND v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms Sai Teja Aluvala
@ 2022-04-11 21:04 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-04-11 21:04 UTC (permalink / raw)
To: Sai Teja Aluvala
Cc: agross, robh+dt, linux-arm-msm, devicetree, linux-kernel, marcel,
johan.hedberg, mka, linux-bluetooth, quic_hemantg, quic_bgodavar,
quic_rjliao, mcchou
On Tue 22 Mar 03:31 CDT 2022, Sai Teja Aluvala wrote:
> Add IO regulator handler in SC7280 CRD based platforms.
> As IO regulator varies in different SC7280 platforms
> updating this handler in individual platform bluetooth node.
>
To me a significant part of this change is "bluetooth", yet it's not
mentioned until the very end of the commit message.
Please update your $subject to be more to the point and to include
"bluetooth", and please don't repeat $subject as the first line in your
commit message.
Thanks,
Bjorn
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> ---
> v3: Updated commit text to reflect the change
> v2: updated reviewer comments.
> v1: intial patch
> ---
> ---
> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index cd2755c..53ea3b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,10 @@
> };
> };
>
> +&bluetooth {
> + vddio-supply = <&vreg_l18b_1p8>;
> +};
> +
> ap_tp_i2c: &i2c0 {
> status = "okay";
> clock-frequency = <400000>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-11 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 8:31 [RESEND v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms Sai Teja Aluvala
2022-04-11 21:04 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).