From: Alexey Dobriyan <adobriyan@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
Daniel Colascione <dancol@google.com>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] mm/smaps_rollup: return empty file for kthreads instead of ESRCH
Date: Thu, 14 Apr 2022 09:55:36 +0300 [thread overview]
Message-ID: <YlfFaPhNFWNP+1Z7@localhost.localdomain> (raw)
In-Reply-To: <YleToQbgeRalHTwO@casper.infradead.org>
On Thu, Apr 14, 2022 at 04:23:13AM +0100, Matthew Wilcox wrote:
> On Wed, Apr 13, 2022 at 04:06:13PM -0700, Andrew Morton wrote:
> > On Wed, 13 Apr 2022 18:25:53 -0400 "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:
> > > > 258f669e7e88 was 4 years ago, so I guess a -stable backport isn't
> > > > really needed.
> > >
> > > Current behavior (4.19+):
> [...]
> > > Pre-4.19 and post-patch behavior:
> >
> > I don't think this will work very well. smaps_rollup is the sort of
> > system tuning thing for which organizations will develop in-house
> > tooling which never get relesaed externally.
> >
> > > 3. As mentioned previously, this was already the behavior between 4.14
> > > and 4.18 (inclusive).
> > >
> >
> > Yup. Hm, tricky. I'd prefer to leave it alone if possible. How
> > serious a problem is this, really?
>
> I don't think "It's been like this for four years" is as solid an argument
> as you might like. Certain distributions (of the coloured millinery
> variety, for example) haven't updated their kernel since then and so
> there may well be many organisations who have not been exposed to the
> current behaviour. Even my employers distribution, while it offers a
> 5.4 based kernel, still has many customers who have not moved from the
> 4.14 kernel. Inertia is a real thing, and restoring this older behaviour
> might well be an improvement.
Returning ESRCH is better so that programs don't waste time reading and
closing empty files and instantiating useless inodes.
Of course it is different if this patch was sent as response to a regression.
next prev parent reply other threads:[~2022-04-14 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220413211357.26938-1-alex_y_xu.ref@yahoo.ca>
2022-04-13 21:13 ` [PATCH] mm/smaps_rollup: return empty file for kthreads instead of ESRCH Alex Xu (Hello71)
2022-04-13 21:27 ` Andrew Morton
2022-04-13 22:25 ` Alex Xu (Hello71)
2022-04-13 23:06 ` Andrew Morton
2022-04-14 3:23 ` Matthew Wilcox
2022-04-14 6:55 ` Alexey Dobriyan [this message]
2022-04-14 7:38 ` Vlastimil Babka
2022-04-27 20:34 ` Andrew Morton
2022-04-14 15:24 ` Alex Xu (Hello71)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlfFaPhNFWNP+1Z7@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex_y_xu@yahoo.ca \
--cc=dancol@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).