* [PATCH] f2fs: Fix signedness bugs in f2fs_gc_pinned_control functions
@ 2022-04-15 8:49 Jiapeng Chong
2022-04-15 9:33 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2022-04-15 8:49 UTC (permalink / raw)
To: jaegeuk; +Cc: chao, linux-f2fs-devel, linux-kernel, Jiapeng Chong, Abaci Robot
Fix the following smatch warning:
fs/f2fs/gc.c:688 f2fs_gc_pinned_control() warn: signedness bug returning
'(-16)'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 34c097a7821d..4c8ce02a815b 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -679,7 +679,7 @@ static void f2fs_unpin_all_sections(struct f2fs_sb_info *sbi, bool enable)
DIRTY_I(sbi)->enable_pin_section = enable;
}
-static bool f2fs_gc_pinned_control(struct inode *inode, int gc_type,
+static int f2fs_gc_pinned_control(struct inode *inode, int gc_type,
unsigned int segno)
{
if (!f2fs_is_pinned_file(inode))
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: Fix signedness bugs in f2fs_gc_pinned_control functions
2022-04-15 8:49 [PATCH] f2fs: Fix signedness bugs in f2fs_gc_pinned_control functions Jiapeng Chong
@ 2022-04-15 9:33 ` Chao Yu
2022-04-15 20:28 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2022-04-15 9:33 UTC (permalink / raw)
To: Jiapeng Chong, jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Abaci Robot
On 2022/4/15 16:49, Jiapeng Chong wrote:
> Fix the following smatch warning:
>
> fs/f2fs/gc.c:688 f2fs_gc_pinned_control() warn: signedness bug returning
> '(-16)'.
Oops, thanks for catching this...
It's better to merge this patch into original patch, if you don't mind?
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: Fix signedness bugs in f2fs_gc_pinned_control functions
2022-04-15 9:33 ` Chao Yu
@ 2022-04-15 20:28 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2022-04-15 20:28 UTC (permalink / raw)
To: Chao Yu; +Cc: Jiapeng Chong, linux-f2fs-devel, linux-kernel, Abaci Robot
On 04/15, Chao Yu wrote:
> On 2022/4/15 16:49, Jiapeng Chong wrote:
> > Fix the following smatch warning:
> >
> > fs/f2fs/gc.c:688 f2fs_gc_pinned_control() warn: signedness bug returning
> > '(-16)'.
>
> Oops, thanks for catching this...
>
> It's better to merge this patch into original patch, if you don't mind?
Applied.
>
> Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-15 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-15 8:49 [PATCH] f2fs: Fix signedness bugs in f2fs_gc_pinned_control functions Jiapeng Chong
2022-04-15 9:33 ` Chao Yu
2022-04-15 20:28 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).