* [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev_register()
@ 2022-04-21 6:13 Christophe JAILLET
2022-04-21 15:34 ` Dave Jiang
2022-04-22 6:02 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-04-21 6:13 UTC (permalink / raw)
To: Dave Jiang, Vinod Koul
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, dmaengine
If a call to alloc_chrdev_region() fails, the already allocated resources
are leaking.
Add the needed error handling path to fix the leak.
Fixes: 42d279f9137a ("dmaengine: idxd: add char driver to expose submission portal to userland")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/dma/idxd/cdev.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index b9b2b4a4124e..033df43db0ce 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c
@@ -369,10 +369,16 @@ int idxd_cdev_register(void)
rc = alloc_chrdev_region(&ictx[i].devt, 0, MINORMASK,
ictx[i].name);
if (rc)
- return rc;
+ goto err_free_chrdev_region;
}
return 0;
+
+err_free_chrdev_region:
+ for (i--; i >= 0; i--)
+ unregister_chrdev_region(ictx[i].devt, MINORMASK);
+
+ return rc;
}
void idxd_cdev_remove(void)
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev_register()
2022-04-21 6:13 [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev_register() Christophe JAILLET
@ 2022-04-21 15:34 ` Dave Jiang
2022-04-22 6:02 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2022-04-21 15:34 UTC (permalink / raw)
To: Christophe JAILLET, Vinod Koul; +Cc: linux-kernel, kernel-janitors, dmaengine
On 4/20/2022 11:13 PM, Christophe JAILLET wrote:
> If a call to alloc_chrdev_region() fails, the already allocated resources
> are leaking.
>
> Add the needed error handling path to fix the leak.
>
> Fixes: 42d279f9137a ("dmaengine: idxd: add char driver to expose submission portal to userland")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Thanks!
> ---
> drivers/dma/idxd/cdev.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index b9b2b4a4124e..033df43db0ce 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -369,10 +369,16 @@ int idxd_cdev_register(void)
> rc = alloc_chrdev_region(&ictx[i].devt, 0, MINORMASK,
> ictx[i].name);
> if (rc)
> - return rc;
> + goto err_free_chrdev_region;
> }
>
> return 0;
> +
> +err_free_chrdev_region:
> + for (i--; i >= 0; i--)
> + unregister_chrdev_region(ictx[i].devt, MINORMASK);
> +
> + return rc;
> }
>
> void idxd_cdev_remove(void)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev_register()
2022-04-21 6:13 [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev_register() Christophe JAILLET
2022-04-21 15:34 ` Dave Jiang
@ 2022-04-22 6:02 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-04-22 6:02 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: Dave Jiang, linux-kernel, kernel-janitors, dmaengine
On 21-04-22, 08:13, Christophe JAILLET wrote:
> If a call to alloc_chrdev_region() fails, the already allocated resources
> are leaking.
>
> Add the needed error handling path to fix the leak.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-22 6:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 6:13 [PATCH] dmaengine: idxd: Fix the error handling path in idxd_cdev_register() Christophe JAILLET
2022-04-21 15:34 ` Dave Jiang
2022-04-22 6:02 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).