* [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
@ 2022-04-25 13:24 Cixi Geng
2022-04-26 14:44 ` Lee Jones
2022-04-27 7:36 ` Lee Jones
0 siblings, 2 replies; 6+ messages in thread
From: Cixi Geng @ 2022-04-25 13:24 UTC (permalink / raw)
To: lee.jones, orsonzhai, baolin.wang7, zhang.lyra; +Cc: linux-kernel
From: Cixi Geng <cixi.geng1@unisoc.com>
Add the SC2730 PMIC support for module autoloading
through SPI modalises.
Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
---
drivers/mfd/sprd-sc27xx-spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
index 55d2c31bdfb2..cf4f89114ae4 100644
--- a/drivers/mfd/sprd-sc27xx-spi.c
+++ b/drivers/mfd/sprd-sc27xx-spi.c
@@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
static const struct spi_device_id sprd_pmic_spi_ids[] = {
{ .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
+ { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
{},
};
MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
2022-04-25 13:24 [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table Cixi Geng
@ 2022-04-26 14:44 ` Lee Jones
2022-04-27 1:23 ` Cixi Geng
2022-04-27 7:36 ` Lee Jones
1 sibling, 1 reply; 6+ messages in thread
From: Lee Jones @ 2022-04-26 14:44 UTC (permalink / raw)
To: Cixi Geng; +Cc: orsonzhai, baolin.wang7, zhang.lyra, linux-kernel
On Mon, 25 Apr 2022, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Add the SC2730 PMIC support for module autoloading
> through SPI modalises.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
> drivers/mfd/sprd-sc27xx-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 55d2c31bdfb2..cf4f89114ae4 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
>
> static const struct spi_device_id sprd_pmic_spi_ids[] = {
> { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> + { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
Nicer if these were ordered with the smallest number at the top.
> {},
> };
> MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
2022-04-26 14:44 ` Lee Jones
@ 2022-04-27 1:23 ` Cixi Geng
2022-04-27 7:37 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Cixi Geng @ 2022-04-27 1:23 UTC (permalink / raw)
To: Lee Jones; +Cc: Orson Zhai, baolin.wang7, Chunyan Zhang, linux-kernel
Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道：
>
> On Mon, 25 Apr 2022, Cixi Geng wrote:
>
> > From: Cixi Geng <cixi.geng1@unisoc.com>
> >
> > Add the SC2730 PMIC support for module autoloading
> > through SPI modalises.
> >
> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > ---
> > drivers/mfd/sprd-sc27xx-spi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> > index 55d2c31bdfb2..cf4f89114ae4 100644
> > --- a/drivers/mfd/sprd-sc27xx-spi.c
> > +++ b/drivers/mfd/sprd-sc27xx-spi.c
> > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
> >
> > static const struct spi_device_id sprd_pmic_spi_ids[] = {
> > { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> > + { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
>
> Nicer if these were ordered with the smallest number at the top.
I followed the order of struct of_device_id sprd_pmic_match[1],Do I need
adjust it as well?
[1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242
>
> > {},
> > };
> > MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
2022-04-25 13:24 [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table Cixi Geng
2022-04-26 14:44 ` Lee Jones
@ 2022-04-27 7:36 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2022-04-27 7:36 UTC (permalink / raw)
To: Cixi Geng; +Cc: orsonzhai, baolin.wang7, zhang.lyra, linux-kernel
On Mon, 25 Apr 2022, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Add the SC2730 PMIC support for module autoloading
> through SPI modalises.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
> drivers/mfd/sprd-sc27xx-spi.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
2022-04-27 1:23 ` Cixi Geng
@ 2022-04-27 7:37 ` Lee Jones
2022-04-27 7:53 ` Cixi Geng
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2022-04-27 7:37 UTC (permalink / raw)
To: Cixi Geng; +Cc: Orson Zhai, baolin.wang7, Chunyan Zhang, linux-kernel
On Wed, 27 Apr 2022, Cixi Geng wrote:
> Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道：
> >
> > On Mon, 25 Apr 2022, Cixi Geng wrote:
> >
> > > From: Cixi Geng <cixi.geng1@unisoc.com>
> > >
> > > Add the SC2730 PMIC support for module autoloading
> > > through SPI modalises.
> > >
> > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > > ---
> > > drivers/mfd/sprd-sc27xx-spi.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> > > index 55d2c31bdfb2..cf4f89114ae4 100644
> > > --- a/drivers/mfd/sprd-sc27xx-spi.c
> > > +++ b/drivers/mfd/sprd-sc27xx-spi.c
> > > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
> > >
> > > static const struct spi_device_id sprd_pmic_spi_ids[] = {
> > > { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> > > + { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
> >
> > Nicer if these were ordered with the smallest number at the top.
> I followed the order of struct of_device_id sprd_pmic_match[1],Do I need
> adjust it as well?
> [1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242
I've applied this patch for now.
Could you please submit a follow-up changing both?
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
2022-04-27 7:37 ` Lee Jones
@ 2022-04-27 7:53 ` Cixi Geng
0 siblings, 0 replies; 6+ messages in thread
From: Cixi Geng @ 2022-04-27 7:53 UTC (permalink / raw)
To: Lee Jones; +Cc: Orson Zhai, baolin.wang7, Chunyan Zhang, linux-kernel
Lee Jones <lee.jones@linaro.org> 于2022年4月27日周三 15:37写道：
>
> On Wed, 27 Apr 2022, Cixi Geng wrote:
>
> > Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道：
> > >
> > > On Mon, 25 Apr 2022, Cixi Geng wrote:
> > >
> > > > From: Cixi Geng <cixi.geng1@unisoc.com>
> > > >
> > > > Add the SC2730 PMIC support for module autoloading
> > > > through SPI modalises.
> > > >
> > > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > > > ---
> > > > drivers/mfd/sprd-sc27xx-spi.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> > > > index 55d2c31bdfb2..cf4f89114ae4 100644
> > > > --- a/drivers/mfd/sprd-sc27xx-spi.c
> > > > +++ b/drivers/mfd/sprd-sc27xx-spi.c
> > > > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
> > > >
> > > > static const struct spi_device_id sprd_pmic_spi_ids[] = {
> > > > { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> > > > + { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
> > >
> > > Nicer if these were ordered with the smallest number at the top.
> > I followed the order of struct of_device_id sprd_pmic_match[1],Do I need
> > adjust it as well?
> > [1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242
>
> I've applied this patch for now.
>
> Could you please submit a follow-up changing both?
Thanks, a new patch to change the order send.
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-27 7:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 13:24 [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table Cixi Geng
2022-04-26 14:44 ` Lee Jones
2022-04-27 1:23 ` Cixi Geng
2022-04-27 7:37 ` Lee Jones
2022-04-27 7:53 ` Cixi Geng
2022-04-27 7:36 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).