From: Minchan Kim <minchan@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Roman Gushchin <guro@fb.com>,
Shakeel Butt <shakeelb@google.com>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage
Date: Wed, 27 Apr 2022 15:16:48 -0700 [thread overview]
Message-ID: <YmnA0Da90IURbxrM@google.com> (raw)
In-Reply-To: <YmmznQ8AO5RLxicA@cmpxchg.org>
On Wed, Apr 27, 2022 at 05:20:29PM -0400, Johannes Weiner wrote:
> On Wed, Apr 27, 2022 at 01:29:34PM -0700, Minchan Kim wrote:
> > Hi Johannes,
> >
> > On Wed, Apr 27, 2022 at 12:00:15PM -0400, Johannes Weiner wrote:
> > > Currently it requires poking at debugfs to figure out the size and
> > > population of the zswap cache on a host. There are no counters for
> > > reads and writes against the cache. As a result, it's difficult to
> > > understand zswap behavior on production systems.
> > >
> > > Print zswap memory consumption and how many pages are zswapped out in
> > > /proc/meminfo. Count zswapouts and zswapins in /proc/vmstat.
> > >
> > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > > ---
> > > fs/proc/meminfo.c | 7 +++++++
> > > include/linux/swap.h | 5 +++++
> > > include/linux/vm_event_item.h | 4 ++++
> > > mm/vmstat.c | 4 ++++
> > > mm/zswap.c | 13 ++++++-------
> > > 5 files changed, 26 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
> > > index 6fa761c9cc78..6e89f0e2fd20 100644
> > > --- a/fs/proc/meminfo.c
> > > +++ b/fs/proc/meminfo.c
> > > @@ -86,6 +86,13 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
> > >
> > > show_val_kb(m, "SwapTotal: ", i.totalswap);
> > > show_val_kb(m, "SwapFree: ", i.freeswap);
> > > +#ifdef CONFIG_ZSWAP
> > > + seq_printf(m, "Zswap: %8lu kB\n",
> > > + (unsigned long)(zswap_pool_total_size >> 10));
> > > + seq_printf(m, "Zswapped: %8lu kB\n",
> > > + (unsigned long)atomic_read(&zswap_stored_pages) <<
> > > + (PAGE_SHIFT - 10));
> > > +#endif
> >
> > I agree it would be very handy to have the memory consumption in meminfo
> >
> > https://lore.kernel.org/all/YYwZXrL3Fu8%2FvLZw@google.com/
> >
> > If we really go this Zswap only metric instead of general term
> > "Compressed", I'd like to post maybe "Zram:" with same reason
> > in this patchset. Do you think that's better idea instead of
> > introducing general term like "Compressed:" or something else?
>
> I'm fine with changing it to Compressed. If somebody cares about a
> more detailed breakdown, we can add Zswap, Zram subsets as needed.
Thanks! Please consider ZSWPIN to rename more general term, too.
>
> From 8e9e2d6490b7082c41743fbdb9ffd2db4e3ce962 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Wed, 27 Apr 2022 17:15:15 -0400
> Subject: [PATCH] mm: zswap: add basic meminfo and vmstat coverage fix fix
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> Documentation/filesystems/proc.rst | 7 ++++---
> fs/proc/meminfo.c | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 8b5a94cfa722..93edcf233464 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -964,7 +964,7 @@ Example output. You may not have all of these fields.
> Mlocked: 0 kB
> SwapTotal: 0 kB
> SwapFree: 0 kB
> - Zswap: 1904 kB
> + Compressed: 1904 kB
> Zswapped: 7792 kB
> Dirty: 12 kB
> Writeback: 0 kB
> @@ -1057,8 +1057,9 @@ SwapTotal
> SwapFree
> Memory which has been evicted from RAM, and is temporarily
> on the disk
> -Zswap
> - Memory consumed by the zswap backend (compressed size)
> +Compressed
> + Memory consumed by compression backends, such as zswap
> + (compressed size)
> Zswapped
> Amount of anonymous memory stored in zswap (original size)
> Dirty
> diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
> index 6e89f0e2fd20..554d6f230e67 100644
> --- a/fs/proc/meminfo.c
> +++ b/fs/proc/meminfo.c
> @@ -87,7 +87,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
> show_val_kb(m, "SwapTotal: ", i.totalswap);
> show_val_kb(m, "SwapFree: ", i.freeswap);
> #ifdef CONFIG_ZSWAP
> - seq_printf(m, "Zswap: %8lu kB\n",
> + seq_printf(m, "Compressed: %8lu kB\n",
> (unsigned long)(zswap_pool_total_size >> 10));
> seq_printf(m, "Zswapped: %8lu kB\n",
> (unsigned long)atomic_read(&zswap_stored_pages) <<
> --
> 2.35.3
>
next prev parent reply other threads:[~2022-04-27 22:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 16:00 [PATCH 0/5] zswap: cgroup accounting & control Johannes Weiner
2022-04-27 16:00 ` [PATCH 1/5] mm: Kconfig: move swap and slab config options to the MM section Johannes Weiner
2022-04-27 16:00 ` [PATCH 2/5] mm: Kconfig: group swap, slab, hotplug and thp options into submenus Johannes Weiner
2022-04-27 16:00 ` [PATCH 3/5] mm: Kconfig: simplify zswap configuration Johannes Weiner
2022-04-27 16:00 ` [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Johannes Weiner
2022-04-27 18:36 ` Andrew Morton
2022-04-27 18:53 ` Johannes Weiner
2022-04-27 19:50 ` Johannes Weiner
2022-04-27 19:51 ` Johannes Weiner
2022-04-27 20:29 ` Minchan Kim
2022-04-27 21:20 ` Johannes Weiner
2022-04-27 21:36 ` Johannes Weiner
2022-04-27 22:12 ` Minchan Kim
2022-04-28 14:05 ` Johannes Weiner
2022-04-28 17:02 ` Minchan Kim
2022-04-28 17:27 ` Johannes Weiner
2022-04-27 23:36 ` Shakeel Butt
2022-04-28 14:36 ` Johannes Weiner
2022-04-28 14:49 ` Shakeel Butt
2022-04-28 15:16 ` Johannes Weiner
2022-04-28 16:59 ` Yang Shi
2022-05-05 19:30 ` Shakeel Butt
2022-04-28 16:54 ` Yang Shi
2022-05-05 19:33 ` Shakeel Butt
2022-05-05 22:24 ` Suleiman Souhlal
2022-05-05 23:54 ` Yu Zhao
2022-04-27 22:16 ` Minchan Kim [this message]
2022-04-28 14:25 ` Johannes Weiner
2022-04-28 16:59 ` Minchan Kim
2022-04-28 17:23 ` Johannes Weiner
2022-04-28 17:31 ` Minchan Kim
2022-04-28 18:34 ` Johannes Weiner
2022-04-28 19:58 ` Minchan Kim
2022-04-27 16:00 ` [PATCH 5/5] zswap: memcg accounting Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmnA0Da90IURbxrM@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=ddstreet@ieee.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
--cc=sjenning@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).