* [PATCH] input: evdev: fixed case statements
@ 2022-04-01 21:58 Paul Lemmermann
2022-05-12 21:30 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Paul Lemmermann @ 2022-04-01 21:58 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Paul Lemmermann
Fixed case statements which have more than one operation on a single
line. Found using checkpatch.pl.
Signed-off-by: Paul Lemmermann <thepaulodoom@thepaulodoom.com>
---
drivers/input/evdev.c | 48 ++++++++++++++++++++++++++++++++++---------
1 file changed, 38 insertions(+), 10 deletions(-)
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 95f90699d..85c92b30d 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -784,16 +784,44 @@ static int handle_eviocgbit(struct input_dev *dev,
switch (type) {
- case 0: bits = dev->evbit; len = EV_MAX; break;
- case EV_KEY: bits = dev->keybit; len = KEY_MAX; break;
- case EV_REL: bits = dev->relbit; len = REL_MAX; break;
- case EV_ABS: bits = dev->absbit; len = ABS_MAX; break;
- case EV_MSC: bits = dev->mscbit; len = MSC_MAX; break;
- case EV_LED: bits = dev->ledbit; len = LED_MAX; break;
- case EV_SND: bits = dev->sndbit; len = SND_MAX; break;
- case EV_FF: bits = dev->ffbit; len = FF_MAX; break;
- case EV_SW: bits = dev->swbit; len = SW_MAX; break;
- default: return -EINVAL;
+ case 0:
+ bits = dev->evbit;
+ len = EV_MAX;
+ break;
+ case EV_KEY:
+ bits = dev->keybit;
+ len = KEY_MAX;
+ break;
+ case EV_REL:
+ bits = dev->relbit;
+ len = REL_MAX;
+ break;
+ case EV_ABS:
+ bits = dev->absbit;
+ len = ABS_MAX;
+ break;
+ case EV_MSC:
+ bits = dev->mscbit;
+ len = MSC_MAX;
+ break;
+ case EV_LED:
+ bits = dev->ledbit;
+ len = LED_MAX;
+ break;
+ case EV_SND:
+ bits = dev->sndbit;
+ len = SND_MAX;
+ break;
+ case EV_FF:
+ bits = dev->ffbit;
+ len = FF_MAX;
+ break;
+ case EV_SW:
+ bits = dev->swbit;
+ len = SW_MAX;
+ break;
+ default:
+ return -EINVAL;
}
return bits_to_user(bits, len, size, p, compat_mode);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: evdev: fixed case statements
2022-04-01 21:58 [PATCH] input: evdev: fixed case statements Paul Lemmermann
@ 2022-05-12 21:30 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2022-05-12 21:30 UTC (permalink / raw)
To: Paul Lemmermann; +Cc: linux-input, linux-kernel
Hi Paul,
On Fri, Apr 01, 2022 at 04:58:42PM -0500, Paul Lemmermann wrote:
> Fixed case statements which have more than one operation on a single
> line. Found using checkpatch.pl.
While checkpatch.pl is often a useful tool, in this case the original
code presents the information in a condensed but understandable way. I
do not see a reason to change it just to appease a tool.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-12 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 21:58 [PATCH] input: evdev: fixed case statements Paul Lemmermann
2022-05-12 21:30 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).