From: Sebastian Ene <sebastianene@google.com>
To: Sebastian Ene <sebastianene@google.com>
Cc: linux-kernel@vger.kernel.org,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, qperret@google.com, will@kernel.org,
maz@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v4 1/2] dt-bindings: vm-wdt: Add qemu,vm-watchdog compatible
Date: Sat, 7 May 2022 08:16:14 +0000 [thread overview]
Message-ID: <YnYqzkK0JLlCYOw5@google.com> (raw)
In-Reply-To: <20220429083030.3241640-2-sebastianene@google.com>
On Fri, Apr 29, 2022 at 08:30:31AM +0000, Sebastian Ene wrote:
> The stall detection mechanism allows to configure the expiration
> duration and the internal counter clock frequency measured in Hz.
> Add these properties in the schema.
>
> Signed-off-by: Sebastian Ene <sebastianene@google.com>
> ---
> .../devicetree/bindings/misc/vm-watchdog.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/vm-watchdog.yaml
>
> diff --git a/Documentation/devicetree/bindings/misc/vm-watchdog.yaml b/Documentation/devicetree/bindings/misc/vm-watchdog.yaml
> new file mode 100644
> index 000000000000..d7cca23357ab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/vm-watchdog.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/vm-watchdog.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VM watchdog
> +
> +description: |
> + This binding describes a CPU stall detector mechanism for virtual cpus
> + which is accessed through MMIO.
> +
> +maintainers:
> + - Sebastian Ene <sebastianene@google.com>
> +
> +properties:
> + compatible:
> + enum:
> + - qemu,vm-watchdog
> + clock-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The watchdog internal clock measure in Hz used to decrement the
> + watchdog counter register on each tick.
> + Defaults to 10 if unset.
> + timeout-sec:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The watchdog expiration timeout measured in seconds.
> + Defaults to 8 if unset.
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
Hi,
> +
> +examples:
> + - |
> + watchdog {
> + compatible = "qemu,vm-watchdog";
> + clock-frequency = <10>;
> + timeout-sec = <8>;
> + };
> +
> +...
> --
> 2.36.0.464.gb9c8b46e94-goog
>
I was thinking to move the properties clock-frequency and timeout-sec as
part of the emulated watchdog registers and keep only the registers
property in the DT.
Thanks,
Seb
next prev parent reply other threads:[~2022-05-07 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:30 [PATCH v4 0/2] Detect stalls on guest vCPUS Sebastian Ene
2022-04-29 8:30 ` [PATCH v4 1/2] dt-bindings: vm-wdt: Add qemu,vm-watchdog compatible Sebastian Ene
2022-04-29 15:53 ` Rob Herring
2022-05-07 8:16 ` Sebastian Ene [this message]
2022-04-29 8:30 ` [PATCH v4 2/2] misc: Add a mechanism to detect stalls on guest vCPUs Sebastian Ene
2022-04-29 8:48 ` Greg Kroah-Hartman
2022-04-29 16:51 ` Guenter Roeck
2022-04-30 6:18 ` Greg Kroah-Hartman
2022-04-30 12:36 ` Guenter Roeck
2022-05-02 5:58 ` Sebastian Ene
2022-04-29 8:51 ` Greg Kroah-Hartman
2022-04-29 9:26 ` Sebastian Ene
2022-04-29 9:38 ` Greg Kroah-Hartman
2022-04-29 21:03 ` Rob Herring
2022-05-04 7:29 ` Sebastian Ene
2022-04-29 17:02 ` Guenter Roeck
2022-04-29 20:25 ` [PATCH v4 0/2] Detect stalls on guest vCPUS Rob Herring
2022-05-02 6:03 ` Sebastian Ene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnYqzkK0JLlCYOw5@google.com \
--to=sebastianene@google.com \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=qperret@google.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).