From: Sebastian Ene <sebastianene@google.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, qperret@google.com, will@kernel.org,
maz@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v4 0/2] Detect stalls on guest vCPUS
Date: Mon, 2 May 2022 06:03:37 +0000 [thread overview]
Message-ID: <Ym90OaUsWW6hjjo9@google.com> (raw)
In-Reply-To: <YmxJyUqdsZmm8yE2@robh.at.kernel.org>
On Fri, Apr 29, 2022 at 03:25:45PM -0500, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 08:30:29AM +0000, Sebastian Ene wrote:
> > This adds a mechanism to detect stalls on the guest vCPUS by creating a
> > per CPU hrtimer which periodically 'pets' the host backend driver.
> > On a conventional watchdog-core driver, the userspace is responsible for
> > delivering the 'pet' events by writing to the particular /dev/watchdogN node.
> > In this case we require a strong thread affinity to be able to
> > account for lost time on a per vCPU basis.
> >
> > This device driver acts as a soft lockup detector by relying on the host
> > backend driver to measure the elapesed time between subsequent 'pet' events.
> > If the elapsed time doesn't match an expected value, the backend driver
> > decides that the guest vCPU is locked and resets the guest. The host
> > backend driver takes into account the time that the guest is not
> > running. The communication with the backend driver is done through MMIO
> > and the register layout of the virtual watchdog is described as part of
> > the backend driver changes.
> >
> > The host backend driver is implemented as part of:
> > https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3548817
> >
> > Changelog v4:
> > - rename the source from vm-wdt.c -> vm-watchdog.c
> > - convert all the error logging calls from pr_* to dev_* calls
> > - rename the DTS node "clock" to "clock-frequency"
Hi,
>
> Why do I have a v4 now when the discussion on v3 is not concluded. Give
> folks some time to respond. We're busy drinking from the firehose.
>
I am trying to address the issues incrementlly keeping a week cadence.
Any feedback on this is welcomed.
Thanks,
Seb
> Rob
prev parent reply other threads:[~2022-05-02 6:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:30 [PATCH v4 0/2] Detect stalls on guest vCPUS Sebastian Ene
2022-04-29 8:30 ` [PATCH v4 1/2] dt-bindings: vm-wdt: Add qemu,vm-watchdog compatible Sebastian Ene
2022-04-29 15:53 ` Rob Herring
2022-05-07 8:16 ` Sebastian Ene
2022-04-29 8:30 ` [PATCH v4 2/2] misc: Add a mechanism to detect stalls on guest vCPUs Sebastian Ene
2022-04-29 8:48 ` Greg Kroah-Hartman
2022-04-29 16:51 ` Guenter Roeck
2022-04-30 6:18 ` Greg Kroah-Hartman
2022-04-30 12:36 ` Guenter Roeck
2022-05-02 5:58 ` Sebastian Ene
2022-04-29 8:51 ` Greg Kroah-Hartman
2022-04-29 9:26 ` Sebastian Ene
2022-04-29 9:38 ` Greg Kroah-Hartman
2022-04-29 21:03 ` Rob Herring
2022-05-04 7:29 ` Sebastian Ene
2022-04-29 17:02 ` Guenter Roeck
2022-04-29 20:25 ` [PATCH v4 0/2] Detect stalls on guest vCPUS Rob Herring
2022-05-02 6:03 ` Sebastian Ene [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym90OaUsWW6hjjo9@google.com \
--to=sebastianene@google.com \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=qperret@google.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).