[PATCH] slub: kunit catch kmem_cache_alloc failed

* [PATCH] slub: kunit catch kmem_cache_alloc failed
@ 2022-05-06  4:53 Paran Lee
  2022-05-06 11:45 ` kernel test robot
  2022-05-09 11:20 ` Hyeonggon Yoo
  0 siblings, 2 replies; 3+ messages in thread
From: Paran Lee @ 2022-05-06  4:53 UTC (permalink / raw)
  To: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Andrew Morton, Vlastimil Babka, Roman Gushchin
  Cc: linux-kernel, linux-mm, Oliver Glitta, Austin Kim

Catch kmem_cache_alloc failed on slub kunit test.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 lib/slub_kunit.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c
index 8662dc6cb509..7b80241dd498 100644
--- a/lib/slub_kunit.c
+++ b/lib/slub_kunit.c
@@ -32,6 +32,11 @@ static void test_next_pointer(struct kunit *test)
 	struct kmem_cache *s = kmem_cache_create("TestSlub_next_ptr_free", 64, 0,
 				SLAB_POISON, NULL);
 	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
+	if (!p) {
+		kunit_err(test, "Allocation failed: %s\n", __func__);
+		kmem_cache_destroy(s);
+		return;
+	}
 	unsigned long tmp;
 	unsigned long *ptr_addr;
 
@@ -77,6 +82,11 @@ static void test_first_word(struct kunit *test)
 	struct kmem_cache *s = kmem_cache_create("TestSlub_1th_word_free", 64, 0,
 				SLAB_POISON, NULL);
 	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
+	if (!p) {
+		kunit_err(test, "Allocation failed: %s\n", __func__);
+		kmem_cache_destroy(s);
+		return;
+	}
 
 	kmem_cache_free(s, p);
 	*p = 0x78;
@@ -92,6 +102,11 @@ static void test_clobber_50th_byte(struct kunit *test)
 	struct kmem_cache *s = kmem_cache_create("TestSlub_50th_word_free", 64, 0,
 				SLAB_POISON, NULL);
 	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
+	if (!p) {
+		kunit_err(test, "Allocation failed: %s\n", __func__);
+		kmem_cache_destroy(s);
+		return;
+	}
 
 	kmem_cache_free(s, p);
 	p[50] = 0x9a;
@@ -108,6 +123,11 @@ static void test_clobber_redzone_free(struct kunit *test)
 	struct kmem_cache *s = kmem_cache_create("TestSlub_RZ_free", 64, 0,
 				SLAB_RED_ZONE, NULL);
 	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
+	if (!p) {
+		kunit_err(test, "Allocation failed: %s\n", __func__);
+		kmem_cache_destroy(s);
+		return;
+	}
 
 	kasan_disable_current();
 	kmem_cache_free(s, p);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread