From: Petr Mladek <pmladek@suse.com>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Jarkko Sakkinen <jarkko@kernel.org>, Gary Guo <gary@garyguo.net>,
Alex Gaynor <alex.gaynor@gmail.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v6 14/23] vsprintf: add new `%pA` format specifier
Date: Tue, 10 May 2022 10:38:35 +0200 [thread overview]
Message-ID: <Ynoki5rA2ivmFwkS@alley> (raw)
In-Reply-To: <20220507052451.12890-15-ojeda@kernel.org>
On Sat 2022-05-07 07:24:12, Miguel Ojeda wrote:
> From: Gary Guo <gary@garyguo.net>
>
> This patch adds a format specifier `%pA` to `vsprintf` which formats
> a pointer as `core::fmt::Arguments`. Doing so allows us to directly
> format to the internal buffer of `printf`, so we do not have to use
> a temporary buffer on the stack to pre-assemble the message on
> the Rust side.
>
> This specifier is intended only to be used from Rust and not for C, so
> `checkpatch.pl` is intentionally unchanged to catch any misuse.
>
> Co-developed-by: Alex Gaynor <alex.gaynor@gmail.com>
> Signed-off-by: Alex Gaynor <alex.gaynor@gmail.com>
> Co-developed-by: Wedson Almeida Filho <wedsonaf@google.com>
> Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> Co-developed-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Feel free to use:
Acked-by: Petr Mladek <pmladek@suse.com>
See a comment below.
> ---
> lib/vsprintf.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 40d26a07a133..00f71f91d991 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -2270,6 +2270,9 @@ int __init no_hash_pointers_enable(char *str)
> }
> early_param("no_hash_pointers", no_hash_pointers_enable);
>
> +/* Used for Rust formatting ('%pA'). */
> +char *rust_fmt_argument(char *buf, char *end, void *ptr);
> +
> /*
> * Show a '%p' thing. A kernel extension is that the '%p' is followed
> * by an extra set of alphanumeric characters that are extended format
> @@ -2396,6 +2399,10 @@ early_param("no_hash_pointers", no_hash_pointers_enable);
> *
> * Note: The default behaviour (unadorned %p) is to hash the address,
> * rendering it useful as a unique identifier.
> + *
> + * There is also a '%pA' format specifier, but it is only intended to be used
> + * from Rust code to format core::fmt::Arguments. Do *not* use it from C.
> + * See rust/kernel/print.rs for details.
> */
It would be great to document it also in
Documentation/core-api/printk-formats.rst
I am sorry that I did not mentioned it earlier.
Also the check in checkpatch.pl, mentioned in another reply, sounds
like a good idea.
Best Regards,
Petr
next prev parent reply other threads:[~2022-05-10 8:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 5:23 [PATCH v6 00/23] Rust support Miguel Ojeda
2022-05-07 5:23 ` [PATCH v6 01/23] kallsyms: avoid hardcoding the buffer size Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 02/23] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 03/23] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 04/23] kunit: take `kunit_assert` as `const` Miguel Ojeda
2022-05-12 19:01 ` Brendan Higgins
2022-05-07 5:24 ` [PATCH v6 05/23] rust: add C helpers Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 06/23] rust: add `compiler_builtins` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 07/23] rust: import upstream `alloc` crate Miguel Ojeda
2022-05-07 9:23 ` Kees Cook
2022-05-07 9:33 ` Miguel Ojeda
2022-05-07 17:06 ` Kees Cook
2022-05-07 17:30 ` Linus Torvalds
2022-05-07 19:34 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 08/23] rust: adapt `alloc` crate to the kernel Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 09/23] rust: add `build_error` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 10/23] rust: add `macros` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 11/23] rust: add `kernel` crate's `sync` module Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 12/23] rust: add `kernel` crate Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 13/23] rust: export generated symbols Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 14/23] vsprintf: add new `%pA` format specifier Miguel Ojeda
2022-05-07 8:19 ` Kees Cook
2022-05-07 9:35 ` Miguel Ojeda
2022-05-10 8:38 ` Petr Mladek [this message]
2022-05-10 10:45 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 15/23] scripts: add `rustdoc_test_{builder,gen}.py` scripts Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 16/23] scripts: add `generate_rust_analyzer.py` scripts Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 17/23] scripts: decode_stacktrace: demangle Rust symbols Miguel Ojeda
2022-05-07 8:32 ` Kees Cook
2022-05-07 10:21 ` Miguel Ojeda
2022-05-07 17:09 ` Kees Cook
2022-05-07 5:24 ` [PATCH v6 18/23] docs: add Rust documentation Miguel Ojeda
2022-05-07 8:15 ` Kees Cook
2022-05-07 8:45 ` Miguel Ojeda
2022-05-09 4:02 ` Akira Yokosawa
2022-05-09 10:41 ` Miguel Ojeda
2022-05-09 14:56 ` Akira Yokosawa
2022-05-09 22:37 ` Jonathan Corbet
2022-05-10 11:57 ` Miguel Ojeda
2022-05-09 22:32 ` Jonathan Corbet
2022-05-10 3:14 ` Gaelan Steele
2022-05-10 5:53 ` Josh Triplett
2022-05-11 13:49 ` Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 19/23] Kbuild: add Rust support Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 20/23] samples: add Rust examples Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 21/23] MAINTAINERS: Rust Miguel Ojeda
2022-05-07 8:06 ` Kees Cook
2022-05-07 5:24 ` [PATCH v6 22/23] [RFC] drivers: gpio: PrimeCell PL061 in Rust Miguel Ojeda
2022-05-07 5:24 ` [PATCH v6 23/23] [RFC] drivers: android: Binder IPC " Miguel Ojeda
2022-05-07 7:55 ` Kees Cook
2022-05-07 8:13 ` Greg Kroah-Hartman
2022-05-09 17:52 ` Todd Kjos
2022-05-07 8:06 ` [PATCH v6 00/23] Rust support Kees Cook
2022-05-08 18:06 ` Matthew Wilcox
2022-05-09 9:39 ` Wei Liu
2022-05-07 9:29 ` David Gow
2022-05-07 15:03 ` Miguel Ojeda
2022-05-10 4:44 ` David Gow
2022-05-10 11:36 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynoki5rA2ivmFwkS@alley \
--to=pmladek@suse.com \
--cc=alex.gaynor@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ojeda@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).