From: Alan Stern <stern@rowland.harvard.edu>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: ohci-at91: add support to enter suspend using SMC
Date: Tue, 7 Jun 2022 09:22:08 -0400 [thread overview]
Message-ID: <Yp9RAEa1D21lPiqa@rowland.harvard.edu> (raw)
In-Reply-To: <20220607090759.3fc0b003@fixe.home>
On Tue, Jun 07, 2022 at 09:07:59AM +0200, Clément Léger wrote:
> Le Mon, 6 Jun 2022 14:12:52 -0400,
> Alan Stern <stern@rowland.harvard.edu> a écrit :
>
> > On Mon, Jun 06, 2022 at 04:18:02PM +0200, Clément Léger wrote:
> > > When Linux is running under OP-TEE, the SFR is set as secured and thus
> > > the AT91_OHCIICR_USB_SUSPEND register isn't accessible. Add a SMC to
> > > do the appropriate call to suspend the controller.
> > > The SMC id is fetched from the device-tree property
> > > "microchip,suspend-smc-id". if present, then the syscon regmap is not
> > > used to enter suspend and a SMC is issued.
> > >
> > > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> > > ---
> >
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> >
> > However, this is a little weird... You've written
> > usb_hcd_at91_probe() so that the SMC is detected in preference to the
> > regmap, but then you wrote ohci_at91_port_suspend() so that the regmap
> > is used in preference to the SMC. It's not wrong, but it is confusing
> > to read.
> >
> > Do you want to rewrite the patch to make the two routines agree on which
> > mechanism to use by default?
> >
> > Alan Stern
>
> Hi Alan,
>
> I'll rewrite that ! I did it in this specific order in the probe to
> allow overloading the device-tree with a SMC ID without removing the
> syscon property. This way, the regmap stays the default if no
> "microchip,suspend-smc-id" property is provided.
>
> Does it sounds good to you ?
Sure. Just make ohci_at91_port_suspend() try to use the SMC first, and
then use the regmap only if the SMC ID hasn't been set.
Alan Stern
prev parent reply other threads:[~2022-06-07 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 14:18 [PATCH] usb: host: ohci-at91: add support to enter suspend using SMC Clément Léger
2022-06-06 18:12 ` Alan Stern
2022-06-07 7:07 ` Clément Léger
2022-06-07 13:22 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp9RAEa1D21lPiqa@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=clement.leger@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).