mainline build failure due to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

mainline build failure due to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

[Sudip Mukherjee]

Hi All,

The latest mainline kernel branch fails to build for "mips loongson2k_defconfig"
with the error:

drivers/irqchip/irq-loongson-liointc.c: In function 'liointc_chained_handle_irq':
drivers/irqchip/irq-loongson-liointc.c:60:20: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
   60 |         int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;


git bisect pointed to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

And, reverting it on top of mainline branch has fixed the build failure.

--
Regards
Sudip

Re: mainline build failure due to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

[Jiaxun Yang]

在 2022/6/4 11:34, Sudip Mukherjee 写道:
> Hi All,
>
> The latest mainline kernel branch fails to build for "mips loongson2k_defconfig"
> with the error:
>
> drivers/irqchip/irq-loongson-liointc.c: In function 'liointc_chained_handle_irq':
> drivers/irqchip/irq-loongson-liointc.c:60:20: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
>     60 |         int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;
>
>
> git bisect pointed to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")
>
> And, reverting it on top of mainline branch has fixed the build failure.
Thanks for the reminder.
I'll prepare a patch for it.

Thanks
- Jiaxun

>
> --
> Regards
> Sudip

Re: mainline build failure due to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

[Huacai Chen]

Hi, Sudip,

On Sat, Jun 4, 2022 at 8:38 PM Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> Hi All,
>
> The latest mainline kernel branch fails to build for "mips loongson2k_defconfig"
> with the error:
>
> drivers/irqchip/irq-loongson-liointc.c: In function 'liointc_chained_handle_irq':
> drivers/irqchip/irq-loongson-liointc.c:60:20: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
>    60 |         int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;
>
>
> git bisect pointed to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")
>
> And, reverting it on top of mainline branch has fixed the build failure.
Jiaxun has already sent a patch to fix it.

Huacai
>
> --
> Regards
> Sudip