From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic
Date: Mon, 13 Jun 2022 00:16:40 +0200 [thread overview]
Message-ID: <YqZlyBH349VIdQDI@oden.dyn.berto.se> (raw)
In-Reply-To: <20220610201701.7946-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
Thanks for your patch.
On 2022-06-10 22:17:00 +0200, Wolfram Sang wrote:
> When handling the V3U/r8a779a0 exception, avoid using 'not:' because
> then its subschemas are far away in the 'else:' branch. Keep them
> together using positive logic.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>
> Changes since v2:
> * new patch
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 1368d90da0e8..72dc7eb27f8d 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -57,31 +57,30 @@ required:
> - "#thermal-sensor-cells"
>
> if:
> - not:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,r8a779a0-thermal
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779a0-thermal
> then:
> properties:
> reg:
> - minItems: 2
> items:
> + - description: TSC0 registers
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + - description: TSC4 registers
> else:
> properties:
> reg:
> + minItems: 2
> items:
> - - description: TSC0 registers
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - - description: TSC4 registers
> + required:
> + - interrupts
>
> additionalProperties: false
>
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2022-06-12 22:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 20:17 [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Wolfram Sang
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
2022-06-12 22:18 ` Niklas Söderlund
2022-06-14 13:54 ` Geert Uytterhoeven
2022-06-14 19:12 ` Wolfram Sang
2022-06-14 20:18 ` Wolfram Sang
2022-06-14 21:31 ` Geert Uytterhoeven
2022-06-15 10:09 ` Wolfram Sang
2022-06-14 20:07 ` Rob Herring
2022-06-12 22:16 ` Niklas Söderlund [this message]
2022-06-14 13:46 ` [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Geert Uytterhoeven
2022-06-14 19:08 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqZlyBH349VIdQDI@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).