[PATCH 0/3] usb: host: add TPL support to ehci ohci and dwc2

[PATCH 0/3] usb: host: add TPL support to ehci ohci and dwc2

[Fabrice Gasnier]

The TPL support is used to identify targeted devices during EH compliance
testing. Add TPL support setting from device tree on ehci-platform,
ohci-platform and dwc2 drivers.

Amelie Delaunay (3):
  usb: host: ohci-platform: add TPL support
  usb: host: ehci-platform: add TPL support
  usb: dwc2: host: add TPL support

 drivers/usb/dwc2/hcd.c           | 3 +++
 drivers/usb/host/ehci-platform.c | 2 ++
 drivers/usb/host/ohci-platform.c | 3 +++
 3 files changed, 8 insertions(+)

-- 
2.25.1

[PATCH 1/3] usb: host: ohci-platform: add TPL support

[Fabrice Gasnier]

From: Amelie Delaunay <amelie.delaunay@foss.st.com>

The TPL support is used to identify targeted devices during EH compliance
test. The user can add "tpl-support" in the device tree to enable it.

Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 drivers/usb/host/ohci-platform.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 47dfbfe9e5190..0adae62651276 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -28,6 +28,7 @@
 #include <linux/usb/ohci_pdriver.h>
 #include <linux/usb.h>
 #include <linux/usb/hcd.h>
+#include <linux/usb/of.h>
 
 #include "ohci.h"
 
@@ -210,6 +211,8 @@ static int ohci_platform_probe(struct platform_device *dev)
 	hcd->rsrc_start = res_mem->start;
 	hcd->rsrc_len = resource_size(res_mem);
 
+	hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
+
 	err = usb_add_hcd(hcd, irq, IRQF_SHARED);
 	if (err)
 		goto err_power;
-- 
2.25.1

[PATCH 2/3] usb: host: ehci-platform: add TPL support

[Fabrice Gasnier]

From: Amelie Delaunay <amelie.delaunay@foss.st.com>

The TPL support is used to identify targeted devices during EH compliance
test. The user can add "tpl-support" in the device tree to enable it.

Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 drivers/usb/host/ehci-platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index f343967443e23..6924f0316e9a8 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -370,6 +370,8 @@ static int ehci_platform_probe(struct platform_device *dev)
 	hcd->rsrc_start = res_mem->start;
 	hcd->rsrc_len = resource_size(res_mem);
 
+	hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
+
 	err = usb_add_hcd(hcd, irq, IRQF_SHARED);
 	if (err)
 		goto err_power;
-- 
2.25.1

[PATCH 3/3] usb: dwc2: host: add TPL support

[Fabrice Gasnier]

From: Amelie Delaunay <amelie.delaunay@foss.st.com>

The TPL support is used to identify targeted devices during EH compliance
test. The user can add "tpl-support" in the device tree to enable it.

Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 drivers/usb/dwc2/hcd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index f63a27d11fac8..4567f3c24d225 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -52,6 +52,7 @@
 
 #include <linux/usb/hcd.h>
 #include <linux/usb/ch11.h>
+#include <linux/usb/of.h>
 
 #include "core.h"
 #include "hcd.h"
@@ -5339,6 +5340,8 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
 	/* Don't support SG list at this point */
 	hcd->self.sg_tablesize = 0;
 
+	hcd->tpl_support = of_usb_host_tpl_support(hsotg->dev->of_node);
+
 	if (!IS_ERR_OR_NULL(hsotg->uphy))
 		otg_set_host(hsotg->uphy->otg, &hcd->self);
 
-- 
2.25.1

Re: [PATCH 1/3] usb: host: ohci-platform: add TPL support

[Alan Stern]

On Tue, Jun 21, 2022 at 03:05:04PM +0200, Fabrice Gasnier wrote:
> From: Amelie Delaunay <amelie.delaunay@foss.st.com>
> 
> The TPL support is used to identify targeted devices during EH compliance
> test. The user can add "tpl-support" in the device tree to enable it.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---

For this patch and the 2/3 ehci-platform patch:

Acked-by: Alan Stern <stern@rowland.harvard.edu>

>  drivers/usb/host/ohci-platform.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
> index 47dfbfe9e5190..0adae62651276 100644
> --- a/drivers/usb/host/ohci-platform.c
> +++ b/drivers/usb/host/ohci-platform.c
> @@ -28,6 +28,7 @@
>  #include <linux/usb/ohci_pdriver.h>
>  #include <linux/usb.h>
>  #include <linux/usb/hcd.h>
> +#include <linux/usb/of.h>
>  
>  #include "ohci.h"
>  
> @@ -210,6 +211,8 @@ static int ohci_platform_probe(struct platform_device *dev)
>  	hcd->rsrc_start = res_mem->start;
>  	hcd->rsrc_len = resource_size(res_mem);
>  
> +	hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
> +
>  	err = usb_add_hcd(hcd, irq, IRQF_SHARED);
>  	if (err)
>  		goto err_power;
> -- 
> 2.25.1
> 

Re: [PATCH 1/3] usb: host: ohci-platform: add TPL support

[Greg KH]

On Tue, Jun 21, 2022 at 03:05:04PM +0200, Fabrice Gasnier wrote:
> From: Amelie Delaunay <amelie.delaunay@foss.st.com>
> 
> The TPL support is used to identify targeted devices during EH compliance
> test. The user can add "tpl-support" in the device tree to enable it.

What is "TPL" support?  What is "EH"?

Please spell things out.

thanks,

greg k-h

Re: [PATCH 3/3] usb: dwc2: host: add TPL support

[Greg KH]

On Tue, Jun 21, 2022 at 03:05:06PM +0200, Fabrice Gasnier wrote:
> From: Amelie Delaunay <amelie.delaunay@foss.st.com>
> 
> The TPL support is used to identify targeted devices during EH compliance
> test. The user can add "tpl-support" in the device tree to enable it.

Is that already documented in the proper bindings somewhere?

thanks,

greg k-h