[PATCH -next] drm/logicvc: Fix error return code in logicvc_layer_init()

[PATCH -next] drm/logicvc: Fix error return code in logicvc_layer_init()

[Yang Yingliang]

Fix error return code when logicvc_layer_formats_lookup() fails.

Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index fbebe966f93a..54b5931d879f 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
 
 	formats = logicvc_layer_formats_lookup(layer);
 	if (!formats) {
+		ret = -EINVAL;
 		drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
 			index);
 		goto error;
-- 
2.25.1

Re: [PATCH -next] drm/logicvc: Fix error return code in logicvc_layer_init()

[Paul Kocialkowski]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Hi Yang,

On Thu 23 Jun 22, 22:05, Yang Yingliang wrote:
> Fix error return code when logicvc_layer_formats_lookup() fails.
> 
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Good catch! Yet Dan submitted a similar fix earlier, which is already
on its way to the tree.

Thanks!

Paul

> ---
>  drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> index fbebe966f93a..54b5931d879f 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
>  
>  	formats = logicvc_layer_formats_lookup(layer);
>  	if (!formats) {
> +		ret = -EINVAL;
>  		drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
>  			index);
>  		goto error;
> -- 
> 2.25.1
> 

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]