* [PATCH] lib: bitmap: fix the duplicated comments on bitmap_to_arr64()
@ 2022-06-24 9:31 Qu Wenruo
2022-06-24 15:10 ` Yury Norov
0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2022-06-24 9:31 UTC (permalink / raw)
To: linux-kernel, yury.norov, andriy.shevchenko, linux
Thanks to the recent commit 0a97953fd221 ("lib: add
bitmap_{from,to}_arr64") now we can directly convert a U64 value into a
bitmap and vice verse.
However when checking the header there is duplicated helper for
bitmap_to_arr64(), but no bitmap_from_arr64().
Just fix the copy-n-paste error.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
include/linux/bitmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 2e6cd5681040..f091a1664bf1 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -71,9 +71,9 @@ struct device;
* bitmap_release_region(bitmap, pos, order) Free specified bit region
* bitmap_allocate_region(bitmap, pos, order) Allocate specified bit region
* bitmap_from_arr32(dst, buf, nbits) Copy nbits from u32[] buf to dst
+ * bitmap_from_arr64(dst, buf, nbits) Copy nbits from u64[] buf to dst
* bitmap_to_arr32(buf, src, nbits) Copy nbits from buf to u32[] dst
* bitmap_to_arr64(buf, src, nbits) Copy nbits from buf to u64[] dst
- * bitmap_to_arr64(buf, src, nbits) Copy nbits from buf to u64[] dst
* bitmap_get_value8(map, start) Get 8bit value from map at start
* bitmap_set_value8(map, value, start) Set 8bit value to map at start
*
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib: bitmap: fix the duplicated comments on bitmap_to_arr64()
2022-06-24 9:31 [PATCH] lib: bitmap: fix the duplicated comments on bitmap_to_arr64() Qu Wenruo
@ 2022-06-24 15:10 ` Yury Norov
0 siblings, 0 replies; 2+ messages in thread
From: Yury Norov @ 2022-06-24 15:10 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-kernel, andriy.shevchenko, linux
On Fri, Jun 24, 2022 at 05:31:47PM +0800, Qu Wenruo wrote:
> Thanks to the recent commit 0a97953fd221 ("lib: add
> bitmap_{from,to}_arr64") now we can directly convert a U64 value into a
> bitmap and vice verse.
>
> However when checking the header there is duplicated helper for
> bitmap_to_arr64(), but no bitmap_from_arr64().
>
> Just fix the copy-n-paste error.
I spotted it as well, but you're the first. :-) Thanks.
Applied in bitmap-for-next.
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> include/linux/bitmap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 2e6cd5681040..f091a1664bf1 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -71,9 +71,9 @@ struct device;
> * bitmap_release_region(bitmap, pos, order) Free specified bit region
> * bitmap_allocate_region(bitmap, pos, order) Allocate specified bit region
> * bitmap_from_arr32(dst, buf, nbits) Copy nbits from u32[] buf to dst
> + * bitmap_from_arr64(dst, buf, nbits) Copy nbits from u64[] buf to dst
> * bitmap_to_arr32(buf, src, nbits) Copy nbits from buf to u32[] dst
> * bitmap_to_arr64(buf, src, nbits) Copy nbits from buf to u64[] dst
> - * bitmap_to_arr64(buf, src, nbits) Copy nbits from buf to u64[] dst
> * bitmap_get_value8(map, start) Get 8bit value from map at start
> * bitmap_set_value8(map, value, start) Set 8bit value to map at start
> *
> --
> 2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-24 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 9:31 [PATCH] lib: bitmap: fix the duplicated comments on bitmap_to_arr64() Qu Wenruo
2022-06-24 15:10 ` Yury Norov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).