* [PATCH -next] x86/cyrix: include header linux/isa-dma.h
@ 2022-07-25 20:22 Randy Dunlap
2022-07-25 21:29 ` Stafford Horne
2022-07-26 19:04 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-07-25 20:22 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Stafford Horne, Bjorn Helgaas, Borislav Petkov,
Dave Hansen, x86
x86/kernel/cpu/cyrix.c now needs to include <linux/isa-dma.h>
since the 'isa_dma_bridge_buggy' variable was moved to it.
Fixes this build error:
../arch/x86/kernel/cpu/cyrix.c: In function ‘init_cyrix’:
../arch/x86/kernel/cpu/cyrix.c:277:17: error: ‘isa_dma_bridge_buggy’ undeclared (first use in this function)
277 | isa_dma_bridge_buggy = 2;
Fixes: abb4970ac335 ("PCI: Move isa_dma_bridge_buggy out of asm/dma.h")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
---
arch/x86/kernel/cpu/cyrix.c | 1 +
1 file changed, 1 insertion(+)
--- a/arch/x86/kernel/cpu/cyrix.c
+++ b/arch/x86/kernel/cpu/cyrix.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include <linux/bitops.h>
#include <linux/delay.h>
+#include <linux/isa-dma.h>
#include <linux/pci.h>
#include <asm/dma.h>
#include <linux/io.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] x86/cyrix: include header linux/isa-dma.h
2022-07-25 20:22 [PATCH -next] x86/cyrix: include header linux/isa-dma.h Randy Dunlap
@ 2022-07-25 21:29 ` Stafford Horne
2022-07-26 19:04 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Stafford Horne @ 2022-07-25 21:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Bjorn Helgaas, Borislav Petkov, Dave Hansen, x86
On Mon, Jul 25, 2022 at 01:22:24PM -0700, Randy Dunlap wrote:
> x86/kernel/cpu/cyrix.c now needs to include <linux/isa-dma.h>
> since the 'isa_dma_bridge_buggy' variable was moved to it.
>
> Fixes this build error:
>
> ../arch/x86/kernel/cpu/cyrix.c: In function ‘init_cyrix’:
> ../arch/x86/kernel/cpu/cyrix.c:277:17: error: ‘isa_dma_bridge_buggy’ undeclared (first use in this function)
> 277 | isa_dma_bridge_buggy = 2;
>
> Fixes: abb4970ac335 ("PCI: Move isa_dma_bridge_buggy out of asm/dma.h")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: x86@kernel.org
Acked-by: Stafford Horne <shorne@gmail.com>
> ---
> arch/x86/kernel/cpu/cyrix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/x86/kernel/cpu/cyrix.c
> +++ b/arch/x86/kernel/cpu/cyrix.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <linux/bitops.h>
> #include <linux/delay.h>
> +#include <linux/isa-dma.h>
> #include <linux/pci.h>
> #include <asm/dma.h>
> #include <linux/io.h>
Sorry, I missed this, I did test several x86 configs, but I guess the cyrix.c
compilation was not picked up in my tests.
FWIW, I think this should go through Bjorn's pci tree.
-Stafford
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] x86/cyrix: include header linux/isa-dma.h
2022-07-25 20:22 [PATCH -next] x86/cyrix: include header linux/isa-dma.h Randy Dunlap
2022-07-25 21:29 ` Stafford Horne
@ 2022-07-26 19:04 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2022-07-26 19:04 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Stafford Horne, Bjorn Helgaas, Borislav Petkov,
Dave Hansen, x86
On Mon, Jul 25, 2022 at 01:22:24PM -0700, Randy Dunlap wrote:
> x86/kernel/cpu/cyrix.c now needs to include <linux/isa-dma.h>
> since the 'isa_dma_bridge_buggy' variable was moved to it.
>
> Fixes this build error:
>
> ../arch/x86/kernel/cpu/cyrix.c: In function ‘init_cyrix’:
> ../arch/x86/kernel/cpu/cyrix.c:277:17: error: ‘isa_dma_bridge_buggy’ undeclared (first use in this function)
> 277 | isa_dma_bridge_buggy = 2;
>
> Fixes: abb4970ac335 ("PCI: Move isa_dma_bridge_buggy out of asm/dma.h")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
I appended this to my pci/header-cleanup-immutable branch for v5.20,
thanks!
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: x86@kernel.org
> ---
> arch/x86/kernel/cpu/cyrix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/x86/kernel/cpu/cyrix.c
> +++ b/arch/x86/kernel/cpu/cyrix.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <linux/bitops.h>
> #include <linux/delay.h>
> +#include <linux/isa-dma.h>
> #include <linux/pci.h>
> #include <asm/dma.h>
> #include <linux/io.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-26 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 20:22 [PATCH -next] x86/cyrix: include header linux/isa-dma.h Randy Dunlap
2022-07-25 21:29 ` Stafford Horne
2022-07-26 19:04 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).