[BUG] ASoC: nau8821: Found a bug when removing the module

[BUG] ASoC: nau8821: Found a bug when removing the module

[Zheyu Ma]

Hello,

I found a bug in the driver nau8821.

When removing the module, I got a warning:

[   64.226442] nau8821 0-0010: remove
[   64.227621] ------------[ cut here ]------------
[   64.227918] WARNING: CPU: 5 PID: 243 at kernel/irq/devres.c:144
devm_free_irq+0x80/0x8c
[   64.235307] Call trace:
[   64.235501]  devm_free_irq+0x80/0x8c
[   64.235746]  nau8821_i2c_remove+0x28/0x3c [snd_soc_nau8821]
[   64.236982]  i2c_device_remove+0xcc/0xf8
[   64.237173]  device_release_driver_internal+0x208/0x368
[   64.237406]  driver_detach+0xd8/0x12c
[   64.237583]  bus_remove_driver+0x90/0xd0
[   64.237768]  driver_unregister+0x3c/0x6c
[   64.237952]  i2c_del_driver+0x54/0x74
[   64.238127]  cleanup_module+0x1c/0x1d0 [snd_soc_nau8821]

regards,

Zheyu Ma

Re: [BUG] ASoC: nau8821: Found a bug when removing the module

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

On Sat, Jul 16, 2022 at 05:12:38PM +0800, Zheyu Ma wrote:
> Hello,
> 
> I found a bug in the driver nau8821.
> 
> When removing the module, I got a warning:
> 
> [   64.226442] nau8821 0-0010: remove
> [   64.227621] ------------[ cut here ]------------
> [   64.227918] WARNING: CPU: 5 PID: 243 at kernel/irq/devres.c:144
> devm_free_irq+0x80/0x8c
> [   64.235307] Call trace:
> [   64.235501]  devm_free_irq+0x80/0x8c
> [   64.235746]  nau8821_i2c_remove+0x28/0x3c [snd_soc_nau8821]
> [   64.236982]  i2c_device_remove+0xcc/0xf8

I'm guessing you have no interrupt on this platform, or that jack detect
isn't used since the driver currently only requests the interrupt when
that's enabled (which is a bit dodgy but not the immediate issue).  I've
sent a patch

	https://lore.kernel.org/r/20220718140405.57233-1-broonie@kernel.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]