linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 5.15] batman-adv: Use netif_rx_any_context() any.
@ 2022-07-19 16:08 Sebastian Andrzej Siewior
  2022-07-23 15:19 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2022-07-19 16:08 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Sasha Levin
  Cc: linux-kernel, stable, Antonio Quartulli, Marek Lindner,
	Simon Wunderlich, Sven Eckelmann, b.a.t.m.a.n, David S. Miller,
	Thomas Gleixner

This reverts the stable commit
   e65d78b12fbc0 ("batman-adv: Use netif_rx().")

The commit message says:

| Since commit
|    baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
|
| the function netif_rx() can be used in preemptible/thread context as
| well as in interrupt context.

This commit (baebdf48c3600) has not been backported to the 5.15 stable
series and therefore, the commit which builds upon it, must not be
backported either.

Revert the backport and use netif_rx_any_context() again.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 net/batman-adv/bridge_loop_avoidance.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index 11f6ef657d822..17687848daec5 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -443,7 +443,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac,
 	batadv_add_counter(bat_priv, BATADV_CNT_RX_BYTES,
 			   skb->len + ETH_HLEN);
 
-	netif_rx(skb);
+	netif_rx_any_context(skb);
 out:
 	batadv_hardif_put(primary_if);
 }
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 5.15] batman-adv: Use netif_rx_any_context() any.
  2022-07-19 16:08 [PATCH 5.15] batman-adv: Use netif_rx_any_context() any Sebastian Andrzej Siewior
@ 2022-07-23 15:19 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-07-23 15:19 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: Sasha Levin, linux-kernel, stable, Antonio Quartulli,
	Marek Lindner, Simon Wunderlich, Sven Eckelmann, b.a.t.m.a.n,
	David S. Miller, Thomas Gleixner

On Tue, Jul 19, 2022 at 06:08:12PM +0200, Sebastian Andrzej Siewior wrote:
> This reverts the stable commit
>    e65d78b12fbc0 ("batman-adv: Use netif_rx().")
> 
> The commit message says:
> 
> | Since commit
> |    baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
> |
> | the function netif_rx() can be used in preemptible/thread context as
> | well as in interrupt context.
> 
> This commit (baebdf48c3600) has not been backported to the 5.15 stable
> series and therefore, the commit which builds upon it, must not be
> backported either.
> 
> Revert the backport and use netif_rx_any_context() again.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  net/batman-adv/bridge_loop_avoidance.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-23 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 16:08 [PATCH 5.15] batman-adv: Use netif_rx_any_context() any Sebastian Andrzej Siewior
2022-07-23 15:19 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).